Page MenuHomePhabricator

Duplicate link breaks after remove one of >2 duplicate links
Closed, ResolvedPublic

Description

  • Create document with 4 duplicate links, e.g.
  • [[foo|one]], [[foo|two]], [[foo|three]], [[foo|four]]
  • 3 suggestions mapping to two, three and four are created
  • Click on the first suggestion in the sidebar (two) and resolve it

Observed:

  • There is now only one suggestion left, and when you click it it doesn't expand

Expected:

  • There are two suggestions left which can be expanded.

Real world example:
https://en.wikipedia.org/w/index.php?title=Zvi_Yehuda_Kook&oldid=1334401095&veaction=edit&section=7

Event Timeline

Esanders updated the task description. (Show Details)

Change #1248801 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/VisualEditor@master] DuplicateLinksEditCheck: Fix strict equality test for checks

https://gerrit.wikimedia.org/r/1248801

Change #1248801 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] DuplicateLinksEditCheck: Fix strict equality test for checks

https://gerrit.wikimedia.org/r/1248801

ppelberg added a project: Skipped QA.