Fix focus handling of pinnable elements
Closed, ResolvedPublic1 Estimated Story PointsBUG REPORT
Actions

Assigned To

Authored By

	bwang
	Feb 27 2026, 4:48 PM

Project Tags

Referenced Files

None

Subscribers

Aklapper

bwang

Etonkovidova

Description

Background

When pinning and unpinning an element, the focus should automatically be placed on either the dropdown menu (in the case of clicking unpinning) or the "hide" button (in the case of clicking pinning). Right now it is not handling focus properly.

To reproduce:

pin the Tools menu
click the "hide" button
go to console and log out document.activeElement
see it is undefined

It should be set to the input element for the tools dropdown

Acceptance criteria

Clicking the "move to sidebar" button places focus on the "hide" button
Clicking the "hide" button places focus on the input element in the dropdown

Details

Related Changes in Gerrit:

	Subject	Author	Repo	Branch	Lines +/-
	Fix focus handling when hiding pinnable elements	Bernard Wang	mediawiki/skins/Vector	master	+3 -3

Customize query in gerrit

Event Timeline

bwang created this task.Feb 27 2026, 4:48 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 27 2026, 4:48 PM

bwang set the point value for this task to 1.Feb 27 2026, 4:49 PM

bwang moved this task from Incoming to REx Sprint 15 [Q3 Feb 24 - Mar 9] on the Reader Experience Team board.

bwang edited projects, added: Reader Experience Team (REx Sprint 15 [Q3 Feb 24 - Mar 9]); removed: Reader Experience Team.

Change #1245421 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/Vector@master] Fix focus handling when hiding pinnable elements

https://gerrit.wikimedia.org/r/1245421

gerritbot added a project: Patch-For-Review.Feb 27 2026, 6:06 PM

SToyofuku-WMF triaged this task as Medium priority.Mar 2 2026, 6:04 PM

SToyofuku-WMF moved this task from Ready to Needs code review on the Reader Experience Team (REx Sprint 15 [Q3 Feb 24 - Mar 9]) board.Mar 2 2026, 6:06 PM

Change #1245421 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Fix focus handling when hiding pinnable elements

https://gerrit.wikimedia.org/r/1245421

Volker_E moved this task from Needs code review to Needs QA on the Reader Experience Team (REx Sprint 15 [Q3 Feb 24 - Mar 9]) board.Mar 3 2026, 7:49 PM

ReleaseTaggerBot added a project: MW-1.46-notes (1.46.0-wmf.19; 2026-03-10).Mar 3 2026, 8:00 PM

Maintenance_bot removed a project: Patch-For-Review.Mar 3 2026, 8:31 PM

Checked in enwiki beta

From Acceptance criteria in the task descirption:
✅ - Clicking the "move to sidebar" button places focus on the "hide" button

The visible focus will be on`hide` and Console Live Expression(document.activeElement) will show
button.vector-pinnable-header-toggle-button.vector-pinnable-header-unpin-button

✅ - Clicking the "hide" button places focus on the input element in the dropdown
The visible focus will be on Tools dropdown menu and Console Live Expression(document.activeElement) will show
input#vector-page-tools-dropdown-checkbox.vector-dropdown-checkbox

HFan-WMF closed this task as Resolved.Mar 20 2026, 4:34 PM

HFan-WMF claimed this task.

Fix focus handling of pinnable elementsClosed, ResolvedPublic1 Estimated Story PointsBUG REPORTActions