Page MenuHomePhabricator
Create Task
Maniphest T418660

Deduper: Find potential matches matching any email (secondary or primary)
Closed, ResolvedPublic
Actions

Description

Use new secondary email types to match contacts in WMFContact::Save

This would help identify potential dupes where one contact has a primary email address and the other contact has the same email as a secondary email. Increasingly valuable as we add more secondary email addresses, e.g. for Paypal and other recurring donations.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Few follow up details for contact matching...wikimedia/fundraising/crmmaster+47 -32
Updated contact match rule after we have email with location typewikimedia/fundraising/crmmaster+235 -20
Match secondary email with location type for dedupewikimedia/fundraising/crmmaster+123 -17
Customize query in gerrit

Related Objects
Search...

Event Timeline

Lars created this task.Feb 28 2026, 1:15 AM
Restricted Application removed a project: Patch-For-Review. · View Herald TranscriptFeb 28 2026, 1:15 AM
AKanji-WMF moved this task from Triage to Current Sprint on the Fundraising-Backlog board.Mar 2 2026, 3:42 PM
AnnWF renamed this task from Use new secondary email types to match contacts in WMFContact::Save to Deduper: Find potential matches matching any email (secondary or primary).Mar 2 2026, 7:08 PM
AnnWF merged a task: T418315: Deduper: Find potential matches matching any email (secondary or primary).
AnnWF updated the task description. (Show Details)
AnnWF added subscribers: RLewis, SHust, krobinson, SBurnett-WMF.
AnnWF moved this task from Backlog to Doing on the Fundraising Sprint: Dami's Crib 😀 board.Mar 2 2026, 8:47 PM
gerritbot added a comment.Mar 11 2026, 4:47 AM

Change #1248961 had a related patch set uploaded (by Wfan; author: Wfan):

[wikimedia/fundraising/crm@master] Match secondary email with location type for dedupe

https://gerrit.wikimedia.org/r/1248961

gerritbot added a project: Patch-For-Review.Mar 11 2026, 4:47 AM
AnnWF moved this task from Doing to Ready for Review on the Fundraising Sprint: Dami's Crib 😀 board.Mar 11 2026, 4:49 AM
AKanji-WMF edited projects, added Fundraising Sprint - Entire room is a couch; removed Fundraising Sprint: Dami's Crib 😀.Mar 11 2026, 2:25 PM
AKanji-WMF moved this task from Backlog to Ready for Review on the Fundraising Sprint - Entire room is a couch board.
Lars mentioned this in T412864: Segmentation Cross-Check for Primary and Secondary Emails.Mar 11 2026, 4:26 PM
AnnWF moved this task from Ready for Review to Being Reviewed on the Fundraising Sprint - Entire room is a couch board.Mar 16 2026, 11:27 PM
gerritbot added a comment.Mar 18 2026, 10:58 PM

Change #1255057 had a related patch set uploaded (by Wfan; author: Wfan):

[wikimedia/fundraising/crm@master] Updated contact match rule after we have email with location type

https://gerrit.wikimedia.org/r/1255057

gerritbot added a comment.Mar 18 2026, 10:59 PM

Change #1248961 abandoned by Wfan:

[wikimedia/fundraising/crm@master] Match secondary email with location type for dedupe

Reason:

https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1255057

https://gerrit.wikimedia.org/r/1248961

gerritbot added a comment.Mon, Mar 23, 6:23 PM

Change #1255057 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Updated contact match rule after we have email with location type

https://gerrit.wikimedia.org/r/1255057

AnnWF moved this task from Being Reviewed to Pending Deployment on the Fundraising Sprint - Entire room is a couch board.Mon, Mar 23, 6:41 PM
AnnWF moved this task from Pending Deployment to Done on the Fundraising Sprint - Entire room is a couch board.Mon, Mar 23, 6:55 PM
XenoRyet set Final Story Points to 4.Mon, Mar 23, 7:34 PM
Lars moved this task from Done to Doing on the Fundraising Sprint - Entire room is a couch board.Mon, Mar 23, 7:35 PM
gerritbot added a comment.Mon, Mar 23, 8:39 PM

Change #1259220 had a related patch set uploaded (by Lars SG; author: Lars SG):

[wikimedia/fundraising/crm@master] Few follow up details for contact matching

https://gerrit.wikimedia.org/r/1259220

Lars moved this task from Doing to Ready for Review on the Fundraising Sprint - Entire room is a couch board.Mon, Mar 23, 8:47 PM
gerritbot added a comment.Mon, Mar 23, 11:20 PM

Change #1259220 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Few follow up details for contact matching...

https://gerrit.wikimedia.org/r/1259220

Lars closed this task as Resolved.Tue, Mar 24, 12:56 AM
Damilare mentioned this in T419708: Sprint E- Priorities.Tue, Mar 24, 1:14 PM
AnnWF mentioned this in T421142: Document Contact Save Logic.Tue, Mar 24, 4:50 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits