Page MenuHomePhabricator
Create Task
Maniphest T418743

npm install run twice for core
Closed, ResolvedPublic
Actions

Description

Looking at https://integration.wikimedia.org/ci/job/quibble-for-mediawiki-core-browser-tests-only-vendor-mysql-php83/5642/console it seems like we run npm install twice for mediawiki/core:

npm install in /workspace/src
00:01:07.806 DEBUG:quibble.util:Waiting for Post-dependency install, pre-database dependent steps: 20s elapsed, 1/2 completed
00:01:10.135 INFO:quibble.commands:>>> Start: npm install in /workspace/src
...00:01:10.136 added 1718 packages, and audited 1720 packages in 22s
...
00:01:10.140 * npm install in /workspace/src, in 22.366 s

And then another time:

00:01:10.153 INFO:quibble.commands:>>> Start: Browser tests: mediawiki/core, mediawiki/skins/Vector, mediawiki/vendor
00:01:33.047 added 1718 packages, and audited 1720 packages in 23s

I wonder if it's a bug or a feature? Maybe there could be a way to avoid it and speed up the core job by 20 seconds?

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
api-testing: Make sure npm install runs for api-testingPhedenskogintegration/quibblemaster+6 -2
browser-tests: Skip extra npm install for core testsPhedenskogintegration/quibblemaster+4 -3
selenium: Add run selenium test planPhedenskogintegration/quibblemaster+21 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Peter created this task.Mar 2 2026, 2:36 PM
hashar updated the task description. (Show Details)Mar 4 2026, 10:58 AM
hashar subscribed.Mar 4 2026, 11:23 AM

That is for a change in mediawiki/core which runs browser tests.

The first npm install is for running npm run test which runs the linter which don't even run since the job does quibble --run selenium.

The reason is Quibble runs the installation of MediaWiki and the npm install for linters in parallel as part of the same stage. https://gerrit.wikimedia.org/r/c/integration/quibble/+/757411 . That can surely be optimized (skip installing deps for linter when we know we are not going to run them). Note how we also install the composer dev dependencies (which I believe is done for linters/phpunit etc) even though we know we are not going to need it (--run selenium).

The logic is in build_execution_plan() https://gerrit.wikimedia.org/g/integration/quibble/+/refs/heads/master/quibble/cmd.py#193, which is a bunch of if/else to append steps to plan. So some more cases can be added there maybe. Ideally we would have some kind of dependency system between stages so that when one asks for --run selenium that would add to the build plan the npm install step, that would need some overhaul of the code.

gerritbot added a comment.Mar 9 2026, 7:53 AM

Change #1249093 had a related patch set uploaded (by Phedenskog; author: Phedenskog):

[integration/quibble@master] selenium: Add run selenium test plan

https://gerrit.wikimedia.org/r/1249093

gerritbot added a project: Patch-For-Review.Mar 9 2026, 7:53 AM
gerritbot added a comment.Mar 9 2026, 10:25 AM

Change #1249226 had a related patch set uploaded (by Phedenskog; author: Phedenskog):

[integration/quibble@master] Skip NpmInstall for core when not needed

https://gerrit.wikimedia.org/r/1249226

Peter claimed this task.Mar 30 2026, 2:50 PM
Peter added a project: Test Platform (Črnomerec 24).
Peter moved this task from Backlog to In Progress on the Test Platform (Črnomerec 24) board.
Peter added a parent task: T417130: Speed up quibble-for-mediawiki-core-browser-tests-only-vendor-mysql-php83.Mar 30 2026, 6:35 PM
Peter moved this task from In Progress to In Review on the Test Platform (Črnomerec 24) board.Mar 30 2026, 6:38 PM
gerritbot added a comment.Mar 31 2026, 10:12 AM

Change #1249093 merged by jenkins-bot:

[integration/quibble@master] selenium: Add run selenium test plan

https://gerrit.wikimedia.org/r/1249093

gerritbot added a comment.Apr 1 2026, 6:48 AM

Change #1249226 merged by jenkins-bot:

[integration/quibble@master] browser-tests: Skip extra npm install for core tests

https://gerrit.wikimedia.org/r/1249226

Maintenance_bot removed a project: Patch-For-Review.Apr 1 2026, 7:31 AM
Peter moved this task from In Review to Done on the Test Platform (Črnomerec 24) board.Apr 1 2026, 11:36 AM
Peter closed this task as Resolved.Apr 3 2026, 4:35 AM
hashar mentioned this in T422843: Quibble api-testing stage no more run (npm ci): GrowthExperiments CI fails with sh: 1: mocha: not found.Apr 9 2026, 3:19 PM
hashar added a subtask: T422843: Quibble api-testing stage no more run (npm ci): GrowthExperiments CI fails with sh: 1: mocha: not found.
gerritbot added a comment.Apr 9 2026, 3:38 PM

Change #1269507 had a related patch set uploaded (by Phedenskog; author: Phedenskog):

[integration/quibble@master] api-testing: Make sure npm install runs for api-testing

https://gerrit.wikimedia.org/r/1269507

gerritbot added a project: Patch-For-Review.Apr 9 2026, 3:38 PM
hashar changed the status of subtask T422843: Quibble api-testing stage no more run (npm ci): GrowthExperiments CI fails with sh: 1: mocha: not found from Open to In Progress.Apr 10 2026, 7:36 AM
Peter mentioned this in T422914: Release Quibble 1.17.0 and 1.17.1.Apr 10 2026, 9:09 AM
gerritbot added a comment.Apr 10 2026, 9:19 AM

Change #1269507 merged by jenkins-bot:

[integration/quibble@master] api-testing: Make sure npm install runs for api-testing

https://gerrit.wikimedia.org/r/1269507

Maintenance_bot removed a project: Patch-For-Review.Apr 10 2026, 9:31 AM
hashar closed subtask T422843: Quibble api-testing stage no more run (npm ci): GrowthExperiments CI fails with sh: 1: mocha: not found as Resolved.Apr 10 2026, 10:19 AM
Stashbot added a comment.Apr 10 2026, 10:22 AM

Mentioned in SAL (#wikimedia-releng) [2026-04-10T10:21:59Z] <hashar> Updated apitesting job to Quibble 1.17.1 # T422843 T418743

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits