@AnnWF Let's discuss this one to see how we can make sure it gets updated as we want when DR makes changes and gets handled in merges.

@AnnWF Thinking about this and wondering if there are cases where we would have a low-confidence name and a trustworthy email or vice versa. Wouldn't we expect them to generally be the same? I suppose you can imagine a case where donor relations has set the name, but the email is low-confidence (but in that case, they could upgrade the email to trustworthy). Do you have particular cases in mind?

I think this would be a significant project to do right (making it visible in the UI, setting it automatically when names are changed in the UI), so want to make sure we're clear on the cost/benefit for this.

After discussion during tech talk, we instead of adding a type for name, will assign ach donation form email to billing, then when rule out ach as primary email for trust name source.

Alternative approach.
donation like this 245501195.1, we have no first name and last name come back, since we do not asking this info from donation form, this donor will have no name for their ty email and tax form. Do we want to consider adding first name and last name in ach donation form?
If so no longer need to handle ach differently than other trusted source here.

From Lars' research: looks pretty rare, we only have 23 active recurrings with no name, all started in the last 12 months
https://civicrm.wikimedia.org/civicrm/admin/search#/create/Contact?is_template=0&params=%7B%22version%22:4,%22select%22:%5B%22id%22,%22sort_name%22,%22contact_type:label%22,%22contact_sub_type:label%22,%22Contact_ContributionRecur_contact_id_01.start_date%22%5D,%22orderBy%22:%7B%7D,%22where%22:%5B%5B%22first_name%22,%22IS%20EMPTY%22%5D,%5B%22last_name%22,%22IS%20EMPTY%22%5D%5D,%22groupBy%22:%5B%5D,%22join%22:%5B%5B%22ContributionRecur%20AS%20Contact_ContributionRecur_contact_id_01%22,%22INNER%22,%5B%22id%22,%22%3D%22,%22Contact_ContributionRecur_contact_id_01.contact_id%22%5D,%5B%22Contact_ContributionRecur_contact_id_01.payment_instrument_id:name%22,%22%3D%22,%22%5C%22ACH%5C%22%22%5D,%5B%22Contact_ContributionRecur_contact_id_01.contribution_status_id:name%22,%22%3D%22,%22%5C%22In%20Progress%5C%22%22%5D%5D%5D,%22having%22:%5B%5D%7D
So let's use the approach aligned during tech talk, assign ACH email from donation form to Billing instead of Home to treat as lowconfidence name

Change #1251209 had a related patch set uploaded (by Wfan; author: Wfan):

[wikimedia/fundraising/crm@master] Assign Billing to ACH email from donation form

https://gerrit.wikimedia.org/r/1251209

Change #1254366 had a related patch set uploaded (by Wfan; author: Wfan):

[wikimedia/fundraising/crm@master] seperate ach location type to define one from bank one from form

https://gerrit.wikimedia.org/r/1254366

Change #1254366 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] seperate ach location type to define one from bank one from form

https://gerrit.wikimedia.org/r/1254366

Change #1251209 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Assign achForm as new location type to ACH email from donation form

https://gerrit.wikimedia.org/r/1251209