Escape followed by Tab no longer removes focus from the editor in non-wikitext
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	MusikAnimal
	Mar 3 2026, 4:19 AM

Description

The CodeMirror library has a built-in "escape hatch" where pressing Escape followed by Tab will move focus out of the editor (see docs). This seems to be broken on master, but was working in REL1_45.

The escape hatch is critical for accessibility. It is also documented in the keyboard shortcuts help dialog.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	CodeMirrorSearch: do not always intercept `Escape` key	mediawiki/extensions/CodeMirror	master	+2 -2

Customize query in gerrit

Event Timeline

MusikAnimal created this task.Mar 3 2026, 4:19 AM

MusikAnimal triaged this task as Medium priority.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 3 2026, 4:19 AM

I think it is caused by r1220866 where closePanel() always returns true.

Bhsd claimed this task.Mar 3 2026, 7:59 AM

Change #1247511 had a related patch set uploaded (by Bhsd; author: Bhsd):

[mediawiki/extensions/CodeMirror@master] CodeMirrorSearch: do not always intercept `Escape` key

https://gerrit.wikimedia.org/r/1247511

gerritbot added a project: Patch-For-Review.Mar 3 2026, 8:03 AM

Lol, of course it was me who broke it! Thanks for the fix :)

Change #1247511 merged by jenkins-bot:

[mediawiki/extensions/CodeMirror@master] CodeMirrorSearch: do not always intercept `Escape` key

https://gerrit.wikimedia.org/r/1247511

ReleaseTaggerBot added a project: MW-1.46-notes (1.46.0-wmf.19; 2026-03-10).Mar 3 2026, 7:00 PM

Maintenance_bot removed a project: Patch-For-Review.Mar 3 2026, 7:31 PM

MusikAnimal closed this task as Resolved.Mar 5 2026, 7:44 PM

MusikAnimal moved this task from Bugs to Done on the MediaWiki-extensions-CodeMirror board.

Escape followed by Tab no longer removes focus from the editor in non-wikitextClosed, ResolvedPublicActions

Description

Details

Event Timeline

Escape followed by Tab no longer removes focus from the editor in non-wikitext
Closed, ResolvedPublic
Actions