Page MenuHomePhabricator

🔬 Merge all of the GitHub Action Dependabot updates for Queryservice
Closed, ResolvedPublic

Description

Look at all of the open PRs in: https://github.com/wbstack/queryservice/pulls?q=is%3Apr+is%3Aopen+label%3Agithub_actions

Each of these should be merged in turn. After all the changes have been successfully merged we'll deploy the latest image to staging, check it works and then deploy to production.

Once they are all merged:

  • Manually create a new tag on the latest commit
  • Open PRs for staging/local and production in the wbaas-deploy repo to use the new image
  • Ship this new image to staging. Check staging works and there isn't a spike in errors.
  • Ship this new image to production. Check this also works and there's no spike in errors.

For any Dependabot PRs that can't be merged due to failing checks or complex additional dependencies we should open a ticket in the Engineering Backlog for and skip. If you see an easy, quick way to solve it go ahead and use your judgement though.

Event Timeline

2 more PRs from Dependabot appeared today (Mon, 13th April) and they were merged after all checks were green.

https://github.com/wbstack/queryservice/pull/168
https://github.com/wbstack/queryservice/pull/167

After I merged all the Dependabot's PRs, I tagged the latest main with 0.3.135-wbstack.8 to keep it consistent with other tags. But we have to rethink about this versioning schema.
The un-touched CHANGELOG.md hasn't been updated for a long time and it requires some backtrack and digging through git history so I will create another micro-ticket for updating CHANGELOG.md

@dang mentioned he tested this in a local minikube cluster but is uncertain about how it will behave on staging so please pay particular attention to that

Given that the dependabot changes are all github actions version upgrade, i did not expect the merge to have some impact on the app. That said after the deploy to staging I logged into a wiki on wikibase.dev and access the queryservice tool. it looked healthy and was working so I will deploy this on production and do the same check.