Page MenuHomePhabricator

Adm1 doesn't contain ISO codes for Serbia
Closed, ResolvedPublic

Details

Reference
bz39895

Related Objects

StatusSubtypeAssignedTask
ResolvedNone
ResolvedNone
ResolvedNone

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 12:56 AM
bzimport set Reference to bz39895.
bzimport added a subscriber: Unknown Object (MLST).

Elke, can you have a look at this?

ew-nospam wrote:

We have adm1 information, but it's not ISO. What's the problem, afaik ISO was a nice-to-have-feature here...

adm0 and adm1 always have to be an iso code.

ew-nospam wrote:

sent a diff with iso_okrug

ew-nospam wrote:

3 lists updated with iso values.

Getting a warning:
"""

Getting 34 pages from wikipedia:sr...
Found unknown field: ISO on page СпиÑак_аÑÑ
еолоÑкиÑ
_налазиÑÑа_Ñ_СÑбиÑи
Field: ISO
Value: RS-04 """

The iso field is case sensitive. I'm picking up some iso codes, but not everything is filled yet:

mysql> SELECT iso_okrug, COUNT(iso_okrug) FROM monuments_rs_(sr) GROUP BY iso_okrug;
+-----------+--------------------+

iso_okrugCOUNT(iso_okrug)

+-----------+--------------------+

2113
RS-0037
RS-018
RS-023
RS-033
RS-046
RS-056
RS-0631
RS-0738
RS-0813
RS-0910
RS-101
RS-117
RS-1210
RS-136
RS-1431
RS-1510
RS-1619
RS-176
RS-1815
RS-1910
RS-2013
RS-212
RS-222
RS-236
RS-242
RS-KM2

+-----------+--------------------+
27 rows in set (0.02 sec)

ew-nospam wrote:

one row was with "ISO" instead of "iso", fixed this. Asked the local team to check it.