Page MenuHomePhabricator
Create Task
Maniphest T418981

Various test failures in PHP 8.4 gate and submit job in Wikibase and PropertySuggester
Closed, ResolvedPublic
Actions

Description

The failure only occurs in the PHP 8.4 job. This is currently preventing us from merging a patch for T418774, which is blocking CI for multiple extensions.

10:07:21 There were 11 errors:
10:07:21 
10:07:21 1) PropertySuggester\Tests\PropertySuggester\UpdateTable\Importer\ImportContextTest::testCanImportFromFile
10:07:21 fputcsv(): the $escape parameter must be provided as its default value will change

...

10:07:21 There was 1 failure:
10:07:21 
10:07:21 1) Wikibase\Repo\Tests\RepoHooksTest::testOnContentModelCanBeUsedOn with data set "Wikitext on a page with an entity in a slot" ('wikitext', MediaWiki\Title\TitleValue Object (...), true)
10:07:21 Failed asserting that null is identical to 'slottedEntityType'.
10:07:21 
10:07:21 /workspace/src/extensions/Wikibase/repo/tests/phpunit/includes/RepoHooksTest.php:485
10:07:21 /workspace/src/extensions/Wikibase/repo/tests/phpunit/includes/RepoHooksTest.php:465

https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php84/549/console

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
BasicImporter: Fix fgetcsv() calls for PHP 8.4 compatibilityReedymediawiki/extensions/PropertySuggesterREL1_43+2 -2
BasicImporter: Fix fgetcsv() calls for PHP 8.4 compatibilityReedymediawiki/extensions/PropertySuggesterREL1_45+2 -2
BasicImporter: Fix fgetcsv() calls for PHP 8.4 compatibilityReedymediawiki/extensions/PropertySuggesterREL1_44+2 -2
tests: Pass escape parameter to fputcsv() to unbreak php8.4 testsReedymediawiki/extensions/PropertySuggesterREL1_43+2 -2
tests: Pass escape parameter to fputcsv() to unbreak php8.4 testsReedymediawiki/extensions/PropertySuggesterREL1_44+4 -4
tests: Pass escape parameter to fputcsv() to unbreak php8.4 testsReedymediawiki/extensions/PropertySuggesterREL1_45+4 -4
BasicImporter: Fix fgetcsv() calls for PHP 8.4 compatibilityArendpietermediawiki/extensions/PropertySuggestermaster+2 -2
Pass escape parameter to fgetcsv to unbreak php8.4 testsArthur taylormediawiki/extensions/PropertySuggestermaster+2 -2
tests: Pass escape parameter to fputcsv() to unbreak php8.4 testsUmherirrendermediawiki/extensions/PropertySuggestermaster+4 -4
Provide escape parameter for fputcsvArthur taylormediawiki/extensions/PropertySuggestermaster+2 -2
Customize query in gerrit

Related Objects

Event Timeline

Jakob_WMDE created this task.Mar 4 2026, 9:19 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 4 2026, 9:19 AM
Jakob_WMDE renamed this task from Wikibase RepoHooksTest test failure in PHP 8.4 gate and submit job to Various test failures in PHP 8.4 gate and submit job in Wikibase and PropertySuggester.Mar 4 2026, 9:37 AM
Jakob_WMDE updated the task description. (Show Details)
ArthurTaylor subscribed.Mar 4 2026, 9:46 AM
hashar added a project: PHP 8.4 support.Mar 4 2026, 9:57 AM
hashar added subscribers: Jdforrester-WMF, hashar.

@Jdforrester-WMF turned on PHP 8.4 earlier this week (integration/config #1240989) which was T386108.

There was T415955: Ensure that all Wikimedia-deployed code passes PHP 8.4 CI to verify repositories passed CI by running the quibble-vendor-mysql-php84 job, which is the one reported in this task. It seems like it passed and that validated Wikibase as supporting PHP 8.4 new strictness.

There was T386113 about fgetcsv() and I guess that issue with fputcsv() was not caught somehow?

Jakob_WMDE added a comment.Mar 4 2026, 10:07 AM

The problem is that we have failures in interdependent repos. We can't merge any fix for Wikibase because of the failure in WikibaseLexeme (T418774), and we can't fix Lexeme because of the issues mentioned in this ticket here.

gerritbot added a comment.Mar 4 2026, 10:09 AM

Change #1247949 had a related patch set uploaded (by Arthur taylor; author: Arthur taylor):

[mediawiki/extensions/PropertySuggester@master] Provide escape parameter for fputcsv

https://gerrit.wikimedia.org/r/1247949

gerritbot added a project: Patch-For-Review.Mar 4 2026, 10:09 AM
ArthurTaylor added a project: Wikidata-Omega (The Board).Mar 4 2026, 10:15 AM
ArthurTaylor moved this task from new to the board to In Development on the Wikidata-Omega (The Board) board.
gerritbot added a comment.Mar 4 2026, 10:19 AM

Change #1247949 abandoned by Arthur taylor:

[mediawiki/extensions/PropertySuggester@master] Provide escape parameter for fputcsv

Reason:

abandoned in favour of I25e012bf9878f619d5788836fab8288a9c1a8f8a

https://gerrit.wikimedia.org/r/1247949

hashar added a comment.Mar 4 2026, 10:30 AM
In T418981#11672338, @Jakob_WMDE wrote:

The problem is that we have failures in interdependent repos. We can't merge any fix for Wikibase because of the failure in WikibaseLexeme (T418774), and we can't fix Lexeme because of the issues mentioned in this ticket here.

Oh I understand, well in this specific case, it is OK to submit one of the two changes and by pass CI. I am happy to do it on your behalf if that helps.

Maintenance_bot removed a project: Patch-For-Review.Mar 4 2026, 10:30 AM
ArthurTaylor added a comment.Mar 4 2026, 10:33 AM

Sounds like it might unblock us - we just need to work out which patch needs to go first. How do we submit changes that have verification failures? (I haven't done that before)

gerritbot added a comment.Mar 4 2026, 10:34 AM

Change #1247647 had a related patch set uploaded (by Hashar; author: Umherirrender):

[mediawiki/extensions/PropertySuggester@master] tests: Pass escape parameter to fputcsv() to unbreak php8.4 tests

https://gerrit.wikimedia.org/r/1247647

gerritbot added a project: Patch-For-Review.Mar 4 2026, 10:34 AM
gerritbot added a comment.Mar 4 2026, 10:52 AM

Change #1247647 merged by Hashar:

[mediawiki/extensions/PropertySuggester@master] tests: Pass escape parameter to fputcsv() to unbreak php8.4 tests

https://gerrit.wikimedia.org/r/1247647

ReleaseTaggerBot added a project: MW-1.46-notes (1.46.0-wmf.19; 2026-03-10).Mar 4 2026, 11:00 AM
hashar closed this task as Resolved.Mar 4 2026, 11:15 AM
hashar assigned this task to Umherirrender.
hashar added a subscriber: Umherirrender.

@ArthurTaylor reached out to me about this task via IRC #wikimedia-releng and we synced up there.

The issue was due to usage of fputcsv() in the MediaWiki-extensions-PropertySuggester extension. Fixed by @Umherirrender with https://gerrit.wikimedia.org/r/c/mediawiki/extensions/PropertySuggester/+/1247647

That was blocking over patches made to Wikibase related repositories since PropertySuggester is a dependency for a lot (all?) of them :]

Looks fixed now, thank you!

Jakob_WMDE reopened this task as Open.Mar 4 2026, 11:19 AM

No, this is not resolved yet. There is still the failure in Wikibase itself which also exclusively happens in the 8.4 job:

Wikibase\Repo\Tests\RepoHooksTest::testOnContentModelCanBeUsedOn with data set "Wikitext on a page with an entity in a slot" ('wikitext', MediaWiki\Title\TitleValue Object (...), true)
Failed asserting that null is identical to 'slottedEntityType'.

We're having trouble debugging that without an 8.4-fpm dev image, but I'm looking into building one myself...

Maintenance_bot removed a project: Patch-For-Review.Mar 4 2026, 11:30 AM
gerritbot added a comment.Mar 4 2026, 12:01 PM

Change #1247981 had a related patch set uploaded (by Arthur taylor; author: Arthur taylor):

[mediawiki/extensions/PropertySuggester@master] Pass escape parameter to fgetcsv to unbreak php8.4 tests

https://gerrit.wikimedia.org/r/1247981

gerritbot added a project: Patch-For-Review.Mar 4 2026, 12:01 PM
gerritbot added a comment.Mar 4 2026, 12:10 PM

Change #1247981 abandoned by Arthur taylor:

[mediawiki/extensions/PropertySuggester@master] Pass escape parameter to fgetcsv to unbreak php8.4 tests

Reason:

Abandoned in favour of I23fcb4587b6697bb7015cb7d28a557b1cf2be078

https://gerrit.wikimedia.org/r/1247981

gerritbot added a comment.Mar 4 2026, 12:16 PM

Change #1247978 had a related patch set uploaded (by Arthur taylor; author: Arendpieter):

[mediawiki/extensions/PropertySuggester@master] Fix fgetcsv() calls for PHP 8.4 compatibility

https://gerrit.wikimedia.org/r/1247978

gerritbot added a comment.Mar 4 2026, 2:50 PM

Change #1247978 merged by jenkins-bot:

[mediawiki/extensions/PropertySuggester@master] BasicImporter: Fix fgetcsv() calls for PHP 8.4 compatibility

https://gerrit.wikimedia.org/r/1247978

Jakob_WMDE closed this task as Resolved.Mar 4 2026, 2:55 PM

Ok, the PropertySuggester changes are merged, and the RepoHooksTest::testOnContentModelCanBeUsedOn failure went away somehow. Wikibase CI is green again \o/

Maintenance_bot removed a project: Patch-For-Review.Mar 4 2026, 3:32 PM
karapayneWMDE edited projects, added: Wikidata-Omega (Completed Tasks); removed: Wikidata-Omega (The Board).Mar 19 2026, 1:25 PM
karapayneWMDE moved this task from Newly completed tasks to 2026 Q1 on the Wikidata-Omega (Completed Tasks) board.Mar 19 2026, 2:02 PM
gerritbot added a comment.May 7 2026, 6:02 PM

Change #1284765 had a related patch set uploaded (by Reedy; author: Umherirrender):

[mediawiki/extensions/PropertySuggester@REL1_45] tests: Pass escape parameter to fputcsv() to unbreak php8.4 tests

https://gerrit.wikimedia.org/r/1284765

gerritbot added a project: Patch-For-Review.May 7 2026, 6:02 PM

Change #1284766 had a related patch set uploaded (by Reedy; author: Umherirrender):

[mediawiki/extensions/PropertySuggester@REL1_44] tests: Pass escape parameter to fputcsv() to unbreak php8.4 tests

https://gerrit.wikimedia.org/r/1284766

gerritbot added a comment.May 7 2026, 6:05 PM

Change #1284767 had a related patch set uploaded (by Reedy; author: Umherirrender):

[mediawiki/extensions/PropertySuggester@REL1_43] tests: Pass escape parameter to fputcsv() to unbreak php8.4 tests

https://gerrit.wikimedia.org/r/1284767

gerritbot added a comment.May 7 2026, 6:10 PM

Change #1284765 merged by Reedy:

[mediawiki/extensions/PropertySuggester@REL1_45] tests: Pass escape parameter to fputcsv() to unbreak php8.4 tests

https://gerrit.wikimedia.org/r/1284765

gerritbot added a comment.May 7 2026, 6:12 PM

Change #1284766 merged by Reedy:

[mediawiki/extensions/PropertySuggester@REL1_44] tests: Pass escape parameter to fputcsv() to unbreak php8.4 tests

https://gerrit.wikimedia.org/r/1284766

gerritbot added a comment.May 7 2026, 6:12 PM

Change #1284767 merged by Reedy:

[mediawiki/extensions/PropertySuggester@REL1_43] tests: Pass escape parameter to fputcsv() to unbreak php8.4 tests

https://gerrit.wikimedia.org/r/1284767

Maintenance_bot removed a project: Patch-For-Review.May 7 2026, 6:31 PM
gerritbot added a comment.Jun 24 2026, 3:54 PM

Change #1305464 had a related patch set uploaded (by Reedy; author: Arendpieter):

[mediawiki/extensions/PropertySuggester@REL1_45] BasicImporter: Fix fgetcsv() calls for PHP 8.4 compatibility

https://gerrit.wikimedia.org/r/1305464

gerritbot added a project: Patch-For-Review.Jun 24 2026, 3:54 PM

Change #1305465 had a related patch set uploaded (by Reedy; author: Arendpieter):

[mediawiki/extensions/PropertySuggester@REL1_44] BasicImporter: Fix fgetcsv() calls for PHP 8.4 compatibility

https://gerrit.wikimedia.org/r/1305465

gerritbot added a comment.Jun 24 2026, 3:55 PM

Change #1305466 had a related patch set uploaded (by Reedy; author: Arendpieter):

[mediawiki/extensions/PropertySuggester@REL1_43] BasicImporter: Fix fgetcsv() calls for PHP 8.4 compatibility

https://gerrit.wikimedia.org/r/1305466

gerritbot added a comment.Jun 24 2026, 4:15 PM

Change #1305465 merged by jenkins-bot:

[mediawiki/extensions/PropertySuggester@REL1_44] BasicImporter: Fix fgetcsv() calls for PHP 8.4 compatibility

https://gerrit.wikimedia.org/r/1305465

gerritbot added a comment.Jun 24 2026, 4:19 PM

Change #1305464 merged by Reedy:

[mediawiki/extensions/PropertySuggester@REL1_45] BasicImporter: Fix fgetcsv() calls for PHP 8.4 compatibility

https://gerrit.wikimedia.org/r/1305464

gerritbot added a comment.Jun 24 2026, 4:28 PM

Change #1305466 merged by Reedy:

[mediawiki/extensions/PropertySuggester@REL1_43] BasicImporter: Fix fgetcsv() calls for PHP 8.4 compatibility

https://gerrit.wikimedia.org/r/1305466

Maintenance_bot removed a project: Patch-For-Review.Jun 24 2026, 4:30 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits