Page MenuHomePhabricator
Create Task
Maniphest T419038

Code-review support for Codex PHP
Closed, ResolvedPublic5 Estimated Story Points
Actions

Description

Background

The FY25'26 annual plan PES1.4 KR (Codex adoption increase) seeks to achieve the following:

"By the end of Q4, we'll see a 10% adoption rate increase for Codex among P&T teams."

One of the main projects under this effort is releasing a 1.0 version of Codex PHP.
@Catrope is the primary engineer in this effort, however, he needs code-review support to realize this project.

Since the Reader Experience team has some responsibility towards maintaining the Codex library, and, the Codex PHP project is uniquely valuable to the skin ecosystem, the team should be involved in providing code-review for this code.

Requirements

Provide code review for the following patches related to Codex PHP

i18n specifics

The rest of the patches are not included in the task, and we can ask Roan to remove the lower priority patches from the chain if needed.

Acceptance criteria for done

Requirements

Provide code review for the following patches related to Codex PHP

i18n specifics

Also fix shortcomings while there:

  • Failing phan tests – fixed as part of a Outreachy volunteer patch same time
  • Enforcing PHP 8.1+ multiline trailing comma requirement by help of phpcs for better developer experience and consistency throughout codebase

Details

Other Assignee
Volker_E
Related Changes in Gerrit:
SubjectRepoBranchLines +/-
lint: Enforce trailing comma rule for multi-line arrays and fixdesign/codex-phpmain+42 -36
Fix phan error PhanImpossibleConditiondesign/codex-phpmain+0 -0
Customize query in gerrit

Related Objects

Event Timeline

Jdrewniak created this task.Mar 4 2026, 5:30 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 4 2026, 5:30 PM
Jdrewniak renamed this task from Cod-review support for Codex PHP to Code-review support for Codex PHP.Mar 4 2026, 5:30 PM
Jdrewniak updated the task description. (Show Details)
Jdrewniak updated the task description. (Show Details)
SToyofuku-WMF set the point value for this task to 5.Mar 4 2026, 6:59 PM
SToyofuku-WMF subscribed.

From meeting: on Reader Experience, we're going to treat this as a spike - as it stands the work to review seems spooky so let's try to demystify it!

For the person picking up this ticket:

  1. schedule a meeting with Roan and invite the team - everyone is optional, but let's make sure at least 2-3 engineers are present
  2. try to review the patch, with the 5 point value serving as a rough timebox
  3. by the end of this ticket, either the patch will be merged, or we will have a better understanding of why it was not possible to review it within 5 points of time

Note: there are four patches currently in that query - unless otherwise stated, we are focusing on https://gerrit.wikimedia.org/r/c/design/codex-php/+/1230518 for now

Jdrewniak triaged this task as High priority.Mar 4 2026, 7:27 PM
HFan-WMF moved this task from Incoming to Backlog on the Reader Experience Team board.Mar 10 2026, 4:36 PM
HFan-WMF moved this task from Backlog to Needs refinement on the Reader Experience Team board.Mar 10 2026, 4:54 PM
HFan-WMF moved this task from Needs refinement to Ready for sprint on the Reader Experience Team board.Mar 11 2026, 5:22 PM
HFan-WMF moved this task from Ready for sprint to REx Sprint 16 [Q3 Mar 10 - Mar 23] on the Reader Experience Team board.Mar 16 2026, 6:38 PM
HFan-WMF edited projects, added Reader Experience Team (REx Sprint 16 [Q3 Mar 10 - Mar 23]); removed Reader Experience Team.
AnneT updated the task description. (Show Details)Mar 16 2026, 8:01 PM
AnneT added a subscriber: egardner.
AnneT claimed this task.Mar 16 2026, 8:11 PM
AnneT subscribed.

I'm assigning this to myself as the responsible person, but this will be a collaborative effort between the REx engineers and @egardner

AnneT moved this task from Ready to In progress on the Reader Experience Team (REx Sprint 16 [Q3 Mar 10 - Mar 23]) board.Mar 17 2026, 6:07 PM
bwang claimed this task.Mar 20 2026, 7:45 PM
Jdrewniak edited projects, added Reader Experience Team (REx Sprint 17 [Q3 Mar 24 - Apr 3]); removed Reader Experience Team (REx Sprint 16 [Q3 Mar 10 - Mar 23]).Mar 24 2026, 5:42 PM
bwang moved this task from Ready to In progress on the Reader Experience Team (REx Sprint 17 [Q3 Mar 24 - Apr 3]) board.Mar 24 2026, 5:54 PM
Volker_E updated Other Assignee, added: Volker_E.Mar 24 2026, 5:58 PM
Volker_E moved this task from In progress to Needs code review on the Reader Experience Team (REx Sprint 17 [Q3 Mar 24 - Apr 3]) board.Mar 24 2026, 11:23 PM
Volker_E reassigned this task from bwang to AnneT.Mar 25 2026, 12:25 AM
Volker_E added projects: Codex, I18n.
Volker_E updated the task description. (Show Details)
Volker_E added a subscriber: bwang.
Jdrewniak removed AnneT as the assignee of this task.Mar 25 2026, 6:09 PM
Jdrewniak lowered the priority of this task from High to Medium.
aude assigned this task to bwang.Mar 26 2026, 6:17 PM
gerritbot added a comment.Apr 1 2026, 3:05 AM

Change #1265685 had a related patch set uploaded (by VolkerE; author: VolkerE):

[design/codex-php@main] Fix phan error PhanImpossibleCondition

https://gerrit.wikimedia.org/r/1265685

gerritbot added a project: Patch-For-Review.Apr 1 2026, 3:05 AM
Volker_E updated the task description. (Show Details)Apr 1 2026, 4:01 AM
Volker_E updated the task description. (Show Details)
gerritbot added a comment.Apr 1 2026, 4:26 AM

Change #1265720 had a related patch set uploaded (by VolkerE; author: VolkerE):

[design/codex-php@main] lint: Enforce trailing comma rule for multi-line arrays and fix

https://gerrit.wikimedia.org/r/1265720

gerritbot added a comment.Apr 1 2026, 7:41 PM

Change #1265685 abandoned by Umherirrender:

[design/codex-php@main] Fix phan error PhanImpossibleCondition

Reason:

Was fixed as part of I3fdae440e7807c4aef5c41caf29c913d1d80d401

https://gerrit.wikimedia.org/r/1265685

Volker_E updated the task description. (Show Details)Apr 1 2026, 7:44 PM
gerritbot added a comment.Apr 2 2026, 5:57 PM

Change #1265720 merged by jenkins-bot:

[design/codex-php@main] lint: Enforce trailing comma rule for multi-line arrays and fix

https://gerrit.wikimedia.org/r/1265720

jenkins-bot mentioned this in rDCPH356feb6cfa5b: lint: Enforce trailing comma rule for multi-line arrays and fix.Apr 2 2026, 5:58 PM
Volker_E edited projects, added Developer Productivity; removed Patch-For-Review.Apr 2 2026, 6:01 PM
Volker_E updated the task description. (Show Details)
Volker_E moved this task from Needs code review to Sign-off on the Reader Experience Team (REx Sprint 17 [Q3 Mar 24 - Apr 3]) board.
Volker_E closed this task as Resolved.Apr 13 2026, 4:43 PM
Volker_E subscribed.

Just boldly go ahead with resolving this.
We went beyond the acceptance criteria in the task description, identified and fixed a few shortcomings in the process.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits