Page MenuHomePhabricator
Create Task
Maniphest T419051

Refine Composition Language V2
Closed, ResolvedPublic
Actions

Description

Description

Error handling for composition language V2 remains slightly degraded compared to V1. Some optimizations and code cleanup remain. These issues should not block productionization, but we should address them immediately after the initial rollout.

Completion checklist

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedcmassaroT419051 Refine Composition Language V2
 ResolvedJdforrester-WMFT413729 Ensure that all current unit tests pass with the new /v2/evaluate
 ResolvedcmassaroT413730 Ensure that evaluated implementations work with /v2/evaluate
 ResolvedecargT413728 Migrate all builtin functions to work with the new transpiled version
 ResolvedcmassaroT413731 Consider what to do with validation
 ResolvedcmassaroT413792 Support all existing metadata in composition language V2
 ResolvedcmassaroT413732 Build the initial transpilation system and wire it up for use in a new endpoint
 ResolvedcmassaroT413838 Handle global and local keys in composition language V2
 ResolvedcmassaroT413839 Address error handling in composition language V2
 ResolvedcmassaroT413882 Handle multiple implementations for a single function call in composition language V2
 ResolvedcmassaroT417281 Support lazy functions in composition language V2
 ResolvedcmassaroT417875 Ensure that type converters work with composition language v2
 ResolvedJdforrester-WMFT413840 Optimize composition language V2
 ResolvedJdforrester-WMFT418016 Banish circular refrences from Invariants
 ResolvedecargT426330 Cache realize/fullyRealize/asZObject state on WFBase
 ResolvedcmassaroT426332 built-ins: stop round-tripping WFBase through asZObject
 ResolvedJdforrester-WMFT426333 setMetadataValues is O(n²); rewrite to O(n)
 ResolvedecargT426334 Parallelise remaining independent awaits with Promise.all
 ResolvedecargT426335 Audit and tighten WFFunction.maybeValidateInternal
 ResolvedecargT426914 Replace numeric ZID heuristic in maybeValidateInternal with registry lookup
 ResolvedcmassaroT426336 Investigate WFImplementation.realizeFullType non-WFBase fallback
 ResolvedGkm563T426338 Add accessors for WFFunctionCall internals
 ResolvedJdforrester-WMFT426409 Use a Map based on `Z1K1` instead of a series of indicator functions in WFBase.from
 ResolvedJdforrester-WMFT426410 WFCodeImpl.evaluate: Probe the evaluator inside the impl branch, not after Promise.all
 ResolvedJdforrester-WMFT426411 In `evaluate()`, don't generate a fake Z7; just create the exchange format directly
 ResolvedJdforrester-WMFT426412 In `evaluate()`, skip the type converter work if the call is to a built-in
 ResolvedJdforrester-WMFT412955 Validate that compositions that previously were broken are now fixed by the new composition language
 ResolvedBUG REPORTJdforrester-WMFT411565 Z802/if treats an instance of a Typed list, a Typed pair, a Typed map or Void as False, rather than as non-Boolean
 ResolvedBUG REPORTcmassaroT417631 Z866/string equality returns True or False when arguments are different and at least one is a Typed pair
 ResolvedcmassaroT415105 Create isZ* utility functions that work with WFBase

Event Timeline

cmassaro created this task.Mar 4 2026, 6:41 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 4 2026, 6:42 PM
cmassaro added a subtask: T413729: Ensure that all current unit tests pass with the new /v2/evaluate.Mar 4 2026, 6:42 PM
cmassaro added a subtask: T413840: Optimize composition language V2.
cmassaro added a subtask: T412955: Validate that compositions that previously were broken are now fixed by the new composition language.
cmassaro added a parent task: T412953: Create a composition interpreter to improve performance.
DSantamaria added a project: OKR-Work.Mar 5 2026, 8:32 AM
Jdforrester-WMF moved this task from Incoming to Ready on the Abstract Wikipedia team (26Q3 (Jan–Mar)) board.Mar 10 2026, 5:57 PM
Jdforrester-WMF closed subtask T413729: Ensure that all current unit tests pass with the new /v2/evaluate as Resolved.Apr 8 2026, 2:25 PM
Jdforrester-WMF added a subtask: T415105: Create isZ* utility functions that work with WFBase.
Jdforrester-WMF closed subtask T412955: Validate that compositions that previously were broken are now fixed by the new composition language as Resolved.Apr 16 2026, 12:09 AM
Jdforrester-WMF edited projects, added: Abstract Wikipedia team; removed: Abstract Wikipedia team (26Q3 (Jan–Mar)).
Jdforrester-WMF subscribed.

This was tagged against Q3 because we thought it might get done during the v2 re-write; not complete, so moving up.

Jdforrester-WMF triaged this task as Medium priority.Apr 23 2026, 5:22 PM
Jdforrester-WMF removed a parent task: T412953: Create a composition interpreter to improve performance.
Jdforrester-WMF edited projects, added: Abstract Wikipedia Fix-It tasks; removed: OKR-Work.
Jdforrester-WMF moved this task from To Triage to Engineering Backlog on the Abstract Wikipedia team board.
Jdforrester-WMF changed the status of subtask T413840: Optimize composition language V2 from Open to In Progress.May 13 2026, 11:20 PM
Jdforrester-WMF closed this task as Resolved.Jun 10 2026, 2:26 PM
Jdforrester-WMF assigned this task to cmassaro.
Jdforrester-WMF closed subtask T415105: Create isZ* utility functions that work with WFBase as Resolved.
Jdforrester-WMF edited projects, added: Abstract Wikipedia team (26Q4 (Apr–Jun)), Essential-Work; removed: Abstract Wikipedia team.
Jdforrester-WMF moved this task from Incoming to Needs Sign-off on the Abstract Wikipedia team (26Q4 (Apr–Jun)) board.
Jdforrester-WMF closed subtask T413840: Optimize composition language V2 as Resolved.Jun 23 2026, 3:30 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits