Page MenuHomePhabricator

PHP 8.5 CI failure in Translate: "Using null as an array offset is deprecated, use an empty string instead"
Closed, ResolvedPublic

Description

00:01:33.902 There were 5 errors:
00:01:33.902 
00:01:33.902 1) MediaWiki\Extension\Translate\FileFormatSupport\AmdFormatTest::testExport
00:01:33.902 Using null as an array offset is deprecated, use an empty string instead
00:01:33.902 
00:01:33.902 /workspace/src/extensions/Translate/src/MessageLoading/MessageCollection.php:957
00:01:33.902 /workspace/src/extensions/Translate/src/FileFormatSupport/AmdFormat.php:83
00:01:33.902 /workspace/src/extensions/Translate/src/FileFormatSupport/SimpleFormat.php:220
00:01:33.902 /workspace/src/extensions/Translate/tests/phpunit/FileFormatSupport/AmdFormatTest.php:101
00:01:33.902 
00:01:33.902 2) MediaWiki\Extension\Translate\FileFormatSupport\AndroidXmlFormatTest::testWrite
00:01:33.903 Using null as an array offset is deprecated, use an empty string instead
00:01:33.903 
00:01:33.903 /workspace/src/extensions/Translate/src/MessageLoading/MessageCollection.php:957
00:01:33.903 /workspace/src/extensions/Translate/src/FileFormatSupport/AndroidXmlFormat.php:164
00:01:33.903 /workspace/src/extensions/Translate/src/FileFormatSupport/SimpleFormat.php:220
00:01:33.903 /workspace/src/extensions/Translate/tests/phpunit/FileFormatSupport/AndroidXmlFormatTest.php:109
00:01:33.903 
00:01:33.903 3) MediaWiki\Extension\Translate\FileFormatSupport\AndroidXmlFormatTest::testWriteDoc
00:01:33.903 Using null as an array offset is deprecated, use an empty string instead
00:01:33.903 
00:01:33.903 /workspace/src/extensions/Translate/src/MessageLoading/MessageCollection.php:957
00:01:33.903 /workspace/src/extensions/Translate/src/FileFormatSupport/AndroidXmlFormat.php:164
00:01:33.903 /workspace/src/extensions/Translate/src/FileFormatSupport/SimpleFormat.php:220
00:01:33.903 /workspace/src/extensions/Translate/tests/phpunit/FileFormatSupport/AndroidXmlFormatTest.php:130
00:01:33.903 
00:01:33.903 4) MediaWiki\Extension\Translate\FileFormatSupport\IniFormatTest::testExport
00:01:33.903 Using null as an array offset is deprecated, use an empty string instead
00:01:33.903 
00:01:33.903 /workspace/src/extensions/Translate/src/MessageLoading/MessageCollection.php:957
00:01:33.903 /workspace/src/extensions/Translate/src/FileFormatSupport/IniFormat.php:57
00:01:33.903 /workspace/src/extensions/Translate/src/FileFormatSupport/SimpleFormat.php:220
00:01:33.903 /workspace/src/extensions/Translate/tests/phpunit/FileFormatSupport/IniFormatTest.php:70
00:01:33.903 
00:01:33.903 5) MediaWiki\Extension\Translate\FileFormatSupport\JsonFormatTest::testExport
00:01:33.903 Using null as an array offset is deprecated, use an empty string instead
00:01:33.903 
00:01:33.903 /workspace/src/extensions/Translate/src/MessageLoading/MessageCollection.php:957
00:01:33.903 /workspace/src/extensions/Translate/src/FileFormatSupport/JsonFormat.php:73
00:01:33.903 /workspace/src/extensions/Translate/src/FileFormatSupport/SimpleFormat.php:220
00:01:33.903 /workspace/src/extensions/Translate/tests/phpunit/FileFormatSupport/JsonFormatTest.php:112

Event Timeline

Vanshika subscribed.

Hi! I'd like to work on this task. I'll investigate the PHP 8.5 deprecation related to using null as an array offset in MessageCollection.php and propose a fix.

Hi! I'd like to work on this task. I'll investigate the PHP 8.5 deprecation related to using null as an array offset in MessageCollection.php and propose a fix.

Hi @Vanshika, did you get anywhere with your fix? I'd quite like to get this resolved soon so we can enforce PHP 8.5 passing in CI.

neriah changed the task status from Open to In Progress.Mar 16 2026, 1:58 PM
neriah claimed this task.

No response from @Vanshika. I'll do it myself.

Change #1253504 had a related patch set uploaded (by Neriah; author: Neriah):

[mediawiki/extensions/Translate@master] Translate: Fix null array offset for PHP 8.5 compatibility

https://gerrit.wikimedia.org/r/1253504

Change #1253580 had a related patch set uploaded (by Neriah; author: Neriah):

[mediawiki/extensions/Translate@REL1_45] Translate: Fix null array offset for PHP 8.5 compatibility

https://gerrit.wikimedia.org/r/1253580

Change #1253581 had a related patch set uploaded (by Neriah; author: Neriah):

[mediawiki/extensions/Translate@REL1_44] Translate: Fix null array offset for PHP 8.5 compatibility

https://gerrit.wikimedia.org/r/1253581

Change #1253504 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Translate: Fix null array offset for PHP 8.5 compatibility

https://gerrit.wikimedia.org/r/1253504

Change #1253582 had a related patch set uploaded (by Neriah; author: Neriah):

[mediawiki/extensions/Translate@REL1_43] Translate: Fix null array offset for PHP 8.5 compatibility

https://gerrit.wikimedia.org/r/1253582

Change #1253581 merged by jenkins-bot:

[mediawiki/extensions/Translate@REL1_44] Translate: Fix null array offset for PHP 8.5 compatibility

https://gerrit.wikimedia.org/r/1253581

Change #1253580 merged by jenkins-bot:

[mediawiki/extensions/Translate@REL1_45] Translate: Fix null array offset for PHP 8.5 compatibility

https://gerrit.wikimedia.org/r/1253580

Change #1253582 merged by jenkins-bot:

[mediawiki/extensions/Translate@REL1_43] Translate: Fix null array offset for PHP 8.5 compatibility

https://gerrit.wikimedia.org/r/1253582