Page MenuHomePhabricator

PHP 8.5 CI failure in CirrusSearch: "Using null as an array offset is deprecated, use an empty string instead"
Closed, ResolvedPublic

Description

00:02:06.787 1) CirrusSearch\Assignment\MultiClusterAssignmentTest::testReplicasMustExist
00:02:06.790 Using null as an array offset is deprecated, use an empty string instead
00:02:06.790 
00:02:06.790 /workspace/src/extensions/CirrusSearch/includes/Assignment/MultiClusterAssignment.php:166
00:02:06.790 /workspace/src/extensions/CirrusSearch/tests/phpunit/unit/Assignment/MultiClusterAssignmentTest.php:257
00:02:06.790 
00:02:06.790 2) CirrusSearch\Query\InSourceTest::testRegex with data set "supports simple regex" ('insource:/bar/', '', 'bar', false)
00:02:06.790 Using null as an array offset is deprecated, use an empty string instead
00:02:06.790 
00:02:06.790 /workspace/src/extensions/CirrusSearch/includes/Extra/Query/SourceRegex.php:140
00:02:06.790 /workspace/src/extensions/CirrusSearch/includes/Query/BaseRegexFeature.php:304
00:02:06.790 /workspace/src/extensions/CirrusSearch/includes/Query/BaseRegexFeature.php:246
00:02:06.790 /workspace/src/extensions/CirrusSearch/includes/Query/BaseRegexFeature.php:179
00:02:06.790 /workspace/src/extensions/CirrusSearch/includes/Query/SimpleKeywordFeature.php:286
00:02:06.790 /workspace/src/extensions/CirrusSearch/includes/Query/SimpleKeywordFeature.php:306
00:02:06.790 /workspace/src/extensions/CirrusSearch/tests/phpunit/unit/Query/KeywordFeatureAssertions.php:254
00:02:06.790 /workspace/src/extensions/CirrusSearch/tests/phpunit/unit/Query/SimpleKeywordFeatureTestTrait.php:97
00:02:06.790 /workspace/src/extensions/CirrusSearch/tests/phpunit/unit/Query/InSourceTest.php:164
00:02:06.790 
00:02:06.790 3) CirrusSearch\Query\InSourceTest::testRegex with data set "supports simple case insensitive regex" ('insource:/bar/i', '', 'bar', true)
00:02:06.790 Using null as an array offset is deprecated, use an empty string instead
00:02:06.790 
00:02:06.790 /workspace/src/extensions/CirrusSearch/includes/Extra/Query/SourceRegex.php:140
00:02:06.790 /workspace/src/extensions/CirrusSearch/includes/Query/BaseRegexFeature.php:304
00:02:06.790 /workspace/src/extensions/CirrusSearch/includes/Query/BaseRegexFeature.php:246
00:02:06.790 /workspace/src/extensions/CirrusSearch/includes/Query/BaseRegexFeature.php:179
00:02:06.790 /workspace/src/extensions/CirrusSearch/includes/Query/SimpleKeywordFeature.php:286
00:02:06.790 /workspace/src/extensions/CirrusSearch/includes/Query/SimpleKeywordFeature.php:306
00:02:06.790 /workspace/src/extensions/CirrusSearch/tests/phpunit/unit/Query/KeywordFeatureAssertions.php:254
00:02:06.790 /workspace/src/extensions/CirrusSearch/tests/phpunit/unit/Query/SimpleKeywordFeatureTestTrait.php:97
00:02:06.791 /workspace/src/extensions/CirrusSearch/tests/phpunit/unit/Query/InSourceTest.php:164
00:02:06.791 
00:02:06.791 4) CirrusSearch\Query\InSourceTest::testRegex with data set "supports negation" ('-insource:/bar/', '', 'bar', false)
00:02:06.791 Using null as an array offset is deprecated, use an empty string instead
00:02:06.791 
00:02:06.791 /workspace/src/extensions/CirrusSearch/includes/Extra/Query/SourceRegex.php:140
00:02:06.791 /workspace/src/extensions/CirrusSearch/includes/Query/BaseRegexFeature.php:304
00:02:06.791 /workspace/src/extensions/CirrusSearch/includes/Query/BaseRegexFeature.php:246
00:02:06.791 /workspace/src/extensions/CirrusSearch/includes/Query/BaseRegexFeature.php:179
00:02:06.791 /workspace/src/extensions/CirrusSearch/includes/Query/SimpleKeywordFeature.php:286
00:02:06.791 /workspace/src/extensions/CirrusSearch/includes/Query/SimpleKeywordFeature.php:306
00:02:06.791 /workspace/src/extensions/CirrusSearch/tests/phpunit/unit/Query/KeywordFeatureAssertions.php:254
00:02:06.791 /workspace/src/extensions/CirrusSearch/tests/phpunit/unit/Query/SimpleKeywordFeatureTestTrait.php:97
00:02:06.791 /workspace/src/extensions/CirrusSearch/tests/phpunit/unit/Query/InSourceTest.php:164
00:02:06.791 
00:02:06.791 5) CirrusSearch\Query\InSourceTest::testRegex with data set "supports negation simple case insensitive regex" ('-insource:/bar/i', '', 'bar', true)
00:02:06.791 Using null as an array offset is deprecated, use an empty string instead
00:02:06.791 
00:02:06.791 /workspace/src/extensions/CirrusSearch/includes/Extra/Query/SourceRegex.php:140
00:02:06.791 /workspace/src/extensions/CirrusSearch/includes/Query/BaseRegexFeature.php:304
00:02:06.791 /workspace/src/extensions/CirrusSearch/includes/Query/BaseRegexFeature.php:246
00:02:06.791 /workspace/src/extensions/CirrusSearch/includes/Query/BaseRegexFeature.php:179
00:02:06.791 /workspace/src/extensions/CirrusSearch/includes/Query/SimpleKeywordFeature.php:286
00:02:06.791 /workspace/src/extensions/CirrusSearch/includes/Query/SimpleKeywordFeature.php:306
00:02:06.791 /workspace/src/extensions/CirrusSearch/tests/phpunit/unit/Query/KeywordFeatureAssertions.php:254
00:02:06.791 /workspace/src/extensions/CirrusSearch/tests/phpunit/unit/Query/SimpleKeywordFeatureTestTrait.php:97
00:02:06.792 /workspace/src/extensions/CirrusSearch/tests/phpunit/unit/Query/InSourceTest.php:164
00:02:06.792 
00:02:06.792 6) CirrusSearch\Query\InSourceTest::testRegex with data set "do not unescape the regex" ('insource:/foo\/bar/', '', 'foo\/bar', false)
00:02:06.792 Using null as an array offset is deprecated, use an empty string instead
00:02:06.792 
00:02:06.792 /workspace/src/extensions/CirrusSearch/includes/Extra/Query/SourceRegex.php:140
00:02:06.792 /workspace/src/extensions/CirrusSearch/includes/Query/BaseRegexFeature.php:304
00:02:06.792 /workspace/src/extensions/CirrusSearch/includes/Query/BaseRegexFeature.php:246
00:02:06.792 /workspace/src/extensions/CirrusSearch/includes/Query/BaseRegexFeature.php:179
00:02:06.792 /workspace/src/extensions/CirrusSearch/includes/Query/SimpleKeywordFeature.php:286
00:02:06.792 /workspace/src/extensions/CirrusSearch/includes/Query/SimpleKeywordFeature.php:306
00:02:06.792 /workspace/src/extensions/CirrusSearch/tests/phpunit/unit/Query/KeywordFeatureAssertions.php:254
00:02:06.792 /workspace/src/extensions/CirrusSearch/tests/phpunit/unit/Query/SimpleKeywordFeatureTestTrait.php:97
00:02:06.792 /workspace/src/extensions/CirrusSearch/tests/phpunit/unit/Query/InSourceTest.php:164
00:02:06.792 
00:02:06.792 7) CirrusSearch\Query\InSourceTest::testRegex with data set "do not unescape the regex and keep insensitive flag" ('insource:/foo\/bar/i', '', 'foo\/bar', true)
00:02:06.792 Using null as an array offset is deprecated, use an empty string instead
00:02:06.792 
00:02:06.792 /workspace/src/extensions/CirrusSearch/includes/Extra/Query/SourceRegex.php:140
00:02:06.792 /workspace/src/extensions/CirrusSearch/includes/Query/BaseRegexFeature.php:304
00:02:06.792 /workspace/src/extensions/CirrusSearch/includes/Query/BaseRegexFeature.php:246
00:02:06.792 /workspace/src/extensions/CirrusSearch/includes/Query/BaseRegexFeature.php:179
00:02:06.792 /workspace/src/extensions/CirrusSearch/includes/Query/SimpleKeywordFeature.php:286
00:02:06.793 /workspace/src/extensions/CirrusSearch/includes/Query/SimpleKeywordFeature.php:306
00:02:06.793 /workspace/src/extensions/CirrusSearch/tests/phpunit/unit/Query/KeywordFeatureAssertions.php:254
00:02:06.793 /workspace/src/extensions/CirrusSearch/tests/phpunit/unit/Query/SimpleKeywordFeatureTestTrait.php:97
00:02:06.793 /workspace/src/extensions/CirrusSearch/tests/phpunit/unit/Query/InSourceTest.php:164
00:02:06.793 
00:02:06.793 8) CirrusSearch\Query\InSourceTest::testRegex with data set "do not stop on quote" ('insource:/foo"bar/i', '', 'foo"bar', true)
00:02:06.793 Using null as an array offset is deprecated, use an empty string instead
00:02:06.793 
00:02:06.793 /workspace/src/extensions/CirrusSearch/includes/Extra/Query/SourceRegex.php:140
00:02:06.793 /workspace/src/extensions/CirrusSearch/includes/Query/BaseRegexFeature.php:304
00:02:06.793 /workspace/src/extensions/CirrusSearch/includes/Query/BaseRegexFeature.php:246
00:02:06.793 /workspace/src/extensions/CirrusSearch/includes/Query/BaseRegexFeature.php:179
00:02:06.793 /workspace/src/extensions/CirrusSearch/includes/Query/SimpleKeywordFeature.php:286
00:02:06.793 /workspace/src/extensions/CirrusSearch/includes/Query/SimpleKeywordFeature.php:306
00:02:06.793 /workspace/src/extensions/CirrusSearch/tests/phpunit/unit/Query/KeywordFeatureAssertions.php:254
00:02:06.793 /workspace/src/extensions/CirrusSearch/tests/phpunit/unit/Query/SimpleKeywordFeatureTestTrait.php:97
00:02:06.793 /workspace/src/extensions/CirrusSearch/tests/phpunit/unit/Query/InSourceTest.php:164
00:02:06.793 
00:02:06.793 9) CirrusSearch\Query\InSourceTest::testRegex with data set "if the last character of the pattern searched is "/"" ('insource:/\/Documentation\//', '', '\/Documentation\/', false)
00:02:06.793 Using null as an array offset is deprecated, use an empty string instead
00:02:06.793 
00:02:06.793 /workspace/src/extensions/CirrusSearch/includes/Extra/Query/SourceRegex.php:140
00:02:06.793 /workspace/src/extensions/CirrusSearch/includes/Query/BaseRegexFeature.php:304
00:02:06.793 /workspace/src/extensions/CirrusSearch/includes/Query/BaseRegexFeature.php:246
00:02:06.793 /workspace/src/extensions/CirrusSearch/includes/Query/BaseRegexFeature.php:179
00:02:06.794 /workspace/src/extensions/CirrusSearch/includes/Query/SimpleKeywordFeature.php:286
00:02:06.794 /workspace/src/extensions/CirrusSearch/includes/Query/SimpleKeywordFeature.php:306
00:02:06.794 /workspace/src/extensions/CirrusSearch/tests/phpunit/unit/Query/KeywordFeatureAssertions.php:254
00:02:06.794 /workspace/src/extensions/CirrusSearch/tests/phpunit/unit/Query/SimpleKeywordFeatureTestTrait.php:97
00:02:06.794 /workspace/src/extensions/CirrusSearch/tests/phpunit/unit/Query/InSourceTest.php:164
00:02:06.794 
00:02:06.794 10) CirrusSearch\Query\InTitleFeatureTest::testRegex with data set "supports simple regex" ('intitle:/bar/', '', false, 'bar', false)
00:02:06.794 Using null as an array offset is deprecated, use an empty string instead
00:02:06.794 
00:02:06.794 /workspace/src/extensions/CirrusSearch/includes/Extra/Query/SourceRegex.php:140
00:02:06.794 /workspace/src/extensions/CirrusSearch/includes/Query/BaseRegexFeature.php:304
00:02:06.794 /workspace/src/extensions/CirrusSearch/includes/Query/BaseRegexFeature.php:246
00:02:06.794 /workspace/src/extensions/CirrusSearch/includes/Query/BaseRegexFeature.php:179
00:02:06.794 /workspace/src/extensions/CirrusSearch/includes/Query/SimpleKeywordFeature.php:286
00:02:06.794 /workspace/src/extensions/CirrusSearch/includes/Query/SimpleKeywordFeature.php:306
00:02:06.794 /workspace/src/extensions/CirrusSearch/tests/phpunit/unit/Query/KeywordFeatureAssertions.php:254
00:02:06.794 /workspace/src/extensions/CirrusSearch/tests/phpunit/unit/Query/SimpleKeywordFeatureTestTrait.php:97
00:02:06.794 /workspace/src/extensions/CirrusSearch/tests/phpunit/unit/Query/InTitleFeatureTest.php:123
00:02:06.794 
00:02:06.794 11) CirrusSearch\Query\InTitleFeatureTest::testRegex with data set "supports simple case insensitive regex" ('intitle:/bar/i', '', false, 'bar', true)
00:02:06.794 Using null as an array offset is deprecated, use an empty string instead
00:02:06.794 
00:02:06.794 /workspace/src/extensions/CirrusSearch/includes/Extra/Query/SourceRegex.php:140
00:02:06.794 /workspace/src/extensions/CirrusSearch/includes/Query/BaseRegexFeature.php:304
00:02:06.794 /workspace/src/extensions/CirrusSearch/includes/Query/BaseRegexFeature.php:246
00:02:06.794 /workspace/src/extensions/CirrusSearch/includes/Query/BaseRegexFeature.php:179
00:02:06.795 /workspace/src/extensions/CirrusSearch/includes/Query/SimpleKeywordFeature.php:286
00:02:06.795 /workspace/src/extensions/CirrusSearch/includes/Query/SimpleKeywordFeature.php:306
00:02:06.795 /workspace/src/extensions/CirrusSearch/tests/phpunit/unit/Query/KeywordFeatureAssertions.php:254
00:02:06.795 /workspace/src/extensions/CirrusSearch/tests/phpunit/unit/Query/SimpleKeywordFeatureTestTrait.php:97
00:02:06.795 /workspace/src/extensions/CirrusSearch/tests/phpunit/unit/Query/InTitleFeatureTest.php:123
00:02:06.795 
00:02:06.795 12) CirrusSearch\Query\InTitleFeatureTest::testRegex with data set "supports negation" ('-intitle:/bar/', '', true, 'bar', false)
00:02:06.795 Using null as an array offset is deprecated, use an empty string instead
00:02:06.795 
00:02:06.795 /workspace/src/extensions/CirrusSearch/includes/Extra/Query/SourceRegex.php:140
00:02:06.795 /workspace/src/extensions/CirrusSearch/includes/Query/BaseRegexFeature.php:304
00:02:06.795 /workspace/src/extensions/CirrusSearch/includes/Query/BaseRegexFeature.php:246
00:02:06.795 /workspace/src/extensions/CirrusSearch/includes/Query/BaseRegexFeature.php:179
00:02:06.795 /workspace/src/extensions/CirrusSearch/includes/Query/SimpleKeywordFeature.php:286
00:02:06.795 /workspace/src/extensions/CirrusSearch/includes/Query/SimpleKeywordFeature.php:306
00:02:06.795 /workspace/src/extensions/CirrusSearch/tests/phpunit/unit/Query/KeywordFeatureAssertions.php:254
00:02:06.795 /workspace/src/extensions/CirrusSearch/tests/phpunit/unit/Query/SimpleKeywordFeatureTestTrait.php:97
00:02:06.795 /workspace/src/extensions/CirrusSearch/tests/phpunit/unit/Query/InTitleFeatureTest.php:123
00:02:06.795 
00:02:06.795 13) CirrusSearch\Query\InTitleFeatureTest::testRegex with data set "supports negation simple case insensitive regex" ('-intitle:/bar/i', '', true, 'bar', true)
00:02:06.795 Using null as an array offset is deprecated, use an empty string instead
00:02:06.795 
00:02:06.795 /workspace/src/extensions/CirrusSearch/includes/Extra/Query/SourceRegex.php:140
00:02:06.795 /workspace/src/extensions/CirrusSearch/includes/Query/BaseRegexFeature.php:304
00:02:06.795 /workspace/src/extensions/CirrusSearch/includes/Query/BaseRegexFeature.php:246
00:02:06.795 /workspace/src/extensions/CirrusSearch/includes/Query/BaseRegexFeature.php:179
00:02:06.795 /workspace/src/extensions/CirrusSearch/includes/Query/SimpleKeywordFeature.php:286
00:02:06.795 /workspace/src/extensions/CirrusSearch/includes/Query/SimpleKeywordFeature.php:306
00:02:06.796 /workspace/src/extensions/CirrusSearch/tests/phpunit/unit/Query/KeywordFeatureAssertions.php:254
00:02:06.796 /workspace/src/extensions/CirrusSearch/tests/phpunit/unit/Query/SimpleKeywordFeatureTestTrait.php:97
00:02:06.796 /workspace/src/extensions/CirrusSearch/tests/phpunit/unit/Query/InTitleFeatureTest.php:123
00:02:06.796 
00:02:06.796 14) CirrusSearch\Query\InTitleFeatureTest::testRegex with data set "do not unescape the regex" ('intitle:/foo\/bar/', '', false, 'foo\/bar', false)
00:02:06.796 Using null as an array offset is deprecated, use an empty string instead
00:02:06.796 
00:02:06.796 /workspace/src/extensions/CirrusSearch/includes/Extra/Query/SourceRegex.php:140
00:02:06.796 /workspace/src/extensions/CirrusSearch/includes/Query/BaseRegexFeature.php:304
00:02:06.796 /workspace/src/extensions/CirrusSearch/includes/Query/BaseRegexFeature.php:246
00:02:06.796 /workspace/src/extensions/CirrusSearch/includes/Query/BaseRegexFeature.php:179
00:02:06.796 /workspace/src/extensions/CirrusSearch/includes/Query/SimpleKeywordFeature.php:286
00:02:06.796 /workspace/src/extensions/CirrusSearch/includes/Query/SimpleKeywordFeature.php:306
00:02:06.796 /workspace/src/extensions/CirrusSearch/tests/phpunit/unit/Query/KeywordFeatureAssertions.php:254
00:02:06.796 /workspace/src/extensions/CirrusSearch/tests/phpunit/unit/Query/SimpleKeywordFeatureTestTrait.php:97
00:02:06.796 /workspace/src/extensions/CirrusSearch/tests/phpunit/unit/Query/InTitleFeatureTest.php:123
00:02:06.796 
00:02:06.796 15) CirrusSearch\Query\InTitleFeatureTest::testRegex with data set "do not unescape the regex and keep insensitive flag" ('intitle:/foo\/bar/i', '', false, 'foo\/bar', true)
00:02:06.796 Using null as an array offset is deprecated, use an empty string instead
00:02:06.796 
00:02:06.796 /workspace/src/extensions/CirrusSearch/includes/Extra/Query/SourceRegex.php:140
00:02:06.796 /workspace/src/extensions/CirrusSearch/includes/Query/BaseRegexFeature.php:304
00:02:06.796 /workspace/src/extensions/CirrusSearch/includes/Query/BaseRegexFeature.php:246
00:02:06.797 /workspace/src/extensions/CirrusSearch/includes/Query/BaseRegexFeature.php:179
00:02:06.797 /workspace/src/extensions/CirrusSearch/includes/Query/SimpleKeywordFeature.php:286
00:02:06.797 /workspace/src/extensions/CirrusSearch/includes/Query/SimpleKeywordFeature.php:306
00:02:06.797 /workspace/src/extensions/CirrusSearch/tests/phpunit/unit/Query/KeywordFeatureAssertions.php:254
00:02:06.797 /workspace/src/extensions/CirrusSearch/tests/phpunit/unit/Query/SimpleKeywordFeatureTestTrait.php:97
00:02:06.797 /workspace/src/extensions/CirrusSearch/tests/phpunit/unit/Query/InTitleFeatureTest.php:123
00:02:06.797 
00:02:06.797 16) CirrusSearch\Query\InTitleFeatureTest::testRegex with data set "if the last character of the pattern searched is "/"" ('intitle:/\/Documentation\//', '', false, '\/Documentation\/', false)
00:02:06.797 Using null as an array offset is deprecated, use an empty string instead
00:02:06.797 
00:02:06.797 /workspace/src/extensions/CirrusSearch/includes/Extra/Query/SourceRegex.php:140
00:02:06.797 /workspace/src/extensions/CirrusSearch/includes/Query/BaseRegexFeature.php:304
00:02:06.797 /workspace/src/extensions/CirrusSearch/includes/Query/BaseRegexFeature.php:246
00:02:06.797 /workspace/src/extensions/CirrusSearch/includes/Query/BaseRegexFeature.php:179
00:02:06.797 /workspace/src/extensions/CirrusSearch/includes/Query/SimpleKeywordFeature.php:286
00:02:06.797 /workspace/src/extensions/CirrusSearch/includes/Query/SimpleKeywordFeature.php:306
00:02:06.797 /workspace/src/extensions/CirrusSearch/tests/phpunit/unit/Query/KeywordFeatureAssertions.php:254
00:02:06.797 /workspace/src/extensions/CirrusSearch/tests/phpunit/unit/Query/SimpleKeywordFeatureTestTrait.php:97
00:02:06.797 /workspace/src/extensions/CirrusSearch/tests/phpunit/unit/Query/InTitleFeatureTest.php:123

Event Timeline

neriah changed the task status from Open to In Progress.Mar 5 2026, 3:02 PM
neriah claimed this task.
neriah subscribed.

Change #1248540 had a related patch set uploaded (by Neriah; author: Neriah):

[mediawiki/extensions/CirrusSearch@master] CirrusSearch: Fix null array offsets for PHP 8.5 compatibility

https://gerrit.wikimedia.org/r/1248540

Change #1248845 had a related patch set uploaded (by Neriah; author: Neriah):

[mediawiki/extensions/CirrusSearch@REL1_43] CirrusSearch: Fix null array offsets for PHP 8.5 compatibility

https://gerrit.wikimedia.org/r/1248845

Change #1248846 had a related patch set uploaded (by Neriah; author: Neriah):

[mediawiki/extensions/CirrusSearch@REL1_44] CirrusSearch: Fix null array offsets for PHP 8.5 compatibility

https://gerrit.wikimedia.org/r/1248846

Change #1248847 had a related patch set uploaded (by Neriah; author: Neriah):

[mediawiki/extensions/CirrusSearch@REL1_45] CirrusSearch: Fix null array offsets for PHP 8.5 compatibility

https://gerrit.wikimedia.org/r/1248847

Change #1248540 merged by jenkins-bot:

[mediawiki/extensions/CirrusSearch@master] CirrusSearch: Fix null array offsets for PHP 8.5 compatibility

https://gerrit.wikimedia.org/r/1248540

Change #1248846 merged by jenkins-bot:

[mediawiki/extensions/CirrusSearch@REL1_44] CirrusSearch: Fix null array offsets for PHP 8.5 compatibility

https://gerrit.wikimedia.org/r/1248846

Change #1248845 merged by jenkins-bot:

[mediawiki/extensions/CirrusSearch@REL1_43] CirrusSearch: Fix null array offsets for PHP 8.5 compatibility

https://gerrit.wikimedia.org/r/1248845