Page MenuHomePhabricator
Create Task
Maniphest T419071

PHP 8.5 CI failure in ORES: "Using null as an array offset is deprecated, use an empty string instead"
Closed, ResolvedPublic
Actions

Description

00:03:57.443 There were 6 errors:
00:03:57.443 
00:03:57.443 1) ORES\Tests\Hooks\ChangesListHooksHandlerTest::testGetScoreRecentChangesList
00:03:57.443 Using null as an array offset is deprecated, use an empty string instead
00:03:57.444 
00:03:57.444 /workspace/src/extensions/ORES/includes/Hooks/Helpers.php:180
00:03:57.444 /workspace/src/extensions/ORES/includes/Hooks/ChangesListHooksHandler.php:651
00:03:57.444 /workspace/src/extensions/ORES/tests/phpunit/includes/Hooks/ChangesListHooksHandlerTest.php:93
00:03:57.444 
00:03:57.444 2) ORES\Tests\Hooks\ChangesListHooksHandlerTest::testOnEnhancedChangesListModifyLineDataDamaging
00:03:57.444 Using null as an array offset is deprecated, use an empty string instead
00:03:57.444 
00:03:57.444 /workspace/src/extensions/ORES/includes/Hooks/Helpers.php:180
00:03:57.444 /workspace/src/extensions/ORES/includes/Hooks/ChangesListHooksHandler.php:651
00:03:57.444 /workspace/src/extensions/ORES/includes/Hooks/ChangesListHooksHandler.php:577
00:03:57.444 /workspace/src/extensions/ORES/includes/Hooks/ChangesListHooksHandler.php:539
00:03:57.444 /workspace/src/extensions/ORES/tests/phpunit/includes/Hooks/ChangesListHooksHandlerTest.php:228
00:03:57.444 
00:03:57.444 3) ORES\Tests\Hooks\ChangesListHooksHandlerTest::testOnEnhancedChangesListModifyLineDataNonDamaging
00:03:57.444 Using null as an array offset is deprecated, use an empty string instead
00:03:57.444 
00:03:57.444 /workspace/src/extensions/ORES/includes/Hooks/Helpers.php:180
00:03:57.444 /workspace/src/extensions/ORES/includes/Hooks/ChangesListHooksHandler.php:651
00:03:57.444 /workspace/src/extensions/ORES/includes/Hooks/ChangesListHooksHandler.php:577
00:03:57.444 /workspace/src/extensions/ORES/includes/Hooks/ChangesListHooksHandler.php:539
00:03:57.444 /workspace/src/extensions/ORES/tests/phpunit/includes/Hooks/ChangesListHooksHandlerTest.php:266
00:03:57.444 
00:03:57.444 4) ORES\Tests\Hooks\ChangesListHooksHandlerTest::testOnOldChangesListModifyLineDataDamaging
00:03:57.444 Using null as an array offset is deprecated, use an empty string instead
00:03:57.444 
00:03:57.444 /workspace/src/extensions/ORES/includes/Hooks/Helpers.php:180
00:03:57.444 /workspace/src/extensions/ORES/includes/Hooks/ChangesListHooksHandler.php:651
00:03:57.444 /workspace/src/extensions/ORES/includes/Hooks/ChangesListHooksHandler.php:607
00:03:57.444 /workspace/src/extensions/ORES/tests/phpunit/includes/Hooks/ChangesListHooksHandlerTest.php:307
00:03:57.444 
00:03:57.444 5) ORES\Tests\Hooks\ChangesListHooksHandlerTest::testOnOldChangesListModifyLineDataNonDamaging
00:03:57.444 Using null as an array offset is deprecated, use an empty string instead
00:03:57.444 
00:03:57.444 /workspace/src/extensions/ORES/includes/Hooks/Helpers.php:180
00:03:57.444 /workspace/src/extensions/ORES/includes/Hooks/ChangesListHooksHandler.php:651
00:03:57.444 /workspace/src/extensions/ORES/includes/Hooks/ChangesListHooksHandler.php:607
00:03:57.444 /workspace/src/extensions/ORES/tests/phpunit/includes/Hooks/ChangesListHooksHandlerTest.php:340
00:03:57.444 
00:03:57.444 6) ORES\Tests\Hooks\ChangesListHooksHandlerTest::testOnEnhancedChangesListModifyBlockLineData
00:03:57.444 Using null as an array offset is deprecated, use an empty string instead
00:03:57.444 
00:03:57.444 /workspace/src/extensions/ORES/includes/Hooks/Helpers.php:180
00:03:57.444 /workspace/src/extensions/ORES/includes/Hooks/ChangesListHooksHandler.php:651
00:03:57.444 /workspace/src/extensions/ORES/includes/Hooks/ChangesListHooksHandler.php:577
00:03:57.444 /workspace/src/extensions/ORES/includes/Hooks/ChangesListHooksHandler.php:559
00:03:57.444 /workspace/src/extensions/ORES/tests/phpunit/includes/Hooks/ChangesListHooksHandlerTest.php:462

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
ORES: Fix null array offset for PHP 8.5 compatibilityNeriahmediawiki/extensions/ORESREL1_45+1 -1
ORES: Fix null array offset for PHP 8.5 compatibilityNeriahmediawiki/extensions/ORESREL1_43+1 -1
ORES: Fix null array offset for PHP 8.5 compatibilityNeriahmediawiki/extensions/ORESREL1_44+1 -1
ORES: Fix null array offset for PHP 8.5 compatibilityNeriahmediawiki/extensions/ORESmaster+1 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdforrester-WMF created this task.Mar 4 2026, 9:24 PM
Restricted Application added a project: Machine-Learning-Team. · View Herald TranscriptMar 4 2026, 9:24 PM
Jdforrester-WMF moved this task from Backlog to Wikimedia production on the PHP 8.5 support board.Mar 4 2026, 10:39 PM
Jdforrester-WMF mentioned this in T419070: Ensure that all Wikimedia-deployed code passes PHP 8.5 CI.Mar 4 2026, 10:53 PM
Jdforrester-WMF added a parent task: T419070: Ensure that all Wikimedia-deployed code passes PHP 8.5 CI.Mar 4 2026, 10:56 PM
Jdforrester-WMF mentioned this in T411814: Make PHP 8.5 voting on development (master) branch of MW ecosystem (core, vendor, extensions, skins, libraries) in CI.
neriah changed the task status from Open to In Progress.Mar 8 2026, 8:33 PM
neriah claimed this task.
neriah triaged this task as Medium priority.
neriah subscribed.
gerritbot added a comment.Mar 8 2026, 8:34 PM

Change #1249054 had a related patch set uploaded (by Neriah; author: Neriah):

[mediawiki/extensions/ORES@master] ORES: Fix null array offset for PHP 8.5 compatibility

https://gerrit.wikimedia.org/r/1249054

gerritbot added a project: Patch-For-Review.Mar 8 2026, 8:34 PM
gerritbot added a comment.Mar 9 2026, 1:05 PM

Change #1249283 had a related patch set uploaded (by Neriah; author: Neriah):

[mediawiki/extensions/ORES@REL1_43] ORES: Fix null array offset for PHP 8.5 compatibility

https://gerrit.wikimedia.org/r/1249283

gerritbot added a comment.Mar 9 2026, 1:06 PM

Change #1249284 had a related patch set uploaded (by Neriah; author: Neriah):

[mediawiki/extensions/ORES@REL1_44] ORES: Fix null array offset for PHP 8.5 compatibility

https://gerrit.wikimedia.org/r/1249284

gerritbot added a comment.Mar 9 2026, 1:07 PM

Change #1249285 had a related patch set uploaded (by Neriah; author: Neriah):

[mediawiki/extensions/ORES@REL1_45] ORES: Fix null array offset for PHP 8.5 compatibility

https://gerrit.wikimedia.org/r/1249285

gerritbot added a comment.Mar 9 2026, 1:11 PM

Change #1249054 merged by jenkins-bot:

[mediawiki/extensions/ORES@master] ORES: Fix null array offset for PHP 8.5 compatibility

https://gerrit.wikimedia.org/r/1249054

Jdforrester-WMF closed this task as Resolved.Mar 9 2026, 1:36 PM
gerritbot added a comment.Mar 9 2026, 1:36 PM

Change #1249284 merged by jenkins-bot:

[mediawiki/extensions/ORES@REL1_44] ORES: Fix null array offset for PHP 8.5 compatibility

https://gerrit.wikimedia.org/r/1249284

gerritbot added a comment.Mar 9 2026, 1:37 PM

Change #1249283 merged by jenkins-bot:

[mediawiki/extensions/ORES@REL1_43] ORES: Fix null array offset for PHP 8.5 compatibility

https://gerrit.wikimedia.org/r/1249283

gerritbot added a comment.Mar 9 2026, 1:38 PM

Change #1249285 merged by jenkins-bot:

[mediawiki/extensions/ORES@REL1_45] ORES: Fix null array offset for PHP 8.5 compatibility

https://gerrit.wikimedia.org/r/1249285

ReleaseTaggerBot added a project: MW-1.46-notes (1.46.0-wmf.19; 2026-03-10).Mar 9 2026, 2:00 PM
Maintenance_bot removed a project: Patch-For-Review.Mar 9 2026, 2:32 PM
achou moved this task from Unsorted to Watching on the Machine-Learning-Team board.Mar 11 2026, 11:23 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits