Page MenuHomePhabricator

PHP 8.5 CI failure in SecurePoll: "Using null as an array offset is deprecated, use an empty string instead"
Closed, ResolvedPublic

Description

00:03:45.552 There were 4 errors:
00:03:45.552 
00:03:45.552 1) MediaWiki\Extension\SecurePoll\Test\Integration\STVBallotTest::testGetQuestionForm with data set "All valid inputs" (array(2, 4, 1, 3), 'Q00000065-C00000002-R00000000...0003--')
00:03:45.553 Using null as an array offset is deprecated, use an empty string instead
00:03:45.553 
00:03:45.553 /workspace/src/extensions/SecurePoll/includes/Ballots/STVBallot.php:113
00:03:45.553 /workspace/src/extensions/SecurePoll/tests/phpunit/integration/STVBallotTest.php:182
00:03:45.553 
00:03:45.553 2) MediaWiki\Extension\SecurePoll\Test\Integration\STVBallotTest::testGetQuestionForm with data set "No inputs" (array(), array(array('securepoll-stv-invalid-rank-empty')))
00:03:45.553 Using null as an array offset is deprecated, use an empty string instead
00:03:45.553 
00:03:45.553 /workspace/src/extensions/SecurePoll/includes/Ballots/STVBallot.php:113
00:03:45.553 /workspace/src/extensions/SecurePoll/tests/phpunit/integration/STVBallotTest.php:182
00:03:45.553 
00:03:45.553 3) MediaWiki\Extension\SecurePoll\Test\Integration\STVBallotTest::testGetQuestionForm with data set "Not sequentially ranked" (array(1, 3, 0, 2), array(array('securepoll-stv-invalid-input-empty'), array('securepoll-stv-invalid-rank-order', 'Preference 3')))
00:03:45.553 Using null as an array offset is deprecated, use an empty string instead
00:03:45.553 
00:03:45.553 /workspace/src/extensions/SecurePoll/includes/Ballots/STVBallot.php:113
00:03:45.554 /workspace/src/extensions/SecurePoll/tests/phpunit/integration/STVBallotTest.php:182
00:03:45.554 
00:03:45.554 4) MediaWiki\Extension\SecurePoll\Test\Integration\STVBallotTest::testGetQuestionForm with data set "Duplicate ranks" (array(1, 1, 1), array(array('securepoll-stv-invalid-input-duplicate'), array('securepoll-stv-invalid-input-duplicate'), array('securepoll-stv-invalid-rank-duplicate', 'Preference 2, Preference 3')))
00:03:45.554 Using null as an array offset is deprecated, use an empty string instead
00:03:45.554 
00:03:45.554 /workspace/src/extensions/SecurePoll/includes/Ballots/STVBallot.php:113
00:03:45.554 /workspace/src/extensions/SecurePoll/tests/phpunit/integration/STVBallotTest.php:182

Event Timeline

neriah changed the task status from Open to In Progress.Mar 5 2026, 2:40 PM
neriah claimed this task.
neriah subscribed.

Change #1248497 had a related patch set uploaded (by Neriah; author: Neriah):

[mediawiki/extensions/SecurePoll@master] STVBallot: Fix null array offset in getQuestionForm

https://gerrit.wikimedia.org/r/1248497

neriah triaged this task as Medium priority.Mar 8 2026, 6:13 PM

Change #1248497 had a related patch set uploaded (by Jforrester; author: Neriah):

[mediawiki/extensions/SecurePoll@master] STVBallotTest: Fix null array offset in getQuestionForm

https://gerrit.wikimedia.org/r/1248497

Change #1248497 merged by jenkins-bot:

[mediawiki/extensions/SecurePoll@master] STVBallotTest: Fix null array offset in getQuestionForm

https://gerrit.wikimedia.org/r/1248497

Change #1269504 had a related patch set uploaded (by Jforrester; author: Neriah):

[mediawiki/extensions/SecurePoll@REL1_45] STVBallotTest: Fix null array offset in getQuestionForm

https://gerrit.wikimedia.org/r/1269504

Change #1269505 had a related patch set uploaded (by Jforrester; author: Neriah):

[mediawiki/extensions/SecurePoll@REL1_44] STVBallotTest: Fix null array offset in getQuestionForm

https://gerrit.wikimedia.org/r/1269505

Change #1269506 had a related patch set uploaded (by Jforrester; author: Neriah):

[mediawiki/extensions/SecurePoll@REL1_43] STVBallotTest: Fix null array offset in getQuestionForm

https://gerrit.wikimedia.org/r/1269506

Change #1269506 merged by jenkins-bot:

[mediawiki/extensions/SecurePoll@REL1_43] STVBallotTest: Fix null array offset in getQuestionForm

https://gerrit.wikimedia.org/r/1269506

Change #1269504 merged by jenkins-bot:

[mediawiki/extensions/SecurePoll@REL1_45] STVBallotTest: Fix null array offset in getQuestionForm

https://gerrit.wikimedia.org/r/1269504

Change #1269505 merged by jenkins-bot:

[mediawiki/extensions/SecurePoll@REL1_44] STVBallotTest: Fix null array offset in getQuestionForm

https://gerrit.wikimedia.org/r/1269505