Maniphest T419083

EditCheck broken in Safari, edits not saved: quotes.values().some is not a function
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Assigned To

Authored By

	Raine
	Mar 4 2026, 10:07 PM

Project Tags

Referenced Files

	F72558615: new console.png
	Mar 4 2026, 10:07 PM

Subscribers

Description

Steps to replicate the issue (include links if applicable):

Edit a main namespace page on enwiki using Safari
Click "Publish changes"

What happens?:

Nothing - the button animates clicking, but nothing happens.

What should have happened instead?:

The button should have worked to publish the edit.

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Reported on:

macOS Sequía 15.0 and Safari 18.0
macOS Sonoma 14.0 and Safari 17.0

(I am reporting this on behalf of a report received on IRC, I don't experience it myself.)

Details

Related Changes in Gerrit:

	Subject	Author	Repo	Branch	Lines +/-
	Edit check: update for Safari < 18.4 compatibility	Medelius	mediawiki/extensions/VisualEditor	master	+1 -1

Customize query in gerrit

Related Objects

Duplicates Merged Here: T419720: TypeError: quotes.values().some is not a function.

Event Timeline

Raine created this task.Mar 4 2026, 10:07 PM

Restricted Application changed the subtype of this task from "Bug Report" to "Production Error". · View Herald TranscriptMar 4 2026, 10:07 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Raine renamed this task from EditCheck broken in Safari: quotes.values().some is not a function to EditCheck broken in Safari, edits not saved: quotes.values().some is not a function.Mar 4 2026, 10:22 PM

Raine updated the task description. (Show Details)

This is on https://en.wikipedia.org/wiki/Fuel_shortages_in_Venezuela. The user reports that they are able to publish changes to other pages like their sandbox, outline and bibliography for class, but not on that page.

Ragesoss subscribed.Mar 5 2026, 4:43 PM

Change #1248624 had a related patch set uploaded (by Medelius; author: Medelius):

[mediawiki/extensions/VisualEditor@master] Edit check: update for Safari < 18.4 compatibility

https://gerrit.wikimedia.org/r/1248624

gerritbot added a project: Patch-For-Review.Mar 5 2026, 9:46 PM

ppelberg added a project: Editing-team (Editing-2Mar-17Mar-2026).Mar 5 2026, 10:38 PM

ppelberg moved this task from Decisions to be made to Code Review on the Editing-team (Editing-2Mar-17Mar-2026) board.

ppelberg subscribed.

Change #1248624 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Edit check: update for Safari < 18.4 compatibility

https://gerrit.wikimedia.org/r/1248624

Maintenance_bot removed a project: Patch-For-Review.Mar 5 2026, 11:30 PM

ReleaseTaggerBot added a project: MW-1.46-notes (1.46.0-wmf.19; 2026-03-10).Mar 6 2026, 12:00 AM

medelius moved this task from Code Review to QA on the Editing-team (Editing-2Mar-17Mar-2026) board.Mar 6 2026, 2:12 AM

Code was using Iterator#some (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Iterator/some). Unfortunately we can't lint for that as the more common Array#some is allowed.

Can't see any other instances in MW codesearch:
https://codesearch.wmcloud.org/search/?q=%5C.values%5C%28%5C%29%5C.some%5C%28&files=&excludeFiles=&repos=

@Raine: we think this is fixed. Although, if/when you notice this not to be true, can you please boldly re-open this?

DLynch merged a task: T419720: TypeError: quotes.values().some is not a function..Mar 11 2026, 3:20 PM

DLynch added a subscriber: Jdlrobson-WMF.

ppelberg added a project: OKR-Work.Mar 19 2026, 7:01 PM

EditCheck broken in Safari, edits not saved: quotes.values().some is not a functionClosed, ResolvedPublicPRODUCTION ERRORActions

Description

Details

Related Objects

Event Timeline

EditCheck broken in Safari, edits not saved: quotes.values().some is not a function
Closed, ResolvedPublicPRODUCTION ERROR
Actions