Page MenuHomePhabricator

PHP 8.5 CI failure in ImageSuggestions: "Using null as an array offset is deprecated, use an empty string instead"
Closed, ResolvedPublic

Description

00:01:48.111 17) MediaWiki\Extension\ImageSuggestions\Tests\NotifierTest::testNotifications
00:01:48.111 Using null as an array offset is deprecated, use an empty string instead
00:01:48.111 
00:01:48.111 /workspace/src/extensions/ImageSuggestions/includes/Notifier.php:243
00:01:48.111 /workspace/src/extensions/ImageSuggestions/includes/Notifier.php:240
00:01:48.111 /workspace/src/extensions/ImageSuggestions/includes/Notifier.php:129
00:01:48.112 /workspace/src/extensions/ImageSuggestions/tests/phpunit/unit/NotifierTest.php:557
00:01:48.112 
00:01:48.112 18) MediaWiki\Extension\ImageSuggestions\Tests\NotifierTest::testSectionNotifications
00:01:48.112 Using null as an array offset is deprecated, use an empty string instead
00:01:48.112 
00:01:48.112 /workspace/src/extensions/ImageSuggestions/includes/Notifier.php:243
00:01:48.112 /workspace/src/extensions/ImageSuggestions/includes/Notifier.php:240
00:01:48.112 /workspace/src/extensions/ImageSuggestions/includes/Notifier.php:129
00:01:48.112 /workspace/src/extensions/ImageSuggestions/tests/phpunit/unit/NotifierTest.php:643
00:01:48.112 
00:01:48.112 19) MediaWiki\Extension\ImageSuggestions\Tests\NotifierTest::testExcludeInstanceOf
00:01:48.112 Using null as an array offset is deprecated, use an empty string instead
00:01:48.112 
00:01:48.113 /workspace/src/extensions/ImageSuggestions/includes/Notifier.php:243
00:01:48.113 /workspace/src/extensions/ImageSuggestions/includes/Notifier.php:240
00:01:48.113 /workspace/src/extensions/ImageSuggestions/includes/Notifier.php:129
00:01:48.113 /workspace/src/extensions/ImageSuggestions/tests/phpunit/unit/NotifierTest.php:689

(Other failures are from CirrusSearch, tracked in its own task.)

Event Timeline

neriah changed the task status from Open to In Progress.Mar 8 2026, 6:10 PM
neriah claimed this task.
neriah triaged this task as Medium priority.
neriah subscribed.

Change #1249051 had a related patch set uploaded (by Neriah; author: Neriah):

[mediawiki/extensions/ImageSuggestions@master] ImageSuggestions: Fix null array offset for PHP 8.5 compatibility

https://gerrit.wikimedia.org/r/1249051

Change #1249280 had a related patch set uploaded (by Neriah; author: Neriah):

[mediawiki/extensions/ImageSuggestions@REL1_43] ImageSuggestions: Fix null array offset for PHP 8.5 compatibility

https://gerrit.wikimedia.org/r/1249280

Change #1249281 had a related patch set uploaded (by Neriah; author: Neriah):

[mediawiki/extensions/ImageSuggestions@REL1_44] ImageSuggestions: Fix null array offset for PHP 8.5 compatibility

https://gerrit.wikimedia.org/r/1249281

Change #1249282 had a related patch set uploaded (by Neriah; author: Neriah):

[mediawiki/extensions/ImageSuggestions@REL1_45] ImageSuggestions: Fix null array offset for PHP 8.5 compatibility

https://gerrit.wikimedia.org/r/1249282

Change #1249051 merged by jenkins-bot:

[mediawiki/extensions/ImageSuggestions@master] ImageSuggestions: Fix null array offset for PHP 8.5 compatibility

https://gerrit.wikimedia.org/r/1249051

Change #1249281 merged by jenkins-bot:

[mediawiki/extensions/ImageSuggestions@REL1_44] ImageSuggestions: Fix null array offset for PHP 8.5 compatibility

https://gerrit.wikimedia.org/r/1249281

Change #1249282 merged by jenkins-bot:

[mediawiki/extensions/ImageSuggestions@REL1_45] ImageSuggestions: Fix null array offset for PHP 8.5 compatibility

https://gerrit.wikimedia.org/r/1249282

Change #1249280 merged by jenkins-bot:

[mediawiki/extensions/ImageSuggestions@REL1_43] ImageSuggestions: Fix null array offset for PHP 8.5 compatibility

https://gerrit.wikimedia.org/r/1249280