Maniphest T419087

PHP 8.5 CI failure in GrowthExperiments: "Using null as an array offset is deprecated, use an empty string instead"
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Jdforrester-WMF
	Mar 4 2026, 10:31 PM

Project Tags

Referenced Files

None

Subscribers

Description

00:02:06.248 17) GrowthExperiments\Tests\Unit\SuggestedEditsTest::testNoTopicFiltersWhenTopicMatchingDisabled
00:02:06.248 Using null as an array offset is deprecated, use an empty string instead
00:02:06.248 
00:02:06.248 /workspace/src/extensions/GrowthExperiments/includes/NewcomerTasks/ProtectionFilter.php:48
00:02:06.248 /workspace/src/extensions/GrowthExperiments/includes/HomepageModules/SuggestedEdits.php:473
00:02:06.248 /workspace/src/extensions/GrowthExperiments/includes/HomepageModules/SuggestedEdits.php:888
00:02:06.248 /workspace/src/extensions/GrowthExperiments/includes/HomepageModules/BaseModule.php:187
00:02:06.248 /workspace/src/extensions/GrowthExperiments/includes/DashboardModule/DashboardModule.php:181
00:02:06.248 /workspace/src/extensions/GrowthExperiments/tests/phpunit/unit/HomepageModules/SuggestedEditsTest.php:63

(Other failures are from CirrusSearch, tracked in its own task.)

Details

Related Changes in Gerrit:

Subject	Author	Repo	Branch	Lines +/-
ProtectionFilter: Don't trigger an error on PHP 8.5 when article ID is null	Reedy	mediawiki/extensions/GrowthExperiments	REL1_44	+4 -2
ProtectionFilter: Don't trigger an error on PHP 8.5 when article ID is null	Reedy	mediawiki/extensions/GrowthExperiments	REL1_43	+4 -2
ProtectionFilter: Don't trigger an error on PHP 8.5 when article ID is null	Jforrester	mediawiki/extensions/GrowthExperiments	REL1_45	+4 -2
ProtectionFilter: Don't trigger an error on PHP 8.5 when article ID is null	Jforrester	mediawiki/extensions/GrowthExperiments	master	+4 -2

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
In Progress	None	T413223 Migrate Wikimedia production from PHP 8.3 to PHP 8.5
Resolved	Jdforrester-WMF	T411814 Make PHP 8.5 voting on development (master) branch of MW ecosystem (core, vendor, extensions, skins, libraries) in CI
Resolved	Jdforrester-WMF	T419070 Ensure that all Wikimedia-deployed code passes PHP 8.5 CI
Open	None	T410514 Using null as array offset or as the key parameter for array_key_exists() is deprecated in PHP 8.5
Resolved	Jdforrester-WMF	T419087 PHP 8.5 CI failure in GrowthExperiments: "Using null as an array offset is deprecated, use an empty string instead"

Event Timeline

Jdforrester-WMF created this task.Mar 4 2026, 10:31 PM

Restricted Application added a project: Growth-Team. · View Herald TranscriptMar 4 2026, 10:31 PM

Jdforrester-WMF moved this task from Backlog to Wikimedia production on the PHP 8.5 support board.Mar 4 2026, 10:39 PM

Jdforrester-WMF mentioned this in T419070: Ensure that all Wikimedia-deployed code passes PHP 8.5 CI.Mar 4 2026, 10:53 PM

Jdforrester-WMF added a parent task: T419070: Ensure that all Wikimedia-deployed code passes PHP 8.5 CI.Mar 4 2026, 10:56 PM

Jdforrester-WMF mentioned this in T411814: Make PHP 8.5 voting on development (master) branch of MW ecosystem (core, vendor, extensions, skins, libraries) in CI.

Change #1250105 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/GrowthExperiments@master] ProtectionFilter: Don't trigger an error on PHP 8.5 when article ID is null

https://gerrit.wikimedia.org/r/1250105

gerritbot added a project: Patch-For-Review.Mar 10 2026, 10:22 PM

Jdforrester-WMF renamed this task from PHP 8.5 CI failure in GrowthSuggestions: "Using null as an array offset is deprecated, use an empty string instead" to PHP 8.5 CI failure in GrowthExperiments: "Using null as an array offset is deprecated, use an empty string instead".Mar 10 2026, 10:22 PM

Jdforrester-WMF changed the task status from Open to In Progress.

Jdforrester-WMF claimed this task.

Change #1250105 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] ProtectionFilter: Don't trigger an error on PHP 8.5 when article ID is null

https://gerrit.wikimedia.org/r/1250105

ReleaseTaggerBot added a project: MW-1.46-notes (1.46.0-wmf.20; 2026-03-17).Mar 11 2026, 3:01 PM

Change #1250612 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/GrowthExperiments@REL1_45] ProtectionFilter: Don't trigger an error on PHP 8.5 when article ID is null

https://gerrit.wikimedia.org/r/1250612

Change #1250612 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@REL1_45] ProtectionFilter: Don't trigger an error on PHP 8.5 when article ID is null

https://gerrit.wikimedia.org/r/1250612

Maintenance_bot removed a project: Patch-For-Review.Mar 11 2026, 3:30 PM

Jdforrester-WMF closed this task as Resolved.Mar 11 2026, 4:26 PM

Change #1284859 had a related patch set uploaded (by Reedy; author: Jforrester):

[mediawiki/extensions/GrowthExperiments@REL1_44] ProtectionFilter: Don't trigger an error on PHP 8.5 when article ID is null

https://gerrit.wikimedia.org/r/1284859

Change #1284860 had a related patch set uploaded (by Reedy; author: Jforrester):

[mediawiki/extensions/GrowthExperiments@REL1_43] ProtectionFilter: Don't trigger an error on PHP 8.5 when article ID is null

https://gerrit.wikimedia.org/r/1284860

Change #1284860 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@REL1_43] ProtectionFilter: Don't trigger an error on PHP 8.5 when article ID is null

https://gerrit.wikimedia.org/r/1284860

Change #1284859 merged by jenkins-bot: