Page MenuHomePhabricator
Create Task
Maniphest T419090

PHP 8.5 CI failure in Parsoid: "Using null as an array offset is deprecated, use an empty string instead"
Closed, ResolvedPublic
Actions

Description

00:06:37.831 There were 3 errors:
00:06:37.831 
00:06:37.832 1) ParserIntegrationTest::testParse with data set "headings.txt: Section headings with TOC, language conversion rules, and displaytitle
00:06:37.832 (T306862, T331316, T26072)" ('wt2html')
00:06:37.832 Using null as an array offset is deprecated, use an empty string instead
00:06:37.832 
00:06:37.832 /workspace/src/services/parsoid/src/Wt2Html/DOM/Processors/WrapSectionsState.php:319
00:06:37.832 /workspace/src/services/parsoid/src/Wt2Html/DOM/Processors/WrapSectionsState.php:395
00:06:37.832 /workspace/src/services/parsoid/src/Wt2Html/DOM/Processors/WrapSectionsState.php:913
00:06:37.832 /workspace/src/services/parsoid/src/Wt2Html/DOM/Processors/WrapSections.php:38
00:06:37.832 /workspace/src/services/parsoid/src/Wt2Html/DOMProcessorPipeline.php:131
00:06:37.832 /workspace/src/services/parsoid/src/Wt2Html/DOMProcessorPipeline.php:175
00:06:37.832 /workspace/src/services/parsoid/src/Wt2Html/DOMProcessorPipeline.php:188
00:06:37.832 /workspace/src/services/parsoid/src/Wt2Html/ParserPipeline.php:159
00:06:37.832 /workspace/src/services/parsoid/src/Wt2Html/ParserPipeline.php:181
00:06:37.832 /workspace/src/services/parsoid/src/Wt2Html/ParserPipelineFactory.php:621
00:06:37.832 /workspace/src/services/parsoid/src/Wikitext/ContentModelHandler.php:181
00:06:37.832 /workspace/src/services/parsoid/src/Parsoid.php:204
00:06:37.832 /workspace/src/services/parsoid/src/Parsoid.php:270
00:06:37.832 /workspace/src/tests/Common/Parser/ParserTestRunner.php:1927
00:06:37.832 /workspace/src/tests/Common/Parser/ParserTestRunner.php:2419
00:06:37.832 /workspace/src/tests/Common/Parser/ParserTestRunner.php:1459
00:06:37.832 /workspace/src/tests/Common/Parser/ParserTestRunner.php:1487
00:06:37.832 /workspace/src/tests/phpunit/suites/ParserIntegrationTest.php:71
00:06:37.832 /workspace/src/tests/phpunit/suites/SuiteEventsTrait.php:67
00:06:37.832 /workspace/src/tests/phpunit/suites/SuiteEventsTrait.php:67
00:06:37.832 
00:06:37.832 2) ParserIntegrationTest::testParse with data set "extLinks.txt: Unicode text around autolinks" ('wt2html')
00:06:37.832 ord(): Providing a string that is not one byte long is deprecated. Use ord($str[0]) instead
00:06:37.832 
00:06:37.832 /workspace/src/services/parsoid/src/Utils/Utils.php:85
00:06:37.832 /workspace/src/services/parsoid/src/Wt2Html/Grammar.php:1265
00:06:37.832 /workspace/src/services/parsoid/src/Wt2Html/Grammar.php:15585
00:06:37.832 /workspace/src/services/parsoid/src/Wt2Html/Grammar.php:10104
00:06:37.832 /workspace/src/services/parsoid/src/Wt2Html/Grammar.php:5620
00:06:37.832 /workspace/src/services/parsoid/src/Wt2Html/Grammar.php:8111
00:06:37.832 /workspace/src/services/parsoid/src/Wt2Html/Grammar.php:4006
00:06:37.832 /workspace/src/services/parsoid/src/Wt2Html/Grammar.php:2493
00:06:37.832 /workspace/src/services/parsoid/src/Wt2Html/PegTokenizer.php:148
00:06:37.832 /workspace/src/services/parsoid/src/Wt2Html/ParserPipeline.php:156
00:06:37.832 /workspace/src/services/parsoid/src/Wt2Html/ParserPipeline.php:158
00:06:37.832 /workspace/src/services/parsoid/src/Wt2Html/ParserPipeline.php:158
00:06:37.832 /workspace/src/services/parsoid/src/Wt2Html/ParserPipeline.php:158
00:06:37.832 /workspace/src/services/parsoid/src/Wt2Html/ParserPipeline.php:158
00:06:37.832 /workspace/src/services/parsoid/src/Wt2Html/ParserPipeline.php:181
00:06:37.832 /workspace/src/services/parsoid/src/Wt2Html/ParserPipelineFactory.php:621
00:06:37.832 /workspace/src/services/parsoid/src/Wikitext/ContentModelHandler.php:181
00:06:37.832 /workspace/src/services/parsoid/src/Parsoid.php:204
00:06:37.832 /workspace/src/services/parsoid/src/Parsoid.php:270
00:06:37.832 /workspace/src/tests/Common/Parser/ParserTestRunner.php:1927
00:06:37.833 /workspace/src/tests/Common/Parser/ParserTestRunner.php:2419
00:06:37.833 /workspace/src/tests/Common/Parser/ParserTestRunner.php:1459
00:06:37.833 /workspace/src/tests/Common/Parser/ParserTestRunner.php:1487
00:06:37.833 /workspace/src/tests/phpunit/suites/ParserIntegrationTest.php:71
00:06:37.833 /workspace/src/tests/phpunit/suites/SuiteEventsTrait.php:67
00:06:37.833 /workspace/src/tests/phpunit/suites/SuiteEventsTrait.php:67
00:06:37.833 
00:06:37.833 3) ParserIntegrationTest::testParse with data set "extLinks.txt: Unicode text around autolinks" ('wt2wt')
00:06:37.833 ord(): Providing a string that is not one byte long is deprecated. Use ord($str[0]) instead
00:06:37.833 
00:06:37.833 /workspace/src/services/parsoid/src/Utils/Utils.php:85
00:06:37.833 /workspace/src/services/parsoid/src/Wt2Html/Grammar.php:1265
00:06:37.833 /workspace/src/services/parsoid/src/Wt2Html/Grammar.php:15585
00:06:37.833 /workspace/src/services/parsoid/src/Wt2Html/Grammar.php:10104
00:06:37.833 /workspace/src/services/parsoid/src/Wt2Html/Grammar.php:5620
00:06:37.833 /workspace/src/services/parsoid/src/Wt2Html/Grammar.php:8111
00:06:37.833 /workspace/src/services/parsoid/src/Wt2Html/Grammar.php:4006
00:06:37.833 /workspace/src/services/parsoid/src/Wt2Html/Grammar.php:2493
00:06:37.833 /workspace/src/services/parsoid/src/Wt2Html/PegTokenizer.php:148
00:06:37.833 /workspace/src/services/parsoid/src/Wt2Html/ParserPipeline.php:156
00:06:37.833 /workspace/src/services/parsoid/src/Wt2Html/ParserPipeline.php:158
00:06:37.833 /workspace/src/services/parsoid/src/Wt2Html/ParserPipeline.php:158
00:06:37.833 /workspace/src/services/parsoid/src/Wt2Html/ParserPipeline.php:158
00:06:37.833 /workspace/src/services/parsoid/src/Wt2Html/ParserPipeline.php:158
00:06:37.833 /workspace/src/services/parsoid/src/Wt2Html/ParserPipeline.php:181
00:06:37.833 /workspace/src/services/parsoid/src/Wt2Html/ParserPipelineFactory.php:621
00:06:37.833 /workspace/src/services/parsoid/src/Wikitext/ContentModelHandler.php:181
00:06:37.833 /workspace/src/services/parsoid/src/Parsoid.php:204
00:06:37.833 /workspace/src/services/parsoid/src/Parsoid.php:270
00:06:37.833 /workspace/src/tests/Common/Parser/ParserTestRunner.php:1927
00:06:37.833 /workspace/src/tests/Common/Parser/ParserTestRunner.php:1886
00:06:37.833 /workspace/src/tests/Common/Parser/ParserTestRunner.php:2053
00:06:37.833 /workspace/src/tests/Common/Parser/ParserTestRunner.php:2423
00:06:37.833 /workspace/src/tests/Common/Parser/ParserTestRunner.php:1459
00:06:37.833 /workspace/src/tests/Common/Parser/ParserTestRunner.php:1487
00:06:37.833 /workspace/src/tests/phpunit/suites/ParserIntegrationTest.php:71
00:06:37.834 /workspace/src/tests/phpunit/suites/SuiteEventsTrait.php:67
00:06:37.834 /workspace/src/tests/phpunit/suites/SuiteEventsTrait.php:67

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Account for mw:LanguageVariant in WrapSectionStateC. Scott Ananianmediawiki/services/parsoidREL1_45+21 -6
Account for mw:LanguageVariant in WrapSectionStateC. Scott Ananianmediawiki/services/parsoidREL1_43+21 -6
Account for mw:LanguageVariant in WrapSectionStateC. Scott Ananianmediawiki/services/parsoidREL1_44+21 -6
Bump wikimedia/parsoid to 0.23.0-a21OSlegermediawiki/vendormaster+492 -269
Account for mw:LanguageVariant in WrapSectionStateArlolramediawiki/services/parsoidmaster+21 -6
Fix ord() deprecation warning in Utils::lastUniChar()Zabemediawiki/services/parsoidREL1_44+1 -1
Fix ord() deprecation warning in Utils::lastUniChar()Zabemediawiki/services/parsoidREL1_45+1 -1
Fix ord() deprecation warning in Utils::lastUniChar()Zabemediawiki/services/parsoidREL1_43+1 -1
Fix ord() deprecation warning in Utils::lastUniChar()Zabemediawiki/services/parsoidmaster+1 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdforrester-WMF created this task.Mar 4 2026, 10:53 PM
Jdforrester-WMF mentioned this in T419070: Ensure that all Wikimedia-deployed code passes PHP 8.5 CI.
Jdforrester-WMF added a parent task: T419070: Ensure that all Wikimedia-deployed code passes PHP 8.5 CI.Mar 4 2026, 10:56 PM
Jdforrester-WMF mentioned this in T411814: Make PHP 8.5 voting on development (master) branch of MW ecosystem (core, vendor, extensions, skins, libraries) in CI.
gerritbot added a comment.Mar 4 2026, 11:04 PM

Change #1248129 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/services/parsoid@master] Fix ord() deprecation warning in Utils::lastUniChar()

https://gerrit.wikimedia.org/r/1248129

gerritbot added a project: Patch-For-Review.Mar 4 2026, 11:04 PM
Zabe subscribed.Mar 4 2026, 11:04 PM
gerritbot added a comment.Mar 4 2026, 11:37 PM

Change #1248129 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Fix ord() deprecation warning in Utils::lastUniChar()

https://gerrit.wikimedia.org/r/1248129

gerritbot added a comment.Mar 4 2026, 11:38 PM

Change #1248133 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/services/parsoid@REL1_45] Fix ord() deprecation warning in Utils::lastUniChar()

https://gerrit.wikimedia.org/r/1248133

gerritbot added a comment.Mar 4 2026, 11:38 PM

Change #1248134 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/services/parsoid@REL1_44] Fix ord() deprecation warning in Utils::lastUniChar()

https://gerrit.wikimedia.org/r/1248134

gerritbot added a comment.Mar 4 2026, 11:38 PM

Change #1248135 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/services/parsoid@REL1_43] Fix ord() deprecation warning in Utils::lastUniChar()

https://gerrit.wikimedia.org/r/1248135

gerritbot added a comment.Mar 5 2026, 12:00 AM

Change #1248135 merged by jenkins-bot:

[mediawiki/services/parsoid@REL1_43] Fix ord() deprecation warning in Utils::lastUniChar()

https://gerrit.wikimedia.org/r/1248135

gerritbot added a comment.Mar 5 2026, 12:01 AM

Change #1248133 merged by jenkins-bot:

[mediawiki/services/parsoid@REL1_45] Fix ord() deprecation warning in Utils::lastUniChar()

https://gerrit.wikimedia.org/r/1248133

Jdforrester-WMF added a comment.Mar 5 2026, 12:02 AM

Thanks! There's also the first failure, in src/Wt2Html/DOM/Processors/WrapSectionsState.php:319

gerritbot added a comment.Mar 5 2026, 12:07 AM

Change #1248134 merged by jenkins-bot:

[mediawiki/services/parsoid@REL1_44] Fix ord() deprecation warning in Utils::lastUniChar()

https://gerrit.wikimedia.org/r/1248134

Maintenance_bot removed a project: Patch-For-Review.Mar 5 2026, 12:30 AM
MSantos added projects: Essential-Work, Content-Platform-Team (Work In Progress).Mar 5 2026, 3:09 PM
MSantos moved this task from Needs Triage to Bugs & Crashers on the Parsoid board.
ABreault-WMF subscribed.EditedMar 5 2026, 5:46 PM
In T419090#11676103, @Jdforrester-WMF wrote:

Thanks! There's also the first failure, in src/Wt2Html/DOM/Processors/WrapSectionsState.php:319

Done in https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/1248142

Whoops, no

ABreault-WMF claimed this task.Mar 5 2026, 7:56 PM
gerritbot added a comment.Mar 5 2026, 9:38 PM

Change #1248622 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/services/parsoid@master] Account for mw:LanguageVariant in WrapSectionState

https://gerrit.wikimedia.org/r/1248622

gerritbot added a project: Patch-For-Review.Mar 5 2026, 9:38 PM
ABreault-WMF moved this task from Backlog to Code Review on the Content-Platform-Team (Work In Progress) board.Mar 6 2026, 1:24 AM
gerritbot added a comment.Mar 6 2026, 4:30 AM

Change #1248622 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Account for mw:LanguageVariant in WrapSectionState

https://gerrit.wikimedia.org/r/1248622

Maintenance_bot removed a project: Patch-For-Review.Mar 6 2026, 4:30 AM
Jdforrester-WMF added a comment.Mar 6 2026, 2:36 PM

Thank you! We could declare this Resolved as-is, but if you want Parsoid's older branches to support PHP 8.5 your patch will need to be back-ported, and it's a bit more significant than the first patch.

Jdforrester-WMF changed the task status from Open to In Progress.Mar 6 2026, 2:37 PM
cscott moved this task from Code Review to To Deploy on the Content-Platform-Team (Work In Progress) board.Mar 9 2026, 3:12 PM
gerritbot added a comment.Mar 9 2026, 4:48 PM

Change #1249353 had a related patch set uploaded (by OSleger; author: OSleger):

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.23.0-a21

https://gerrit.wikimedia.org/r/1249353

gerritbot added a project: Patch-For-Review.Mar 9 2026, 4:48 PM
Jdforrester-WMF closed this task as Resolved.Mar 9 2026, 5:58 PM
gerritbot added a comment.Mar 9 2026, 7:13 PM

Change #1249353 merged by jenkins-bot:

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.23.0-a21

https://gerrit.wikimedia.org/r/1249353

Maintenance_bot removed a project: Patch-For-Review.Mar 9 2026, 7:31 PM
gerritbot added a comment.Jun 4 2026, 5:37 AM

Change #1297494 had a related patch set uploaded (by C. Scott Ananian; author: Arlolra):

[mediawiki/services/parsoid@REL1_45] Account for mw:LanguageVariant in WrapSectionState

https://gerrit.wikimedia.org/r/1297494

gerritbot added a project: Patch-For-Review.Jun 4 2026, 5:37 AM

Change #1297495 had a related patch set uploaded (by C. Scott Ananian; author: Arlolra):

[mediawiki/services/parsoid@REL1_44] Account for mw:LanguageVariant in WrapSectionState

https://gerrit.wikimedia.org/r/1297495

gerritbot added a comment.Jun 4 2026, 5:38 AM

Change #1297511 had a related patch set uploaded (by C. Scott Ananian; author: Arlolra):

[mediawiki/services/parsoid@REL1_43] Account for mw:LanguageVariant in WrapSectionState

https://gerrit.wikimedia.org/r/1297511

gerritbot added a comment.Jun 4 2026, 5:56 AM

Change #1297495 merged by jenkins-bot:

[mediawiki/services/parsoid@REL1_44] Account for mw:LanguageVariant in WrapSectionState

https://gerrit.wikimedia.org/r/1297495

gerritbot added a comment.Jun 4 2026, 5:57 AM

Change #1297511 merged by jenkins-bot:

[mediawiki/services/parsoid@REL1_43] Account for mw:LanguageVariant in WrapSectionState

https://gerrit.wikimedia.org/r/1297511

gerritbot added a comment.Jun 4 2026, 6:00 AM

Change #1297494 merged by jenkins-bot:

[mediawiki/services/parsoid@REL1_45] Account for mw:LanguageVariant in WrapSectionState

https://gerrit.wikimedia.org/r/1297494

Maintenance_bot removed a project: Patch-For-Review.Jun 4 2026, 6:30 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits