Maniphest T419262

Wikimedia\Timestamp\TimestampException: Wikimedia\Timestamp\ConvertibleTimestamp::setTimestamp: Invalid timestamp - 2008-08-13ᑦ22:45:00.000z
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Can reproduce with:

https://iu.wikipedia.org/w/index.php?title=%E1%90%85%E1%90%83%E1%91%AD%E1%90%B1%E1%91%8E%E1%90%8A:%E1%90%B9%E1%95%90%E1%93%82%E1%96%85&variant=ike-cans&useparsoid=1&parsoidnewlc=1

Also
https://sr.wikipedia.org/sr-ec/User_Talk:Pidor003?useparsoid=1&parsoidnewlc=1
https://logstash.wikimedia.org/app/discover#/doc/logstash-*/logstash-deploy-1-7.0.0-1-2026.03.06?id=pTIBxJwBlLUf3R62Zg4U

Looks like the variant of the timestamp is causing issues with DiscussionTools' date (un)formatting?

Error

mwversion: 1.46.0-wmf.18
timestamp: 2026-03-06T16:28:13.864Z
phpversion: 8.3.30
reqId: 590c0328-168f-46b7-a4d1-064d721caec8
Find reqId in Logstash

normalized_message

[{reqId}] {exception_url}   Wikimedia\Timestamp\TimestampException: Wikimedia\Timestamp\ConvertibleTimestamp::setTimestamp: Invalid timestamp - 2008-08-13ᑦ22:45:00.000z

Frame	Location	Call
from	/srv/mediawiki/php-1.46.0-wmf.18/vendor/wikimedia/timestamp/src/ConvertibleTimestamp.php(312)
#0	/srv/mediawiki/php-1.46.0-wmf.18/vendor/wikimedia/timestamp/src/ConvertibleTimestamp.php(222)	Wikimedia\Timestamp\ConvertibleTimestamp->setTimestamp(string)
#1	/srv/mediawiki/php-1.46.0-wmf.18/extensions/DiscussionTools/includes/CommentFormatter.php(746)	Wikimedia\Timestamp\ConvertibleTimestamp->__construct(string)
#2	/srv/mediawiki/php-1.46.0-wmf.18/extensions/DiscussionTools/includes/BatchModifyElements.php(43)	MediaWiki\Extension\DiscussionTools\CommentFormatter::MediaWiki\Extension\DiscussionTools\{closure}(Wikimedia\RemexHtml\Serializer\SerializerNode)
#3	/srv/mediawiki/php-1.46.0-wmf.18/includes/Html/HtmlHelperTrait.php(42)	MediaWiki\Extension\DiscussionTools\BatchModifyElements->MediaWiki\Extension\DiscussionTools\{closure}(Wikimedia\RemexHtml\Serializer\SerializerNode)
#4	/srv/mediawiki/php-1.46.0-wmf.18/vendor/wikimedia/remex-html/src/Serializer/Serializer.php(289)	Wikimedia\RemexHtml\Serializer\HtmlFormatter@anonymous

Impact

Notes

Details

Request URL: https://logstash.wikimedia.org/app/dashboards#/doc/logstash-*/logstash-deploy-1-7.0.0-1-2026.03.06?id=Byz6w5wBlLUf3R62aUpE

Related Changes in Gerrit:

	Subject	Author	Repo	Branch	Lines +/-
	CommentFormatter: Fix bad interaction of 'title' attribute with language converter	Bartosz Dziewoński	mediawiki/extensions/DiscussionTools	master	+4 -2

Customize query in gerrit

Related Objects

Mentioned In: T419830: Signatures aren't properly recognized on ruwiktionary and other projects when using Parsoid, resulting in a missing [ reply ] button

Event Timeline

cscott created this task.Mar 6 2026, 4:34 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 6 2026, 4:34 PM

cscott updated the task description. (Show Details)Mar 6 2026, 4:37 PM

Why is there a "ᑦ" in the timestamp? That's U+1466 CANADIAN SYLLABICS T. There should be a normal ASCII T at that position.

Because that’s what the &variant=ike-cans URL parameter asks for. CommentFormatter.php:746 tries to interpret a title HTML attribute – it’s absolutely reasonable from LanguageConverter to convert title attributes, since they are meant to be human-readable, not machine-readable. Could DiscussionTools use a data- attribute instead for storing machine-readable data?

Ahh, LanguageConverter indeed transforms title attributes, here: https://gerrit.wikimedia.org/g/mediawiki/core/+/c2a5065d72975ea701c8956b4c782f92bebbebcf/includes/Language/LanguageConverter.php#578

DiscussionTools should use a different attribute name here: https://gerrit.wikimedia.org/g/mediawiki/extensions/DiscussionTools/+/5fa7a5cd3dffe11ce0f41950e213c95168fcc37d/includes/CommentFormatter.php#387 https://gerrit.wikimedia.org/g/mediawiki/extensions/DiscussionTools/+/5fa7a5cd3dffe11ce0f41950e213c95168fcc37d/includes/CommentFormatter.php#741

Ironically, a few lines above in LanguageConverter.php says "HTML markups (anything between < and >)" is not converted.

cscott moved this task from Backlog to Q1 FY26-27 on the Content-Platform-Team (Work In Progress) board.Mar 9 2026, 3:29 PM

Johannnes89 mentioned this in T419830: Signatures aren't properly recognized on ruwiktionary and other projects when using Parsoid, resulting in a missing [ reply ] button.Mar 12 2026, 12:44 PM

cscott added a parent task: T413810: 1.46.0-wmf.19 deployment blockers.Mar 12 2026, 2:21 PM

cscott removed a parent task: T413810: 1.46.0-wmf.19 deployment blockers.

All of the test URLs have ?parsoidnewlc=1 which is from the experimental new parsoid language converter support and are being triggered from our visualdiff testing. I don't believe this affects ordinary readers, as we haven't turned on the new parsoid language converter implementation yet.

Yes, machine-readable dates was part of the idea behind https://cscott.net/wiki/index.php/Ideas/A_Dozen_Visions_for_Wikitext/Syntax_for_Discussions but it was never implemented, alas.

Change #1253652 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] CommentFormatter: Fix bad interaction of 'title' attribute with language converter

https://gerrit.wikimedia.org/r/1253652

gerritbot added a project: Patch-For-Review.Mar 16 2026, 9:07 PM

Change #1253652 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] CommentFormatter: Fix bad interaction of 'title' attribute with language converter

https://gerrit.wikimedia.org/r/1253652

Maintenance_bot removed a project: Patch-For-Review.Mar 16 2026, 11:31 PM

ReleaseTaggerBot added a project: MW-1.46-notes (1.46.0-wmf.20; 2026-03-17).Mar 17 2026, 12:01 AM

• matmarex closed this task as Resolved.Mar 17 2026, 12:29 AM

• matmarex claimed this task.

MSantos added a project: Essential-Work.Jul 9 2026, 11:51 AM

Wikimedia\Timestamp\TimestampException: Wikimedia\Timestamp\ConvertibleTimestamp::setTimestamp: Invalid timestamp - 2008-08-13ᑦ22:45:00.000zClosed, ResolvedPublicPRODUCTION ERRORActions