Maniphest T419424

PageForms: mwext-phan-php83 fails in PF_RunQuery with PhanImpossibleTypeComparison
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Dumbledore
	Mar 9 2026, 1:37 PM

Description

What happens?:

While testing an unrelated PageForms change, CI fails first in mwext-phan-php83 because of an existing Phan error in PF_RunQuery.php.

The failing message is:

specials/PF_RunQuery.php:106 PhanImpossibleTypeComparison Impossible attempt to check if PFUtils::getParser()->getOutput() of type \MediaWiki\Parser\ParserOutput is identical to null of type null

What should have happened instead?:

mwext-phan-php83 should not fail on this existing check in PF_RunQuery.php, so unrelated patches can be tested normally.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Avoid Phan impossible null check in PF_RunQuery	mediawiki/extensions/PageForms	master	+4 -3

Customize query in gerrit

Related Objects

Mentioned Here: rEPFM212dc24631b6: Validation fixes for PFRunQuery

Event Timeline

Dumbledore created this task.Mar 9 2026, 1:37 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 9 2026, 1:37 PM

Dumbledore claimed this task.Mar 9 2026, 1:38 PM

Change #1249301 had a related patch set uploaded (by Dumbledore; author: Dumbledore):

[mediawiki/extensions/PageForms@master] Avoid Phan impossible null check in PF_RunQuery

https://gerrit.wikimedia.org/r/1249301

gerritbot added a project: Patch-For-Review.Mar 9 2026, 1:49 PM

@Yaron_Koren, how do we fix this so we don't have the null check? I saw this as a TODO comment, but I no longer see it.

I think this will help greatly.

Oh, I missed this. This was fixed in 212dc24631b6. It can truly fixed once Page Forms stops supporting MediaWiki versions below 1.43.

Yaron_Koren closed this task as Resolved.Mar 10 2026, 4:21 AM

Change #1249301 abandoned by Dumbledore:

[mediawiki/extensions/PageForms@master] Avoid Phan impossible null check in PF_RunQuery

Reason:

Already fixed in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/PageForms/+/1249343