Page MenuHomePhabricator

Rename HtmlCacheUpdater service to HTMLCacheUpdater
Open, Needs TriagePublic

Description

The class was renamed in 35b25428 but the service wasn't, which can cause confusion (e.g. T419362: Wikimedia\Services\NoSuchServiceException: No such service: HTMLCacheUpdater in GlobalUserPage).
The service should be renamed to HTMLCacheUpdater instead.

Usages: https://codesearch.wmcloud.org/search/?q=HtmlCacheUpdater

Event Timeline

Change #1249307 had a related patch set uploaded (by SomeRandomDeveloper; author: SomeRandomDeveloper):

[mediawiki/core@master] Rename HtmlCacheUpdater service to HTMLCacheUpdater

https://gerrit.wikimedia.org/r/1249307

Change #1249311 had a related patch set uploaded (by SomeRandomDeveloper; author: SomeRandomDeveloper):

[mediawiki/extensions/Wikibase@master] Use "HTMLCacheUpdater" instead of "HtmlCacheUpdater"

https://gerrit.wikimedia.org/r/1249311

As part of this I ideally also want to update places that call the old method name in MediaWikiServices (to make it easier to search for usages) and reference the old class name, which is why I chose to include all occurrences of the old service/class name. But yeah the deprecation will only affect those two

As part of this I ideally also want to update places that call the old method name in MediaWikiServices (to make it easier to search for usages) and reference the old class name, which is why I chose to include all occurrences of the old service/class name. But yeah the deprecation will only affect those two

This conflates two issues of different severity and makes the change unnecessarily large in my view. Since the class still supports the old alias, the symbol still remains unless you want to remove that too. And if you want to remove that, it is still worth using separate patches.

Change #1249398 had a related patch set uploaded (by SomeRandomDeveloper; author: SomeRandomDeveloper):

[mediawiki/extensions/GlobalUserPage@master] Use new service name for HTMLCacheUpdater

https://gerrit.wikimedia.org/r/1249398

Change #1249400 had a related patch set uploaded (by SomeRandomDeveloper; author: SomeRandomDeveloper):

[mediawiki/core@master] Hard-deprecate old alias for HTMLCacheUpdater service

https://gerrit.wikimedia.org/r/1249400

[...]
This conflates two issues of different severity and makes the change unnecessarily large in my view. Since the class still supports the old alias, the symbol still remains unless you want to remove that too. And if you want to remove that, it is still worth using separate patches.

I've uploaded updated patches for the soft deprecation, the fixes in two extensions (the third one is on Github and probably doesn't use the master branch policy, so it can't be updated yet) and the hard deprecation; I'll make the other changes related to the old class name and the function name in MediaWikiServices in a separate patchset.

Change #1249307 merged by jenkins-bot:

[mediawiki/core@master] Rename HtmlCacheUpdater service to HTMLCacheUpdater

https://gerrit.wikimedia.org/r/1249307

Change #1249398 merged by jenkins-bot:

[mediawiki/extensions/GlobalUserPage@master] Use new service name for HTMLCacheUpdater

https://gerrit.wikimedia.org/r/1249398

Change #1249311 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Use new service name for HTMLCacheUpdater

https://gerrit.wikimedia.org/r/1249311

Change #1250059 had a related patch set uploaded (by SomeRandomDeveloper; author: SomeRandomDeveloper):

[mediawiki/core@master] MediaWikiServices: Rename getHtmlCacheUpdater to getHTMLCacheUpdater

https://gerrit.wikimedia.org/r/1250059

Change #1250075 had a related patch set uploaded (by SomeRandomDeveloper; author: SomeRandomDeveloper):

[mediawiki/core@master] Rename HtmlCacheUpdaterIntegrationTest to HTMLCacheUpdaterIntegrationTest

https://gerrit.wikimedia.org/r/1250075

Change #1249400 merged by jenkins-bot:

[mediawiki/core@master] Hard-deprecate old alias for HTMLCacheUpdater service

https://gerrit.wikimedia.org/r/1249400

Change #1250075 merged by jenkins-bot:

[mediawiki/core@master] Rename HtmlCacheUpdaterIntegrationTest to HTMLCacheUpdaterIntegrationTest

https://gerrit.wikimedia.org/r/1250075

Change #1250059 merged by jenkins-bot:

[mediawiki/core@master] MediaWikiServices: Rename getHtmlCacheUpdater to getHTMLCacheUpdater

https://gerrit.wikimedia.org/r/1250059