Page MenuHomePhabricator

If we don't find enough edits to display to the user, extend the API call to another group of edits for filtering
Open, LowPublic2 Estimated Story Points

Description

We're currently retrieving a set number of edits from the API and then filtering them down before displaying them to the user in the Personal Dashboard. This leaves the door open to not finding enough edits to display. If we don't find as many as we anticipate (at least 5, currently), we could be going back to continue the API call to find another set of edits to filter.

This should have a sensible cap so we don't endlessly make API calls on e.g. test or local wikis.

Event Timeline

Kgraessle moved this task from In Progress to Ready on the Moderator-Tools-Team (Kanban) board.
Kgraessle subscribed.

I was chatting in RTL that this may make more sense to implement as a follow on to the pinia store refactor in T422607: Define and add Pinia storage for PersonalDashboard Review Changes module.

Yep that's fine, I don't think we're running into any issues right now with this.

Change #1272742 had a related patch set uploaded (by Kgraessle; author: Kgraessle):

[mediawiki/extensions/PersonalDashboard@master] If we don't find enough edits to display to the user, extend the API call to another group of edits for filtering

https://gerrit.wikimedia.org/r/1272742

Change #1272760 had a related patch set uploaded (by Kgraessle; author: Kgraessle):

[mediawiki/extensions/PersonalDashboard@master] If we don't find enough edits to display to the user, extend the API call to another group of edits for filtering

https://gerrit.wikimedia.org/r/1272760

Change #1272742 abandoned by Kgraessle:

[mediawiki/extensions/PersonalDashboard@master] If we don't find enough edits to display to the user, extend the API call to another group of edits for filtering

Reason:

Pushed branch incorrectly

https://gerrit.wikimedia.org/r/1272742

Change #1272761 had a related patch set uploaded (by Kgraessle; author: Kgraessle):

[mediawiki/extensions/PersonalDashboard@master] If we don't find enough edits to display to the user, extend the API call to another group of edits for filtering

https://gerrit.wikimedia.org/r/1272761

Change #1272760 abandoned by Kgraessle:

[mediawiki/extensions/PersonalDashboard@master] If we don't find enough edits to display to the user, extend the API call to another group of edits for filtering

Reason:

Dupe

https://gerrit.wikimedia.org/r/1272760

Dillon changed the point value for this task from 1 to 2.Thu, Apr 16, 4:39 PM

Change #1272761 merged by jenkins-bot:

[mediawiki/extensions/PersonalDashboard@master] If we don't find enough edits to display to the user, extend the API call to another group of edits for filtering

https://gerrit.wikimedia.org/r/1272761