Maniphest T419473

Patchdemo wiki fails to fetch images from commons
Closed, DuplicatePublicBUG REPORT
Actions

Assigned To

None

Authored By

	dmaza
	Mar 9 2026, 7:54 PM

Description

This is the failing wiki https://f903956008.catalyst.wmcloud.org/wiki/User:Bob/Test
May be related to API rate limiting

Wiki with InstantCommons requests fail with error code 429
Wiki with QuickInstantCommons fails with internal error. Seems like internal request on Repo.php(804) fails. Maybe this? https://www.mediawiki.org/wiki/Extension:QuickInstantCommons#Rate_limiting_with_Wikimedia_Commons

More information

[e23fccd04467ca1120feb62e] /wiki/User:Bob/Test LogicException: Missing imgname/key

Backtrace:

from /var/www/html/w/extensions/QuickInstantCommons/src/Repo.php(812)
#0 /var/www/html/w/extensions/QuickInstantCommons/src/Repo.php(593): MediaWiki\Extension\QuickInstantCommons\Repo->finalizeCacheIfNeeded()
#1 /var/www/html/w/extensions/QuickInstantCommons/src/Repo.php(257): MediaWiki\Extension\QuickInstantCommons\Repo->httpGetCached()
#2 /var/www/html/w/extensions/QuickInstantCommons/src/File.php(67): MediaWiki\Extension\QuickInstantCommons\Repo->fetchImageQuery()
#3 /var/www/html/w/includes/FileRepo/FileRepo.php(433): MediaWiki\Extension\QuickInstantCommons\File::newFromTitle()
#4 /var/www/html/w/extensions/QuickInstantCommons/src/Repo.php(161): MediaWiki\FileRepo\FileRepo->newFile()
#5 /var/www/html/w/includes/FileRepo/FileRepo.php(474): MediaWiki\Extension\QuickInstantCommons\Repo->newFile()
#6 /var/www/html/w/includes/FileRepo/FileRepo.php(557): MediaWiki\FileRepo\FileRepo->findFile()
#7 /var/www/html/w/includes/FileRepo/RepoGroup.php(203): MediaWiki\FileRepo\FileRepo->findFiles()
#8 /var/www/html/w/includes/Parser/Parsoid/Config/DataAccess.php(228): MediaWiki\FileRepo\RepoGroup->findFiles()
#9 /var/www/html/w/parsoid/src/Wt2Html/DOM/Processors/AddMediaInfo.php(696): MediaWiki\Parser\Parsoid\Config\DataAccess->getFileInfo()\''\\
...

Related Objects

Mentioned In: T419819: QuickInstantCommons triggering "Database error"
Mentioned Here: T299953: Normalize imagelinks table

Event Timeline

dmaza created this task.Mar 9 2026, 7:54 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 9 2026, 7:54 PM

SomeRandomDeveloper subscribed.Mar 9 2026, 8:02 PM

Hrm. Seems like it's not rate limiting.

In fiddling with it in patchdemo a bit, I realize that
https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/QuickInstantCommons/+/d24e4865b1747798d32fffefc33d29e0ac5cec58/src/Hooks.php#73

is coming back with an array of empty arrays on patchdemo, so when it tries to grab the image from commons, the image name is blank.

I wonder if this is related to T299953: Normalize imagelinks table since li_to is used in that query (c.f. https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1248863).

Change #1250057 had a related patch set uploaded (by Thcipriani; author: Thcipriani):

[mediawiki/extensions/QuickInstantCommons@master] Non-local image query use lt_title instead of lt_to

https://gerrit.wikimedia.org/r/1250057

gerritbot added a project: Patch-For-Review.Mar 10 2026, 7:23 PM

Test wiki created on Patch demo by TCipriani (WMF) using patch(es) linked to this task:
https://585014f4d9.catalyst.wmcloud.org/w/

Change #1250057 abandoned by Thcipriani:

[mediawiki/extensions/QuickInstantCommons@master] Non-local image query use lt_title instead of lt_to

Reason:

¯\_(ツ)_/¯

https://gerrit.wikimedia.org/r/1250057

Maintenance_bot removed a project: Patch-For-Review.Mar 10 2026, 7:30 PM

In T419473#11694263, @thcipriani wrote:

Hrm. Seems like it's not rate limiting.

In fiddling with it in patchdemo a bit, I realize that
https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/QuickInstantCommons/+/d24e4865b1747798d32fffefc33d29e0ac5cec58/src/Hooks.php#73

is coming back with an array of empty arrays on patchdemo, so when it tries to grab the image from commons, the image name is blank.

I wonder if this is related to T299953: Normalize imagelinks table since li_to is used in that query (c.f. https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1248863).

Oh interesting. I just assumed because of InstantCommons failing with 429

thcipriani closed this task as a duplicate of T419819: QuickInstantCommons triggering "Database error".Mar 12 2026, 4:07 PM

thcipriani mentioned this in T419819: QuickInstantCommons triggering "Database error".

Change #1250057 restored by Thcipriani:

[mediawiki/extensions/QuickInstantCommons@master] Non-local image query use lt_title instead of lt_to

https://gerrit.wikimedia.org/r/1250057

gerritbot added a project: Patch-For-Review.Mar 12 2026, 4:08 PM

Test wiki created on Patch demo by JNuche (WMF) using patch(es) linked to this task:
https://8da43133fd.catalyst.wmcloud.org/w/

Test wiki on Patch demo by JNuche (WMF) using patch(es) linked to this task was deleted:

~~https://8da43133fd.catalyst.wmcloud.org/w/~~

Tacsipacsi removed a project: Patch-For-Review.Sun, Mar 15, 11:55 AM

Tacsipacsi subscribed.

Patchdemo wiki fails to fetch images from commonsClosed, DuplicatePublicBUG REPORTActions

Description

Related Objects

Event Timeline

Patchdemo wiki fails to fetch images from commons
Closed, DuplicatePublicBUG REPORT
Actions