Page MenuHomePhabricator
Create Task
Maniphest T419479

Upgrading pagelinks table makes pl_target_id NOT NULL, creating from scratch doesn’t
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

  • Upgrade MediaWiki from an older version to 1.43 and note that the patch for T299947 will perform the alter CHANGE pl_target_id pl_target_id BIGINT UNSIGNED NOT NULL;
  • Consult the schema for new wikis as currently specified in tables.json and tables-generated.sql and notice that they do NOT mark the column as NOT NULL, see here
  • Run Ladsgroup’s drift checker and see a reported drift, even when update.php has finished running - pagelinks pl_target_id field-nullable-mismatch. The abstract schema says that the column is nullable, and the schema changes performed by the updater make it not null.

What happens?:
There is a drift, the schema changes performed by the updater result in a schema different from the schema that would be created by the installer.

What should have happened instead?:
The schemas should match, either with the column nullable in both cases (new wiki vs upgrade) or not nullable in both cases. No drift should be reported by the drift checker.

Software version
MediaWiki 1.43

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
sql: Mark pl_target_id as non-nullable in abstract schemamediawiki/coreREL1_44+1 -1
sql: Mark pl_target_id as non-nullable in abstract schemamediawiki/coreREL1_45+1 -1
sql: Mark pl_target_id as non-nullable in abstract schemamediawiki/coreREL1_43+1 -1
sql: Mark pl_target_id as non-nullable in abstract schemamediawiki/coremaster+1 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

Elcapitan68 created this task.Mar 9 2026, 9:23 PM
Restricted Application edited projects, added Data-Engineering; removed Patch-For-Review. · View Herald TranscriptMar 9 2026, 9:23 PM
taavi removed projects: Data-Engineering, Schema-change, MW-1.45-notes (1.45.0-wmf.6; 2025-06-17), User-notice-archive, Data-Persistence, MW-1.43-notes (1.43.0-wmf.11; 2024-06-25).Mar 9 2026, 9:41 PM
gerritbot added a comment.Mar 9 2026, 11:15 PM

Change #1249425 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/core@master] sql: Mark pl_target_id as non-nullable in abstract schema

https://gerrit.wikimedia.org/r/1249425

gerritbot added a project: Patch-For-Review.Mar 9 2026, 11:15 PM
Zabe added a comment.Mar 9 2026, 11:24 PM

Consult the schema for new wikis as currently specified in tables.json and tables-generated.sql and notice that they do NOT mark the column as NOT NULL, see here

This is actually only the case in the json file and not the generated sql files. See their current content.

MySQL

CREATE TABLE /*_*/pagelinks (
  pl_from INT UNSIGNED DEFAULT 0 NOT NULL,
  pl_target_id BIGINT UNSIGNED NOT NULL,
  pl_from_namespace INT DEFAULT 0 NOT NULL,
  INDEX pl_target_id (pl_target_id, pl_from),
  INDEX pl_backlinks_namespace_target_id (
    pl_from_namespace, pl_target_id,
    pl_from
  ),
  PRIMARY KEY(pl_from, pl_target_id)
) /*$wgDBTableOptions*/;

SQLite

CREATE TABLE /*_*/pagelinks (
  pl_from INTEGER UNSIGNED DEFAULT 0 NOT NULL,
  pl_target_id BIGINT UNSIGNED NOT NULL,
  pl_from_namespace INTEGER DEFAULT 0 NOT NULL,
  PRIMARY KEY(pl_from, pl_target_id)
);

PostgreSQL

CREATE TABLE pagelinks (
  pl_from INT DEFAULT 0 NOT NULL,
  pl_target_id BIGINT NOT NULL,
  pl_from_namespace INT DEFAULT 0 NOT NULL,
  PRIMARY KEY(pl_from, pl_target_id)
);
Quiddity unsubscribed.Mar 9 2026, 11:57 PM
gerritbot added a comment.Thu, Mar 12, 10:31 AM

Change #1249425 merged by jenkins-bot:

[mediawiki/core@master] sql: Mark pl_target_id as non-nullable in abstract schema

https://gerrit.wikimedia.org/r/1249425

ReleaseTaggerBot added a project: MW-1.46-notes (1.46.0-wmf.20; 2026-03-17).Thu, Mar 12, 11:00 AM
Elcapitan68 added a comment.Thu, Mar 19, 5:28 PM

Thank you, @Zabe

I see it in master. Can the patch be backported to REL1_43, please?

Zabe claimed this task.Thu, Mar 19, 6:53 PM
gerritbot added a comment.Thu, Mar 19, 10:58 PM

Change #1255903 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/core@REL1_45] sql: Mark pl_target_id as non-nullable in abstract schema

https://gerrit.wikimedia.org/r/1255903

gerritbot added a comment.Thu, Mar 19, 10:58 PM

Change #1255904 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/core@REL1_44] sql: Mark pl_target_id as non-nullable in abstract schema

https://gerrit.wikimedia.org/r/1255904

gerritbot added a comment.Thu, Mar 19, 10:59 PM

Change #1255905 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/core@REL1_43] sql: Mark pl_target_id as non-nullable in abstract schema

https://gerrit.wikimedia.org/r/1255905

gerritbot added a comment.Thu, Mar 19, 11:19 PM

Change #1255905 merged by jenkins-bot:

[mediawiki/core@REL1_43] sql: Mark pl_target_id as non-nullable in abstract schema

https://gerrit.wikimedia.org/r/1255905

gerritbot added a comment.Thu, Mar 19, 11:21 PM

Change #1255903 merged by jenkins-bot:

[mediawiki/core@REL1_45] sql: Mark pl_target_id as non-nullable in abstract schema

https://gerrit.wikimedia.org/r/1255903

gerritbot added a comment.Thu, Mar 19, 11:44 PM

Change #1255904 merged by jenkins-bot:

[mediawiki/core@REL1_44] sql: Mark pl_target_id as non-nullable in abstract schema

https://gerrit.wikimedia.org/r/1255904

Zabe closed this task as Resolved.Thu, Mar 19, 11:47 PM
ReleaseTaggerBot added projects: MW-1.44-notes, MW-1.43-notes, MW-1.45-notes.Fri, Mar 20, 12:00 AM
Trizek-WMF unsubscribed.Fri, Mar 20, 5:22 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits