Page MenuHomePhabricator

Leaking listItem token
Closed, ResolvedPublic

Description

From https://prv-tests.wmcloud.org/diff/brwiki/Degemer

λ (master) echo " {{1x|*test}}" | php bin/parse.php --integrated
<pre data-parsoid='{"dsr":[0,13,1,0]}'><listitem about="#mwt1" typeof="mw:Transclusion" data-parsoid='{"a":{"bullets":null},"sa":{"bullets":"*"},"autoInsertedEnd":true,"pi":[[{"k":"1"}]],"dsr":[1,13,null,null]}' data-mw='{"parts":[{"template":{"target":{"wt":"1x","href":"./Template:1x"},"params":{"1":{"wt":"*test"}},"i":0}}]}'>test</listitem></pre>

The listItem token ends up in a IndentPreTk which the ListHandler ignores. The Sanitizer leaves the tag be because it isn't an html literal.

Event Timeline

Change #1249435 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/services/parsoid@master] [WIP] Fix leaking listitem

https://gerrit.wikimedia.org/r/1249435

Change #1249435 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Fix leaking listItem tokens

https://gerrit.wikimedia.org/r/1249435

Change #1253544 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.23.0-a22

https://gerrit.wikimedia.org/r/1253544

Change #1253544 merged by jenkins-bot:

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.23.0-a22

https://gerrit.wikimedia.org/r/1253544