Page MenuHomePhabricator

Splitting GrowthExperiments from gated extensions
Closed, ResolvedPublic

Description

In order to speed up the gated extensions job for core, we're splitting the GrowthExperiments (the second slowest set of tests in the job) into a separate job that can run in parallel with the rest of the tests.

This epic contains all tasks related to this initiatve.

Event Timeline

Michael added subscribers: DMburugu, Urbanecm_WMF, Michael.

I appreciate the goal of reducing the runtime of our CI, but I don't think this is a good idea. The point of GrowthExperiments being a gated extension is that it integrates with a lot of other extensions in core parts of the Wikimedia stack. Moving GrowthExperiments to its own job defeats the point of that.

Also, it would be great if such drastic changes would be run by our team well in advance and happen only in close coordination. The #talk-to-growth Slack channel is an ideal place to reach out.

The implementation got split in two subtasks:

We have deployed both this morning and confirmed they are working.

Looking at the Grafana dashboard for Suceeding quibble-with-gated-extensions-selenium-php83 durations:

quibble-with-gated-extensions.png (934×524 px, 55 KB)

One of the build took less than 7 minutes when before the change it was around 11 minutes. That is a 33% speed increase. It used to take more than 20 minutes not so long ago. With Wikibase and now GrowthExperiments split to their own jobs, the job is now THREE times faster 🚀

There are follows up action:

  • T422786 which is for when we cut the next MediaWiki release branch, there is no urgency.
  • T418234 for documentation update, I am not sure how related it is to this task.

@zeljkofilipin in short I think we can claim this task to be resolved after we have resolved the two tasks tracking the implementation in JJB and Zuul. 🎉

Peter claimed this task.