Page MenuHomePhabricator
Create Task
Maniphest T419589

[Share Highlights] Handle language-specific Wikipedia logos
Open, MediumPublic2 Estimated Story Points
Actions

Description

The quote card's designs contain a Wikipedia logo icon that should be specific to the target project's language.
For instance, here is the white version:

Screenshot 2026-03-10 at 19.03.16.png (1×878 px, 145 KB)

See also T418602: [DESIGN] Share highlights and article share on Minerva and Figma spec.

Acceptance criteria

  • for the experiment's sake, we could narrow to Arabic, Chinese, French, Indonesian, Vietnamese, and English

[] Codex icons don't seem to have logos, so we need to host SVG icons in ReaderExperiments

    • we found we can reuse the existing wordmark SVG from $wgLogos; in this case we pull it directly from the MobileFrontend HTML
  • figure out how to load appropriate icons depending on the Wikipedia language chapter
    • done -- pulling the currently configured wordmark, which already gives us a localized SVG URL, a localized alt text, and a width/height
  • take into account LTR and RTL behavior
    • Existing flipping seems to account for the left/right positioning of the wordmark image correctly in testing with Arabic

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
ShareHighlight: Use the live Wikipedia wordmark in the quote sharemediawiki/extensions/ReaderExperimentsmaster+39 -5
Customize query in gerrit

Related Objects
Search...

Event Timeline

mfossati created this task.Mar 10 2026, 6:16 PM
Restricted Application added subscribers: hubaishan, Aklapper. · View Herald TranscriptMar 10 2026, 6:16 PM
mfossati added a parent task: T416432: [Epic] Share Highlight experiment.Mar 10 2026, 6:16 PM
Restricted Application added a subscriber: alaa. · View Herald TranscriptMar 10 2026, 6:16 PM
mfossati moved this task from Incoming/Inbox to Needs Refinement on the Reader Growth Team board.Mar 10 2026, 6:17 PM
SherryYang-WMF triaged this task as Medium priority.Mar 10 2026, 10:34 PM
HSwan-WMF set the point value for this task to 2.Mar 12 2026, 4:48 PM
SherryYang-WMF moved this task from Needs Refinement to Ready on the Reader Growth Team board.Tue, Mar 17, 12:00 AM
SherryYang-WMF moved this task from Ready to Sprint 5 (Mar 18 - Mar 31) Q3 25/26 on the Reader Growth Team board.Wed, Mar 18, 4:19 PM
SherryYang-WMF edited projects, added Reader Growth Team (Sprint 5 (Mar 18 - Mar 31) Q3 25/26); removed Reader Growth Team.
mfossati mentioned this in T420293: [Share Highlights] Experiment instrumentation for Share Action.Wed, Mar 18, 5:00 PM
bvibber claimed this task.Mon, Mar 23, 9:16 PM
bvibber moved this task from Committed to Doing on the Reader Growth Team (Sprint 5 (Mar 18 - Mar 31) Q3 25/26) board.
bvibber subscribed.

Taking.

bvibber added a subscriber: JScherer-WMF.EditedMon, Mar 23, 9:39 PM

@JScherer-WMF note we're currently blocked on a design question: Jon and I aren't certain whether the wordmark is supposed to use whatever the currently configured mobile header wordmark is on the MediaWiki site configuration -- eg that right now it SHOULD include the "Wikipedia 25" logo -- but also means none of our local development/test sites will show the "WikipediA" wordmark unless we do some local configuration, but the implementation is simply "reuse this existing element's URL") ... or whether it's meant to hardcode the standard wordmark SVGs (in which case it's copy 6 files and hardcode the links based on site language).

Need a decision from design to proceed.

bvibber moved this task from Doing to Committed on the Reader Growth Team (Sprint 5 (Mar 18 - Mar 31) Q3 25/26) board.Mon, Mar 23, 9:52 PM
bvibber moved this task from Committed to Doing on the Reader Growth Team (Sprint 5 (Mar 18 - Mar 31) Q3 25/26) board.Tue, Mar 24, 7:46 PM
gerritbot added a comment.Wed, Mar 25, 11:09 PM

Change #1260835 had a related patch set uploaded (by Bvibber; author: Bvibber):

[mediawiki/extensions/ReaderExperiments@master] ShareHighlight: Use the live Wikipedia wordmark in the quote share

https://gerrit.wikimedia.org/r/1260835

gerritbot added a project: Patch-For-Review.Wed, Mar 25, 11:09 PM
bvibber moved this task from Doing to Code Review on the Reader Growth Team (Sprint 5 (Mar 18 - Mar 31) Q3 25/26) board.Wed, Mar 25, 11:20 PM
bvibber updated the task description. (Show Details)
bvibber added a comment.Wed, Mar 25, 11:24 PM

As noted above we unblocked on design decision to go ahead and use the live wordmark, which keeps things nice and simple. Using CSS filters to invert( 1 ) the brightness for dark-mode and Wikipedia-style output, and saturate( 0 ) it to force the Wikipedia 25 images to grayscale. Opacity is applied on the img element, and alt text and sizes are copied from the live original. Seems to work well.

Note some followup for using this while in dark mode -- there are a few bits in the styles that need to be fixed so the "light" output produces correct output in "dark mode", as well as fixing the background in the images for both light and dark mode. But that's outside of scope so I haven't touched thoes :D

lwatson added a project: ReaderExperiments-ShareHighlight.Tue, Mar 31, 6:20 PM
SherryYang-WMF moved this task from Sprint 5 (Mar 18 - Mar 31) Q3 25/26 to Sprint 1 (Apr 1 - Apr 14) Q4 25/26 on the Reader Growth Team board.Wed, Apr 1, 4:29 PM
SherryYang-WMF edited projects, added Reader Growth Team (Sprint 1 (Apr 1 - Apr 14) Q4 25/26); removed Reader Growth Team (Sprint 5 (Mar 18 - Mar 31) Q3 25/26).
lwatson moved this task from Committed to Code Review on the Reader Growth Team (Sprint 1 (Apr 1 - Apr 14) Q4 25/26) board.Fri, Apr 3, 4:40 PM
gerritbot added a comment.Tue, Apr 7, 10:53 AM

Change #1260835 merged by jenkins-bot:

[mediawiki/extensions/ReaderExperiments@master] ShareHighlight: Use the live Wikipedia wordmark in the quote share

https://gerrit.wikimedia.org/r/1260835

mfossati updated the task description. (Show Details)Tue, Apr 7, 10:57 AM
mfossati moved this task from Code Review to QA on the Reader Growth Team (Sprint 1 (Apr 1 - Apr 14) Q4 25/26) board.
Maintenance_bot removed a project: Patch-For-Review.Tue, Apr 7, 11:31 AM
ReleaseTaggerBot added a project: MW-1.46-notes (1.46.0-wmf.24; 2026-04-14).Tue, Apr 7, 12:00 PM
bvibber added a comment.Wed, Apr 8, 9:35 PM

Ok I think this is fine per the version of the spec implemented -- as we separate out the 'page' vs quote' share mode implementations we'll want to treat them separately per updated design plans. Fine to keep in QA for now; should be live on beta.

Example testing on beta:

image.png (1×2 px, 344 KB)

this shows the configured mobile beta logo, which would on the live wikis be the live, localized logo wordmark SVG.

egardner moved this task from QA to Signoff on the Reader Growth Team (Sprint 1 (Apr 1 - Apr 14) Q4 25/26) board.Mon, Apr 13, 4:08 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits