Page MenuHomePhabricator

tokens: Move font family definition to skin.variables Less file
Closed, ResolvedPublic1 Estimated Story Points

Description

Background

MinervaNeue sets OS specific font stack for historic reasons in minerva.variables.less and not mediawiki.skin.variables.less.

Goal

Use consistent token overrides in the right place. This is an indirect predecessor to T418504 to remove confusion and technical debt.
Additionally remove the non-working font-family-sans definition as there are no applications.

Acceptance criteria for done

  • Set @font-family-base in mediawiki.skin.variables.less
  • Remove @font-family-sans

QA

  • Is the font family on Minerva the same as in production, and also are components untouched in their font families? There should really be no visible rendering difference.

Event Timeline

Change #1250192 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/skins/MinervaNeue@master] tokens: Use skin variables for font family definition

https://gerrit.wikimedia.org/r/1250192

Change #1250192 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] tokens: Use skin variables for font family definition

https://gerrit.wikimedia.org/r/1250192

Volker_E triaged this task as Medium priority.
Volker_E set the point value for this task to 1.
Volker_E updated the task description. (Show Details)