Page MenuHomePhabricator

Quibble should report individual durations for browser tests npm install/test run
Closed, ResolvedPublic

Description

Following up on T417399: Quibble should emit a report of each time it took to run the steps/stages, we need for browser tests a break down of the time it took for npm install and npm run selenium-test. I think we talked about it with @Peter and @zeljkofilipin , but that got lost in the implementation of the duration report.

For a patch triggered for GrowthExperiments the quibble-with-gated-extensions-selenium-php83 which does quibble --run selenium the duration report shows:

│ 648.633s │ Browser tests: mediawiki/extensions/GrowthExperiments,          │
│          │ mediawiki/core, mediawiki/extensions/AbuseFilter,               │
│          │ mediawiki/extensions/AntiSpoof, mediawiki/extensions/Babel,     │
│          │ mediawiki/extensions/BetaFeatures,                              │
│          │ mediawiki/extensions/CampaignEvents,                            │
│          │ mediawiki/extensions/CheckUser,                                 │
│          │ mediawiki/extensions/CirrusSearch, mediawiki/extensions/Cite,   │
...

Which is not convenient. The reason is that inside Quibble, the browser tests is a single command (quibble.commands.BrowserTests which iterates through the repositories.

The command should not list every single repositories, that is unnecessarily long and it does not even filter out repositories that do not have the selenium-test entry. We also already have that list from the Zuul clone command above, it is thus redundant.

Details

Related Changes in Gerrit:

Event Timeline

Change #1250584 had a related patch set uploaded (by Hashar; author: Hashar):

[integration/quibble@master] Split BroswerTests duration reports

https://gerrit.wikimedia.org/r/1250584

With https://gerrit.wikimedia.org/r/c/integration/quibble/+/1250584 and against mediawiki/core + VisualEditor, the duration report would yield:

│ 202.038s │ Browser tests in './.'                        │ 
│ 186.817s │ Browser tests in './extensions/VisualEditor'  │ 
│ 388.857s │ Browser tests                                 │

This way we get the per project breakdown and the total run time (from the last entry Browser tests, which is the new name of the command running them all)

Change #1250584 merged by jenkins-bot:

[integration/quibble@master] Split BrowserTests duration reports

https://gerrit.wikimedia.org/r/1250584

This has been released.