Page MenuHomePhabricator

Replace not.toExist patterns since it used the configured max wait time
Closed, ResolvedPublic

Description

In a couple of places in core we use the pattern making sure elements do not exists on a page. We do that using .not.toExist. The problem is that it used the default configured max wait time (10 seconds for us). Meaning it will wait ten seconds with retries to see if the element do not exist. I did try locally where I increased the wait time to 20 setting `waitforTimeout: 20000. Then the temporaryuser test that uses not.toExist twice took over 40 seconds (instead of just over 20 seconds).

tests/selenium/specs/temporaryuser.js
Temporary user
  ✓ should not see signup form fields relevant to named users
1 passing (41.2s)

I then fixed it and runned the test locally:

tests/selenium/specs/temporaryuser.js
Temporary user
  ✓ should not see signup form fields relevant to named users
1 passing (1.3s)

Acceptance Criteria:

  • Replace all not.toExists in core

Event Timeline

Change #1251001 had a related patch set uploaded (by Phedenskog; author: Phedenskog):

[mediawiki/core@master] selenium: Add helper function to check if element exists on a page

https://gerrit.wikimedia.org/r/1251001

Change #1251003 had a related patch set uploaded (by Phedenskog; author: Phedenskog):

[mediawiki/core@master] selenium: Replace not.toExist with utility function

https://gerrit.wikimedia.org/r/1251003

Change #1251004 had a related patch set uploaded (by Phedenskog; author: Phedenskog):

[mediawiki/core@master] selenium: Remove no.toExists for special pages example

https://gerrit.wikimedia.org/r/1251004

Change #1251006 had a related patch set uploaded (by Phedenskog; author: Phedenskog):

[mediawiki/core@master] selenium: Check if element exists instead if not.toBeDisplayed

https://gerrit.wikimedia.org/r/1251006

Change #1251030 had a related patch set uploaded (by Phedenskog; author: Phedenskog):

[mediawiki/core@master] selenium: Replace not.toExist with isExisting to make things faster

https://gerrit.wikimedia.org/r/1251030

Change #1251003 abandoned by Phedenskog:

[mediawiki/core@master] selenium: Replace not.toExist with utility function

Reason:

Replaced by https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1251030

https://gerrit.wikimedia.org/r/1251003

Change #1251001 abandoned by Phedenskog:

[mediawiki/core@master] selenium: Add helper function to check if element exists on a page

Reason:

Replaced by https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1251030

https://gerrit.wikimedia.org/r/1251001

Change #1251004 abandoned by Phedenskog:

[mediawiki/core@master] selenium: Remove not.toExists for special pages example

Reason:

Replaced by https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1251030

https://gerrit.wikimedia.org/r/1251004

Change #1251006 abandoned by Phedenskog:

[mediawiki/core@master] selenium: Check if element exists instead if not.toBeDisplayed

Reason:

This is not actually do the exact same thing, so lets wait with this.

https://gerrit.wikimedia.org/r/1251006

Change #1251052 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/TwoColConflict@master] selenium: Replace not.toExist with isExisting to make things faster

https://gerrit.wikimedia.org/r/1251052

Change #1251053 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/AdvancedSearch@master] selenium: Replace not.toExist with isExisting to make things faster

https://gerrit.wikimedia.org/r/1251053

Change #1251052 merged by jenkins-bot:

[mediawiki/extensions/TwoColConflict@master] selenium: Replace not.toExist with isExisting to make things faster

https://gerrit.wikimedia.org/r/1251052

Change #1251053 merged by jenkins-bot:

[mediawiki/extensions/AdvancedSearch@master] selenium: Replace not.toExist with isExisting to make things faster

https://gerrit.wikimedia.org/r/1251053

Change #1251030 merged by jenkins-bot:

[mediawiki/core@master] selenium: Replace not.toExist with isExisting to make things faster

https://gerrit.wikimedia.org/r/1251030