Page MenuHomePhabricator
Create Task
Maniphest T419835

Multilingual model not working (AutoModerator throwing exception on config validation): Circular dependency when creating service! GrowthExperimentsNewcomerTasksConfigurationLoader -> GrowthExperimentsNewcomerTasksConfigurationLoader
Open, HighPublic5 Estimated Story PointsPRODUCTION ERROR
Actions

Assigned To
jsn.sherman
Authored By
Kgraessle
Mar 12 2026, 12:28 PM
Tags
Referenced Files
F72985909: Screenshot 2026-03-17 at 18.47.41.png
Mar 18 2026, 1:05 AM
F72985812: Screenshot 2026-03-17 at 18.52.44.png
Mar 18 2026, 1:05 AM
F72985766: Screenshot 2026-03-17 at 18.48.01.png
Mar 18 2026, 1:05 AM
F72985686: Screenshot 2026-03-17 at 18.53.04.png
Mar 18 2026, 1:05 AM
Subscribers
A_smart_kitten
Aklapper
Ammarpad
brennen
jsn.sherman
Kgraessle
Michael
View All 11 Subscribers

Description

Steps to replicate the issue (include links if applicable):

https://logstash.wikimedia.org/app/discover#/doc/logstash-*/logstash-deploy-1-7.0.0-1-2026.03.12?id=Y6724ZwBFM-LSVmL9-rl

What happens?:
An exception is thrown.

[{reqId}] {exception_url}   Wikimedia\Services\RecursiveServiceDependencyException: Recursive service instantiation: Circular dependency when creating service! GrowthExperimentsNewcomerTasksConfigurationLoader -> GrowthExperimentsNewcomerTasksConfigurationLoader

What should have happened instead?:
No exceptions

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):
Seems to be only happening on eswiki

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
enable revertrisk-multilingual score fetchingmediawiki/extensions/AutoModeratormaster+220 -321
Remove local configuration routing and loadingmediawiki/extensions/AutoModeratorwmf/1.46.0-wmf.20+742 -2 K
Remove local configuration routing and loadingmediawiki/extensions/AutoModeratormaster+742 -2 K
Customize query in gerrit

Related Objects

Event Timeline

Kgraessle created this task.Mar 12 2026, 12:28 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 12 2026, 12:28 PM
Kgraessle triaged this task as High priority.Mar 12 2026, 12:28 PM
Kgraessle updated the task description. (Show Details)
jsn.sherman changed the task status from Open to In Progress.Mar 12 2026, 12:31 PM
jsn.sherman claimed this task.
jsn.sherman moved this task from Ready to In Progress on the Moderator-Tools-Team (Kanban) board.
Kgraessle merged a task: T419843: Wikimedia\Services\RecursiveServiceDependencyException: Recursive service instantiation: Circular dependency when creating service! GrowthExperimentsNewcomerTasksConfigurationLoader -> GrowthExperimentsNewcomerTasksConfiguratio.Mar 12 2026, 1:20 PM
A_smart_kitten mentioned this in T419846: Wikimedia\Services\RecursiveServiceDependencyException: Recursive service instantiation: Circular dependency when creating service! GrowthExperimentsNewcomerTasksConfigurationLoader -> GrowthExperimentsNewcomerTasksConfigurationLoader.Mar 12 2026, 2:29 PM
Ammarpad merged a task: T419846: Wikimedia\Services\RecursiveServiceDependencyException: Recursive service instantiation: Circular dependency when creating service! GrowthExperimentsNewcomerTasksConfigurationLoader -> GrowthExperimentsNewcomerTasksConfigurationLoader.Mar 12 2026, 2:56 PM
Ammarpad added subscribers: Ammarpad, A_smart_kitten, jsn.sherman.
A_smart_kitten updated the task description. (Show Details)Mar 12 2026, 3:17 PM
gerritbot added a comment.Mar 12 2026, 4:50 PM

Change #1251134 had a related patch set uploaded (by Jsn.sherman; author: Jsn.sherman):

[mediawiki/extensions/AutoModerator@master] WIP Remove local configuration routing and loading

https://gerrit.wikimedia.org/r/1251134

gerritbot added a project: Patch-For-Review.Mar 12 2026, 4:50 PM
Dillon renamed this task from AutoModerator is throwing an exception on config validation on eswiki to Multilingual model not working (AutoModerator throwing exception on config validation).Mar 12 2026, 5:52 PM
Dillon set the point value for this task to 5.
jsn.sherman added a comment.Mar 12 2026, 10:18 PM

I had to set this down to deal with other release tasks. I'll pick this back up tomorrow. The TL;DR is that AutoModerator was created before CC was quite done and has it's own configuration wikipage config routing and validation. I believe this is the source of the circular dependency. I'm well along the path of ripping out all of the obsolete code. I still need to finish updating the validator and tests. We should then be good to go.

Samwalton9-WMF mentioned this in T400727: set AutoModeratorMultiLingualRevertRisk with available wikis.Mar 13 2026, 8:53 AM
Samwalton9-WMF mentioned this in T405230: Announce multilingual revert risk model for Automoderator at wikis already using Automoderator.
Yahya subscribed.Mar 13 2026, 9:09 AM
Aklapper added a project: Wikimedia-production-error.Mar 17 2026, 9:07 AM
Aklapper changed the subtype of this task from "Bug Report" to "Production Error".

Please set production errors as such - thanks :)

Aklapper renamed this task from Multilingual model not working (AutoModerator throwing exception on config validation) to Multilingual model not working (AutoModerator throwing exception on config validation): Circular dependency when creating service! GrowthExperimentsNewcomerTasksConfigurationLoader -> GrowthExperimentsNewcomerTasksConfigurationLoader.Mar 17 2026, 9:07 AM
Aklapper merged a task: T419870: Wikimedia\Services\RecursiveServiceDependencyException: Recursive service instantiation: Circular dependency when creating service! GrowthExperimentsNewcomerTasksConfigurationLoader -> GrowthExperimentsNewcomerTasksConfiguratio.
Aklapper added subscribers: brennen, Michael.
Aklapper mentioned this in T420339: Wikimedia\Services\RecursiveServiceDependencyException: Recursive service instantiation: Circular dependency when creating service! GrowthExperimentsMentorManager -> GrowthExperimentsMentorProvider -> GrowthExperimentsMentorPro.Mar 17 2026, 1:09 PM
Zabe merged a task: T420339: Wikimedia\Services\RecursiveServiceDependencyException: Recursive service instantiation: Circular dependency when creating service! GrowthExperimentsMentorManager -> GrowthExperimentsMentorProvider -> GrowthExperimentsMentorPro.Mar 17 2026, 1:12 PM
Zabe subscribed.
jsn.sherman added a comment.Mar 17 2026, 1:25 PM

update: the patch for this is turning out bigger than I'd initially hoped; work is proceeding and I do anticipate getting a fix backported this week.

jsn.sherman moved this task from In Progress to Eng review on the Moderator-Tools-Team (Kanban) board.Mar 17 2026, 2:49 PM
Samwalton9-WMF mentioned this in T405152: Enable AutoModerator on Italian Wikipedia.Mar 17 2026, 4:11 PM
Kgraessle moved this task from Eng review to Reviewed (waiting for changes) on the Moderator-Tools-Team (Kanban) board.Mar 17 2026, 6:54 PM
Scardenasmolinar subscribed.Mar 18 2026, 1:05 AM

I have tested this patch locally and found that validation is broken in several fields:

  1. You can enable both models (multilingual and language-agnostic) without throwing errors:

Screenshot 2026-03-17 at 18.53.04.png (571×1 px, 119 KB)

  1. You can add non-numeric values to the multilingual threshold and numeric values lower than 0.850:

Screenshot 2026-03-17 at 18.48.01.png (729×1 px, 127 KB)

Screenshot 2026-03-17 at 18.52.44.png (712×1 px, 118 KB)

  1. You can add user rights that do not exist and add non-numeric values to user reverts per page:

Screenshot 2026-03-17 at 18.47.41.png (458×1 px, 76 KB)

Kgraessle mentioned this in T419667: Fix AutoModeratorRollbackTest.Mar 18 2026, 10:27 AM
jsn.sherman added a comment.Mar 18 2026, 2:15 PM

Ye

In T419835#11721389, @Scardenasmolinar wrote:

I have tested this patch locally and found that validation is broken in several fields:

  1. You can enable both models (multilingual and language-agnostic) without throwing errors:

Screenshot 2026-03-17 at 18.53.04.png (571×1 px, 119 KB)

  1. You can add non-numeric values to the multilingual threshold and numeric values lower than 0.850:

Screenshot 2026-03-17 at 18.48.01.png (729×1 px, 127 KB)

Screenshot 2026-03-17 at 18.52.44.png (712×1 px, 118 KB)

  1. You can add user rights that do not exist and add non-numeric values to user reverts per page:

Screenshot 2026-03-17 at 18.47.41.png (458×1 px, 76 KB)

Noting that the broken validation is for mulitlingual, but not language agnostic config.

Titore subscribed.Mar 19 2026, 10:25 AM
gerritbot added a comment.Mar 19 2026, 4:13 PM

Change #1251134 merged by jenkins-bot:

[mediawiki/extensions/AutoModerator@master] Remove local configuration routing and loading

https://gerrit.wikimedia.org/r/1251134

gerritbot added a comment.Mar 19 2026, 4:14 PM

Change #1255772 had a related patch set uploaded (by Jsn.sherman; author: Jsn.sherman):

[mediawiki/extensions/AutoModerator@wmf/1.46.0-wmf.20] Remove local configuration routing and loading

https://gerrit.wikimedia.org/r/1255772

jsn.sherman mentioned this in rEAMO4ab5caaf39d7: Remove local configuration routing and loading.Mar 19 2026, 4:14 PM
Kgraessle moved this task from Reviewed (waiting for changes) to QA on the Moderator-Tools-Team (Kanban) board.Mar 19 2026, 4:34 PM
gerritbot added a comment.Mar 19 2026, 7:16 PM

Change #1255836 had a related patch set uploaded (by Jsn.sherman; author: Jsn.sherman):

[mediawiki/extensions/AutoModerator@master] WIP: enable revertrisk-multilingual score fetching

https://gerrit.wikimedia.org/r/1255836

jsn.sherman added a comment.Mar 19 2026, 8:52 PM

We had a backport lined up for this but gerrit was down for the majority of the window, so it's just going to have to wait.

jsn.sherman moved this task from QA to In Progress on the Moderator-Tools-Team (Kanban) board.Mar 24 2026, 5:14 PM

the exception fix is rolling out on this week's train, and the multilingual enablement patch is in progress.

gerritbot added a comment.Mar 27 2026, 1:59 PM

Change #1255772 abandoned by Jsn.sherman:

[mediawiki/extensions/AutoModerator@wmf/1.46.0-wmf.20] Remove local configuration routing and loading

Reason:

intended backport window closed; this change rode the following train

https://gerrit.wikimedia.org/r/1255772

jsn.sherman moved this task from In Progress to Eng review on the Moderator-Tools-Team (Kanban) board.Mar 27 2026, 6:08 PM
Kgraessle moved this task from Eng review to Reviewed (waiting for changes) on the Moderator-Tools-Team (Kanban) board.Mar 30 2026, 10:00 AM
Scardenasmolinar changed the task status from In Progress to Stalled.Tue, Apr 21, 4:09 PM
Scardenasmolinar moved this task from Reviewed (waiting for changes) to Ready (Maintenance) on the Moderator-Tools-Team (Kanban) board.
Minorax moved this task from Untriaged to Jan–Mar 2026 on the Wikimedia-production-error board.Sun, Apr 26, 1:54 AM
Scardenasmolinar changed the task status from Stalled to Open.Thu, Apr 30, 6:22 PM
Scardenasmolinar moved this task from Ready (Maintenance) to Eng review on the Moderator-Tools-Team (Kanban) board.Sat, May 2, 3:52 AM
Kgraessle moved this task from Eng review to QA on the Moderator-Tools-Team (Kanban) board.Mon, May 4, 12:58 PM
gerritbot added a comment.Mon, May 4, 1:08 PM

Change #1255836 merged by jenkins-bot:

[mediawiki/extensions/AutoModerator@master] enable revertrisk-multilingual score fetching

https://gerrit.wikimedia.org/r/1255836

jenkins-bot mentioned this in rEAMO12f8ed090ef3: enable revertrisk-multilingual score fetching.Mon, May 4, 1:10 PM
Maintenance_bot removed a project: Patch-For-Review.Mon, May 4, 1:31 PM
ReleaseTaggerBot added a project: MW-1.47-notes (1.47.0-wmf.1; 2026-05-05).Mon, May 4, 2:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits