Page MenuHomePhabricator
Create Task
Maniphest T419836

Display user info card in PersonalDashboard Review changes feed
Closed, ResolvedPublic5 Estimated Story Points
Actions

Description

To clarify which line indicates the username of the user making a change, we can use an appropriate user icon, depending on whether the user is a registered or temporary account.

Current design:

Screenshot 2026-03-12 at 12.42.24.png (946×1 px, 123 KB)

With user icon:

Screenshot 2026-03-12 at 12.43.20.png (442×418 px, 40 KB)

Registered account icon: cdxIconUserAvatar
Temporary account icon: cdxIconUserTemporary

If the user viewing the dashboard has the user info card feature enabled, we should use it via this icon. This feature can be enabled via the "Enable the user info card" preference under Appearance.

Acceptance criteria

  • On desktop only, for users with the user info card preference enabled, the icon opens the user info card.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Display appropriate user icon and info card in Review Changesmediawiki/extensions/PersonalDashboardmaster+85 -4
Allow external modules to create user info cardsmediawiki/extensions/CheckUsermaster+494 -82
Cleanup Vitest and ESLintmediawiki/extensions/PersonalDashboardmaster+2 K -2 K
Customize query in gerrit

Related Objects
Search...

Event Timeline

Samwalton9-WMF created this task.Mar 12 2026, 12:48 PM
Restricted Application added a project: Moderator-Tools-Team. · View Herald TranscriptMar 12 2026, 12:48 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Kgraessle subscribed.EditedMar 12 2026, 4:05 PM

Just noting for temporary account icon, we'll need to update the dispatcher.js file here.

Was thinking of show ip :(

Kgraessle claimed this task.Mar 12 2026, 4:22 PM
Kgraessle triaged this task as Low priority.
Kgraessle moved this task from Inbox to Kanban on the Moderator-Tools-Team board.
Kgraessle edited projects, added Moderator-Tools-Team (Kanban); removed Moderator-Tools-Team.
Kgraessle moved this task from Ready to In Progress on the Moderator-Tools-Team (Kanban) board.
Kgraessle set the point value for this task to 2.
Dillon changed the point value for this task from 2 to 5.Mar 12 2026, 5:38 PM
Kgraessle reassigned this task from Kgraessle to Dillon.Mar 12 2026, 6:31 PM
gerritbot added a comment.Mar 13 2026, 7:00 PM

Change #1251514 had a related patch set uploaded (by Dillon; author: Dillon):

[mediawiki/extensions/CheckUser@master] Allow external modules to create user info cards

https://gerrit.wikimedia.org/r/1251514

gerritbot added a project: Patch-For-Review.Mar 13 2026, 7:00 PM
gerritbot added a comment.Mar 13 2026, 8:09 PM

Change #1251536 had a related patch set uploaded (by Dillon; author: Dillon):

[mediawiki/extensions/PersonalDashboard@master] Display appropriate user icon and info card in Review Changes

https://gerrit.wikimedia.org/r/1251536

Dillon moved this task from In Progress to Eng review on the Moderator-Tools-Team (Kanban) board.Mar 13 2026, 8:09 PM
Kgraessle moved this task from Eng review to Reviewed (waiting for changes) on the Moderator-Tools-Team (Kanban) board.Mar 16 2026, 12:56 PM
Scardenasmolinar moved this task from Reviewed (waiting for changes) to Eng review on the Moderator-Tools-Team (Kanban) board.Mar 17 2026, 3:13 AM
Scardenasmolinar subscribed.
This comment was removed by Scardenasmolinar.
Scardenasmolinar moved this task from Eng review to Reviewed (waiting for changes) on the Moderator-Tools-Team (Kanban) board.Mar 17 2026, 3:14 AM

(Of course I wrote in the wrong Phab task)

Scardenasmolinar merged a task: T419852: Increase title size of modules to 18px in PersonalDashboard.Mar 17 2026, 3:46 PM
Samwalton9-WMF moved this task from Backlog to Review Changes on the PersonalDashboard board.Mar 20 2026, 1:03 PM
Dillon updated the task description. (Show Details)Mar 23 2026, 8:05 PM
gerritbot added a comment.Mar 25 2026, 8:01 PM

Change #1259224 had a related patch set uploaded (by Jsn.sherman; author: Dillon):

[mediawiki/extensions/PersonalDashboard@master] Cleanup Vitest and ESLint

https://gerrit.wikimedia.org/r/1259224

Dillon moved this task from Reviewed (waiting for changes) to Eng review on the Moderator-Tools-Team (Kanban) board.Mar 26 2026, 3:53 PM
PatchDemoBot added a comment.Mar 30 2026, 1:28 PM

Test wiki created on Patch demo by DHardy-WMF using patch(es) linked to this task:
https://0b7b4e571a.catalyst.wmcloud.org/w/

PatchDemoBot added a comment.Mar 30 2026, 1:41 PM

Test wiki on Patch demo by DHardy-WMF using patch(es) linked to this task was deleted:

https://0b7b4e571a.catalyst.wmcloud.org/w/

PatchDemoBot added a comment.Mar 30 2026, 1:44 PM

Test wiki created on Patch demo by DHardy-WMF using patch(es) linked to this task:
https://2ec5b8c56c.catalyst.wmcloud.org/w/

Dillon moved this task from Eng review to Reviewed (waiting for changes) on the Moderator-Tools-Team (Kanban) board.Mar 30 2026, 3:04 PM
Dillon moved this task from Reviewed (waiting for changes) to Eng review on the Moderator-Tools-Team (Kanban) board.Mar 30 2026, 4:42 PM
Kgraessle moved this task from Eng review to Reviewed (waiting for changes) on the Moderator-Tools-Team (Kanban) board.Apr 6 2026, 1:03 PM
Dillon moved this task from Reviewed (waiting for changes) to Eng review on the Moderator-Tools-Team (Kanban) board.Apr 6 2026, 4:23 PM
Kgraessle moved this task from Eng review to Reviewed (waiting for changes) on the Moderator-Tools-Team (Kanban) board.Apr 8 2026, 9:19 AM
Samwalton9-WMF added a parent task: T422599: WE1.11: Improve Review Changes.Apr 8 2026, 10:46 AM
Dillon moved this task from Reviewed (waiting for changes) to Eng review on the Moderator-Tools-Team (Kanban) board.Apr 10 2026, 8:19 PM
gerritbot added a comment.Mon, Apr 13, 9:37 AM

Change #1259224 merged by jenkins-bot:

[mediawiki/extensions/PersonalDashboard@master] Cleanup Vitest and ESLint

https://gerrit.wikimedia.org/r/1259224

PatchDemoBot added a comment.Mon, Apr 13, 9:38 AM

Test wiki created on Patch demo by KGraessle-WMF using patch(es) linked to this task:
https://f25ca44561.catalyst.wmcloud.org/w/

Samwalton9-WMF added a comment.Mon, Apr 13, 9:40 AM

We have one addendum to change the scope of this ticket - the user icon should be displayed on mobile, but the user info card should not be something that can open on mobile, to focus the small screen space on interacting with the diff / reduce accidental clicks on the icon. No changes for desktop.

Samwalton9-WMF updated the task description. (Show Details)Mon, Apr 13, 9:40 AM
Samwalton9-WMF renamed this task from Display appropriate user icon and use user info card in PersonalDashboard Review changes feed to Display user info card in PersonalDashboard Review changes feed.Mon, Apr 13, 2:52 PM
Samwalton9-WMF updated the task description. (Show Details)
Samwalton9-WMF mentioned this in T423145: Add non-interactible user icons for users not using User Info Card in PersonalDashboard Review Changes.Mon, Apr 13, 2:57 PM
Samwalton9-WMF added a comment.Mon, Apr 13, 4:31 PM

Adjusted scope to focus on UIC integration, filed T423145 for the non-UIC iconography.

Dillon added a comment.Mon, Apr 13, 7:54 PM
In T419836#11813521, @Samwalton9-WMF wrote:

We have one addendum to change the scope of this ticket - the user icon should be displayed on mobile, but the user info card should not be something that can open on mobile, to focus the small screen space on interacting with the diff / reduce accidental clicks on the icon. No changes for desktop.

I have uploaded a new patchset to disable the user info card on mobile. As of now, that means no icon will be shown on those devices. We can implement a non-clickable icon in a separate patch for T423145, as it requires additional code in PersonalDashboard.

Samwalton9-WMF added subscribers: kostajh, Dreamy_Jazz.Tue, Apr 14, 3:07 PM

@kostajh @Dreamy_Jazz Just a quick heads up that the CheckUser patch is ready for review again :)

Dillon moved this task from Eng review to Reviewed (waiting for changes) on the Moderator-Tools-Team (Kanban) board.Thu, Apr 16, 2:19 PM
Dillon moved this task from Reviewed (waiting for changes) to Eng review on the Moderator-Tools-Team (Kanban) board.Thu, Apr 16, 3:25 PM
Samwalton9-WMF edited parent tasks, added: T409059: WE1.11.1: Improve Review Changes module / Surface noteworthy edits; removed: T422599: WE1.11: Improve Review Changes.Tue, Apr 21, 1:25 PM
Dillon added a comment.Tue, Apr 21, 4:02 PM

@kostajh @Dreamy_Jazz I uploaded a new patchset to address the latest comments. Ready for review: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CheckUser/+/1251514

Dreamy_Jazz added a comment.Tue, Apr 21, 9:29 PM

Thanks for the reminder ping, +2'd

Dreamy_Jazz added a comment.Tue, Apr 21, 10:08 PM

CheckUser CI is blocked, which is tracked by T424106 (so this can't merge until that is fixed)

gerritbot added a comment.Wed, Apr 22, 9:19 AM

Change #1251514 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Allow external modules to create user info cards

https://gerrit.wikimedia.org/r/1251514

Scardenasmolinar moved this task from Eng review to QA on the Moderator-Tools-Team (Kanban) board.Fri, Apr 24, 1:16 AM
gerritbot added a comment.Fri, Apr 24, 1:19 AM

Change #1251536 merged by jenkins-bot:

[mediawiki/extensions/PersonalDashboard@master] Display appropriate user icon and info card in Review Changes

https://gerrit.wikimedia.org/r/1251536

Maintenance_bot removed a project: Patch-For-Review.Fri, Apr 24, 1:30 AM
ReleaseTaggerBot added a project: MW-1.46-notes (1.46.0-wmf.26; 2026-04-28).Fri, Apr 24, 2:00 AM
PatchDemoBot added a comment.Fri, Apr 24, 4:23 PM

Test wiki on Patch demo by DHardy-WMF using patch(es) linked to this task was deleted:

https://2ec5b8c56c.catalyst.wmcloud.org/w/

jsn.sherman closed this task as Resolved.Wed, Apr 29, 6:24 PM
jsn.sherman moved this task from QA to Done on the Moderator-Tools-Team (Kanban) board.
jsn.sherman subscribed.

verified on testwiki

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits