Page MenuHomePhabricator

Duplicated ToC in Vector 2022
Closed, ResolvedPublicBUG REPORT

Description

image.png (1×2 px, 468 KB)

Steps to replicate the issue (include links if applicable):

What happens?:

There's an inline ToC in addition to the standard one displayed in the left menu

What should have happened instead?:

The inline ToC shouldn't be displaying

Event Timeline

FYI, I've hot-fixed this on plwiki through MediaWiki:Vector-2022.css. If reproducing, use safemode or disable this style in browser console.

It seems to be correlated with FlaggedRevs... – I see this bug on plwiki, dewiki, ruwiki, ruwiktionary, but not enwiki, eswiki and frwiki

A couple of recent changes to flagged revs this week: https://gerrit.wikimedia.org/r/q/project:mediawiki/extensions/FlaggedRevs+status:merged+owner:ihurbainpalatin@wikimedia.org

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/FlaggedRevs/+/1244744/6/includes/backend/FlaggedRevs.php fixed a bug where flagged revs stored both the legacy and parsoid output in the same parser cache.

But this bug seems to affect both parsoid and legacy.

Appears on German Wikipedia as well, confirming that it seems to affect FlaggedRevs: https://de.wikipedia.org/wiki/Kulturgeschichte?safemode=1 for both legacy and parsoid.

This issue also appears on the Arabic Wikipedia and seems to affect all articles.

For now, I will temporarily hide the inline ToC on Arabic Wikipedia until there is an update on this task.

Source of bug described in a comment on https://gerrit.wikimedia.org/r/c/mediawiki/extensions/FlaggedRevs/+/1239378

briefly, the patch switched from using OutputPage::addParserOutput() to running the pipeline directly, and we didn't notice that hidden inside ::addParserOutput()'s call to ::getParserOutputText() is an initialization of default values for the postprocessing options, including injectTOC.

Reports of duplicated ToC appeared again on plwiki. This time, the additional ToC disappears after purging (which suggests an intermittent issue), but the affected pages were parsed well after deploying a fix for this task.

I have reported that as a separate task: T422590: Pages sometimes parsed with seemingly mobile output format

Same on dewiki – multiple users reported the issue mentioned in T421629 (and another issue which seems similar to T420085) – both of these issues could be solved by purging the affected pages but that led to Vector2022 suddenly showing the duplicated TOC. Purging the page a second time seems to solve that issue but sometimes led to the other issues reoccurring.