Page MenuHomePhabricator

Remove the `vform` HTMLForm display format
Closed, ResolvedPublic

Description

Background

T408126 deprecated VForm support from HTMLForm. Remaining HTMLForm display handling related to VForm is unused and can be removed as follow-up cleanup.

Goal

Remove the leftover VForm-related display format code from HTMLForm.

Acceptance Criteria for done

  • vform display format is removed from HTMLForm.

Event Timeline

Wikibase calls getVform in 'repo/includes/Specials/HTMLForm/HTMLAliasesField.php'.

GoogleLogin and an extension called XenForoAuth both use target vform still. Everything else is neglible, even a few outdated skins with vform class selectors.

Change #1251210 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/core@master] HTMLForm: Remove the 'vform' display format

https://gerrit.wikimedia.org/r/1251210

Change #1251302 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/Wikibase@master] HTMLForm: Remove override for deprecated getVForm()

https://gerrit.wikimedia.org/r/1251302

GoogleLogin and an extension called XenForoAuth both use target vform still.

They probably did that to match the normal login form, which used vform until https://gerrit.wikimedia.org/r/c/mediawiki/core/+/919361 (MW 1.41), and will probably be updated to use codex on newer MediaWiki versions one day.

Change #1251302 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] HTMLForm: Remove override for deprecated getVForm()

https://gerrit.wikimedia.org/r/1251302

Change #1251210 merged by jenkins-bot:

[mediawiki/core@master] HTMLForm: Remove the 'vform' display format

https://gerrit.wikimedia.org/r/1251210