In cases where a block already exists on a connected temporary account, do nothing instead

But if this is only a temporary block then an indefinite one would still be useful. And also we need to handle partial blocks.

Change #1254219 had a related patch set uploaded (by STran; author: STran):

[mediawiki/core@master] Allow extensions to make additional blocks through ApiBlock

https://gerrit.wikimedia.org/r/1254219

Change #1254220 had a related patch set uploaded (by STran; author: STran):

[mediawiki/extensions/CheckUser@master] Support blocking all connected temporary accounts on Special:Block

https://gerrit.wikimedia.org/r/1254220

Change #1254219 merged by jenkins-bot:

[mediawiki/core@master] Allow extensions to make additional blocks through ApiBlock

https://gerrit.wikimedia.org/r/1254219

Change #1254220 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Support blocking all connected temporary accounts on Special:Block

https://gerrit.wikimedia.org/r/1254220

Change #1262095 had a related patch set uploaded (by STran; author: STran):

[mediawiki/extensions/CheckUser@master] Don't try to get connected accounts in invalid cases

https://gerrit.wikimedia.org/r/1262095

Change #1262095 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Don't try to get connected accounts in invalid cases

https://gerrit.wikimedia.org/r/1262095

I tested blocking various temporary accounts and checking blocks are created against all the associated temp accounts listed in Special:Block and that log entries are created in the block log and IP Reveal log (the latter stating <admin> viewed related temporary accounts for <temp user>).

I cannot use the feature if the target temp account has more than 15 associated temp accounts. Instead, there is a yellow warning stating There are too many associated temporary accounts to add to this block. We only allow up to 15 accounts to be blocked at one time.

I checked that autoblock gets created, but just for the original target temp account.

Identical blocks are not created, instead I see a warning after submit:

Did some regression testing that blocks against registered users, IPs and ranges can be created.

I briefly tested different skins, on a mobile (iPhone) and RTL.

I checked that an appropriate log was created when using the blockConnectedTempAccounts parameter via the API.

I checked that an admin user who had not enabled their "Temporary account IP reveal" option could not see this feature. Nor could they use the blockConnectedTempAccounts parameter via the API.

I did not test that what is returned by /w/rest.php/checkuser/v0/connectedtemporaryaccounts/<temp acct> is correct.

I did my testing mostly on testwiki.

Some questions @STran:

• The Watch the target's user page and talk page checkbox only watches the original target user's talk page, not the talk pages of any associated temp users.
• I am unclear whether the blockConnectedTempAccounts parameter should be a boolean or a string. Special:ApiSandbox suggests it is a boolean but we set it to a string when we make the API request in Special:Block. The value of the string does not seem to affect which temp accounts get blocked. Perhaps this is OK.
• There are some items from the AC which we have not completely done, but I assume it is OK.

• Option needs to be able to list all the connected temporary accounts and the block states of them (blocked or not)

We list the temp accounts, but not their current blocked status.

• In cases where a block already exists on a connected temporary account, do nothing instead

As stated above, this is only the case if the block you are creating is an exact duplicate of an existing one. It is possible to create multiple blocks against the same group of temp users. I don't think this is a problem.

In T419949#11803806, @dom_walden wrote:

I cannot use the feature if the target temp account has more than 15 associated temp accounts. Instead, there is a yellow warning stating There are too many associated temporary accounts to add to this block. We only allow up to 15 accounts to be blocked at one time.

This has recently been broad up on dewiki's admin chat. I believe it's ok to only allow blocking a certain number of TA, there's not much value in blocking old TA anyway. But if the number of connected TA exceeds this limit, ideally instead of just showing this warning the 15 most recent TA should get blocked.