Page MenuHomePhabricator
Create Task
Maniphest T420021

standard calls to Z828 fail
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

What happens?:
Odd error:

Error type: Key not found
Error data:
object: "9"
Unlabelled: "K"
Unlabelled: "1"

What should have happened instead?:
The Type object should have been fetched.

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):
The call seems to work if the quoted reference is constructed by the function with that label, although only the English texts are returned (as with v1)

This approach fails for validator functions like Z101 but succeeds for other built-ins like Z801. Note that retrieving based on a quoted reference returns labels in languages other than English but presents the literal “Z24” as the value for the Z2K1 (Sorry, I thought this was failing).

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
wikifunctions: Upgrade orchestrator from 2026-03-12-210521 to 2026-03-18-023444operations/deployment-chartsmaster+1 -1
Customize query in gerrit
Related Changes in GitLab:
TitleReferenceAuthorSource BranchDest Branch
Address error cases for Z828.repos/abstract-wiki/wikifunctions/function-orchestrator!595apineapine-z828main
Customize query in GitLab

Related Objects
Search...

Event Timeline

GrounderUK created this task.Mar 13 2026, 4:24 PM
GrounderUK renamed this task from standard called to Z828 fail to standard calls to Z828 fail.Mar 13 2026, 10:33 PM
cmassaro claimed this task.Tue, Mar 17, 12:34 AM
CodeReviewBot added a project: Patch-For-Review.Tue, Mar 17, 12:34 AM

apine opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/595

Address error cases for Z828.

cmassaro moved this task from Incoming to In Code review on the Abstract Wikipedia team (26Q3 (Jan–Mar)) board.Tue, Mar 17, 12:48 AM
CodeReviewBot added a comment.Tue, Mar 17, 1:26 AM

jforrester merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/595

Address error cases for Z828.

Jdforrester-WMF triaged this task as Medium priority.Tue, Mar 17, 1:27 AM
Jdforrester-WMF moved this task from In Code review to Ready to deploy on the Abstract Wikipedia team (26Q3 (Jan–Mar)) board.
Maintenance_bot removed a project: Patch-For-Review.Tue, Mar 17, 1:35 AM
gerritbot added a comment.Wed, Mar 18, 1:50 PM

Change #1254929 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from 2026-03-12-210521 to 2026-03-18-023444

https://gerrit.wikimedia.org/r/1254929

gerritbot added a project: Patch-For-Review.Wed, Mar 18, 1:50 PM
gerritbot added a comment.Wed, Mar 18, 2:12 PM

Change #1254929 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from 2026-03-12-210521 to 2026-03-18-023444

https://gerrit.wikimedia.org/r/1254929

Maintenance_bot removed a project: Patch-For-Review.Wed, Mar 18, 2:33 PM
cmassaro moved this task from Ready to deploy to Needs Sign-off on the Abstract Wikipedia team (26Q3 (Jan–Mar)) board.Wed, Mar 18, 2:39 PM
cmassaro added a comment.Wed, Mar 18, 2:58 PM

I am really baffled here. These seem to fail in prod still, but the same calls succeed when I run locally.

Jdforrester-WMF added a comment.Wed, Mar 18, 3:17 PM

I think this is fixed in the prod orchestrator, but calls to it have been cached at the MediaWiki end?

curl https://wikifunctions.k8s-staging.discovery.wmnet:30443/1/v2/evaluate/ -X POST --data '{"zobject":{"Z1K1":"Z7","Z7K1":"Z828","Z828K1":{"Z1K1":"Z99","Z99K1":{"Z1K1":"Z9","Z9K1":"Z4"}}},"doValidate":false}' --header "Content-type: application/json" -w "\n" | jq .Z22K1

-> a copy of Z4.

Thus this should clear itself up over the next few hours and days. Is that a good enough fix?

cmassaro added a comment.Sun, Mar 22, 4:38 PM

Yeah, I think so. Let's check again when we re-enable v2.

In T420021#11723584, @Jdforrester-WMF wrote:

I think this is fixed in the prod orchestrator, but calls to it have been cached at the MediaWiki end?

curl https://wikifunctions.k8s-staging.discovery.wmnet:30443/1/v2/evaluate/ -X POST --data '{"zobject":{"Z1K1":"Z7","Z7K1":"Z828","Z828K1":{"Z1K1":"Z99","Z99K1":{"Z1K1":"Z9","Z9K1":"Z4"}}},"doValidate":false}' --header "Content-type: application/json" -w "\n" | jq .Z22K1

-> a copy of Z4.

Thus this should clear itself up over the next few hours and days. Is that a good enough fix?

DSantamaria changed the task status from Open to In Progress.Mon, Mar 23, 10:15 AM
Jdforrester-WMF closed this task as Resolved.Mon, Mar 23, 1:39 PM
gerritbot added a comment.Wed, Mar 25, 2:25 PM

Change #1260705 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] check-wf-services: Add a test case from T420021

https://gerrit.wikimedia.org/r/1260705

gerritbot added a project: Patch-For-Review.Wed, Mar 25, 2:25 PM
gerritbot added a comment.Wed, Mar 25, 2:45 PM

Change #1260705 merged by jenkins-bot:

[operations/deployment-charts@master] check-wf-services: Add a test case from T420021

https://gerrit.wikimedia.org/r/1260705

Maintenance_bot removed a project: Patch-For-Review.Wed, Mar 25, 3:31 PM
GrounderUK reopened this task as In Progress.Tue, Mar 31, 1:38 PM

Still failing from Wikifunctions.org but the error is now rendered:

Errors
Key not found (key: "Z9K1")
Error type: Key not found
Error data:
key: "Z9K1"

cmassaro moved this task from Needs Sign-off to Ready to deploy on the Abstract Wikipedia team (26Q3 (Jan–Mar)) board.Tue, Mar 31, 3:36 PM

I think this will get properly fixed during the next deployment; we'll see.

cmassaro added a comment.Tue, Mar 31, 3:36 PM

(it works in my local env, at least)

GrounderUK added a comment.Tue, Mar 31, 4:21 PM
In T420021#11773726, @cmassaro wrote:

(it works in my local env, at least)

It’s a start 😎 It may have something to do with how the quoted reference is realised from the UI. As in the original report, quoted references constructed as ZObjects work; it’s just the “standard” ones that fail.

Jdforrester-WMF closed this task as Resolved.Wed, Apr 1, 2:38 PM
Jdforrester-WMF moved this task from Ready to deploy to Needs Sign-off on the Abstract Wikipedia team (26Q3 (Jan–Mar)) board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits