Page MenuHomePhabricator

[MEX] [BUG] globe-coordinates: full-screening map preview in edit mode breaks all interactivity
Closed, ResolvedPublic

Description

steps to reproduce

  • add or edit a globe-coordinates statement
  • click in the text input to open the map preview
  • double click the map or click the full-screen button in the upper right corner of the map
    image.png (377×592 px, 200 KB)
  • the cursor turns into a hand. no buttons or inputs are interactive anymore

more info about what's happening

This does open the full-screen map, but it is behind the edit modal. The cursor is interacting with this map, rather than the UI you can see.
It is possible to escape this state by clicking in the upper right corner, where the close button is on the map element. You can identify this (at least on desktop), by seeing where the cursor changes.

image.png (205×672 px, 16 KB)

Related Objects

StatusSubtypeAssignedTask
OpenNone
ResolvedkarapayneWMDE
ResolvedkarapayneWMDE
ResolvedkarapayneWMDE
ResolvedArian_Bozorg
ResolvedkarapayneWMDE
ResolvedkarapayneWMDE
ResolvedArian_Bozorg
Resolvedmahmoud.abdelsattar.wmde
Resolvedmahmoud.abdelsattar.wmde
ResolvedArian_Bozorg
ResolvedNone
ResolvedArian_Bozorg
ResolvedkarapayneWMDE
ResolvedkarapayneWMDE
ResolvedkarapayneWMDE
OpenNone
ResolvedkarapayneWMDE
ResolvedkarapayneWMDE
ResolvedBUG REPORTkarapayneWMDE
ResolvedNone
ResolvedkarapayneWMDE
ResolvedkarapayneWMDE
ResolvedArian_Bozorg
ResolvedArthurTaylor
ResolvedkarapayneWMDE
ResolvedkarapayneWMDE
Resolvedmahmoud.abdelsattar.wmde
ResolvedkarapayneWMDE
OpenkarapayneWMDE
DuplicateNone
ResolvedArian_Bozorg
ResolvedkarapayneWMDE
Resolveddcausse
ResolvedArian_Bozorg
ResolvedkarapayneWMDE
OpenNone
Resolvedmahmoud.abdelsattar.wmde
DeclinedNone

Event Timeline

Task Time: There remains an open question of do we want to have full-screen map on mobile? LOE to remove it is potentially similar to fixing the functionality of the full-screen map (but probably fixing the functionality is easier) and UX opinion is that the functionality would be useful for users.

@Alice.moutinho - please add a design for the fullscreen

Dev note: if I add z-index: 450 to the .oo-ui-windowManager-modal > .oo-ui-dialog styles, then the fullscreen map shows up on top of our UI correctly, rather than below it.

Change #1260678 had a related patch set uploaded (by Arthur taylor; author: Arthur taylor):

[mediawiki/extensions/Wikibase@master] Make ooui modal appear over mw-teleport-target for fullscreen map

https://gerrit.wikimedia.org/r/1260678

Change #1260678 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Make ooui modal appear over mw-teleport-target for fullscreen map

https://gerrit.wikimedia.org/r/1260678