Page MenuHomePhabricator

h2 headers with minerva are broken in hewiki
Closed, ResolvedPublic1 Estimated Story PointsBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

What happens?:

  • The edit buttons collapse into the the title.
  • Notes: I don't observe the issue on H3 level headers. Not able to reproduce it in enwiki (LTR wiki) and urwiki (RTL wiki)

image.png (160×742 px, 14 KB)

It seems to come from this CSS https://he.wikipedia.org/w/load.php?debug=2&lang=he&modules=mobile.init.styles&only=styles&skin=minerva&version=ztntf which seems to exists also in uriwki:

.client-js body:not( .mf-collapsible-sections ):not( .mf-collapsible-sections-disabled ) .mw-parser-output[data-mw-parsoid-version] > section > .mw-heading:not( .mf-collapsible-heading ),
.client-js body.mf-collapsible-sections .mw-parser-output[data-mw-parsoid-version] > section > .mw-heading:not( .mf-collapsible-heading )::before {
  content: '';
  display: block;
  width: 16px;
  height: 16px;
  margin-left: 6px;
}

What should have happened instead?:

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Event Timeline

Change #1256562 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/MobileFrontend@master] Drop not selector for section headings causing display issues on hewiki

https://gerrit.wikimedia.org/r/1256562

Jdlrobson-WMF added a subscriber: SherryYang-WMF.

@SherryYang-WMF please prioritize for next sprint. This is thankfully just cleanup from a previous task the team worked on.. so hopefully a small ask.

Change #1256562 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] Address FIXME and drop not selector for section headings

https://gerrit.wikimedia.org/r/1256562

The :not selectors weren't properly scoped to mobile pages, which caused issues on desktop Minerva (forced via ?useskin=minerva&useformat=desktop url params). The problem is that body:not( .mf-collapsible-sections ):not( .mf-collapsible-sections-disabled ) matches any body without these classes, including desktop pages. This caused headings to collapse to 16x16px and content to overlap on desktop Minerva.

Minverva mobileMinerva desktop
H2 section headings minerva mobile.png (848×695 px, 67 KB)
H2 section headings minerva desktop.png (842×701 px, 76 KB)

The mw-mf body class scopes styles to mobile pages:

body.mw-mf:not( .mf-collapsible-sections ):not( .mf-collapsible-sections-disabled )

Change #1259147 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/MobileFrontend@wmf/1.46.0-wmf.20] Address FIXME and drop not selector for section headings

https://gerrit.wikimedia.org/r/1259147

Jdlrobson-WMF claimed this task.

Thanks @lwatson ! Will try to backport this earlier in the week.

Change #1259147 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@wmf/1.46.0-wmf.20] Address FIXME and drop not selector for section headings

https://gerrit.wikimedia.org/r/1259147

Mentioned in SAL (#wikimedia-operations) [2026-03-24T21:38:52Z] <jdlrobson@deploy2002> Started scap sync-world: Backport for [[gerrit:1259147|Address FIXME and drop not selector for section headings (T420085)]]

Mentioned in SAL (#wikimedia-operations) [2026-03-24T21:44:14Z] <jdlrobson@deploy2002> jdlrobson: Backport for [[gerrit:1259147|Address FIXME and drop not selector for section headings (T420085)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Mentioned in SAL (#wikimedia-operations) [2026-03-24T21:52:03Z] <jdlrobson@deploy2002> Finished scap sync-world: Backport for [[gerrit:1259147|Address FIXME and drop not selector for section headings (T420085)]] (duration: 13m 11s)