Page MenuHomePhabricator

Add mw-redirect css to Special:EditWatchlist
Open, Needs TriagePublicBUG REPORT

Description

Hi. When moving to a table, a css

.mw-redirect {
    font-style: italic;
}

was lost.

  1. Open Special:EditWatchlist.
  2. Find an entry for a redirect.
  3. Expected: italic link text.
  4. Got: plain link text.

For example, this page:

Screenshot_20260314_140052_Samsung Internet.png (1,920×521 px, 110 KB)

Thank you.

Details

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Thank you for tagging this task with good first task for Wikimedia newcomers!

Newcomers often may not be aware of things that may seem obvious to seasoned contributors, so please take a moment to reflect on how this task might look to somebody who has never contributed to Wikimedia projects.

A good first task is a self-contained, non-controversial task with a clear approach. It should be well-described with pointers to help a completely new contributor, for example it should clearly point to the codebase URL and provide clear steps to help a contributor get set up for success. We've included some guidelines at https://phabricator.wikimedia.org/tag/good_first_task/ !

Thank you for helping us drive new contributions to our projects <3

Hi, I’ll start working on this task now. I’ll investigate the issue with mw-redirect styling in Special:EditWatchlist and update here with my findings.

Hi, I’ve submitted a patch for this task:

https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1255720

Looking forward to your feedback. Thanks!

Hi, I’ve submitted a patch for this task:

https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1255720

Looking forward to your feedback. Thanks!

Could you provide a Patch Demo, please?

Hi, here is the patch demo:

After applying the fix, redirect links in Special:EditWatchlist are now styled correctly using the mw-redirect class (italic text).

As shown in the attached screenshot, the highlighted redirect entry appears in italic, confirming the expected behavior.

midiawiki-updated-style.png (1,982×544 px, 775 KB)

Hi, here is the patch demo:

Looks like you've missed the link.

Rather looks like not every person has to know what "Patch Demo" implies in Wikimedia slang

Yes, but in this case they could ask, I thought. But maybe you're right. Shreyansh123, if you do not know what it is, I could do it for you in a second if you allow me, or explain you what to do.

Hi! Thanks for your response.

I’m not fully familiar with what “Patch Demo” means in this context.
Could you please explain what exactly is expected? I’d like to learn and do it myself.

Thanks!

Sorry, I missed it earlier.

Hi! Thanks for your response.

I’m not fully familiar with what “Patch Demo” means in this context.
Could you please explain what exactly is expected? I’d like to learn and do it myself.

Thanks!

Patch demo is a Wikitech:Catalyst site at https://patchdemo.wmcloud.org/. You log in, create a new wiki with your patch, open this wiki, add a couple of pages, including redirects, to the watchlist, to be sure your change works.

Change #1255720 had a related patch set uploaded (by Neriah; author: Shreyansh):

[mediawiki/core@master] Fix mw-redirect styling in Special:EditWatchlist

https://gerrit.wikimedia.org/r/1255720