Page MenuHomePhabricator

User email confirmation monthly email reminder: Add username into the email to provide context
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  1. I see an email come in saying my account is not confirmed
  2. The email lacks an indication of what account this email is related to

What happens?:
If I click the confirmation link, I could confirm an account I don't own

What should have happened instead?:
If the email had the username, I could confirm whether that is my account before confirming the email

Event Timeline

Johannnes89 removed BucheonFac as the assignee of this task.
Johannnes89 edited subscribers, added: Ladsgroup, Aklapper, Dreamy_Jazz; removed: BucheonFac.

Change #1259212 had a related patch set uploaded (by Ladsgroup; author: Ladsgroup):

[mediawiki/extensions/Echo@master] EchoVerifyEmailReminder: Add username to provide context

https://gerrit.wikimedia.org/r/1259212

It scared a friend of mine too who thought his account is getting compromised (cc @Darafsh) so I decided to make the patch for it myself :D

Change #1259212 merged by jenkins-bot:

[mediawiki/extensions/Echo@master] EchoVerifyEmailReminder: Add username to provide context

https://gerrit.wikimedia.org/r/1259212

Dreamy_Jazz claimed this task.

AFAICS this should be sorted? Tentatively resolving