Page MenuHomePhabricator
Create Task
Maniphest T420118

Expand test coverage for CentralAuth maintenance scripts
Open, Needs TriagePublic
Actions

Description

Summary

Code coverage reports show only 7% test coverage for MediaWiki-extensions-CentralAuth maintenance scripts. This can be improved

Acceptance criteria

  • The test coverage at this page is a number higher than 7%

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Create tests for RecalculateGlobalEditCount.phpmediawiki/extensions/CentralAuthmaster+116 -0
Test populateHomeDB.phpmediawiki/extensions/CentralAuthmaster+122 -0
Test emptyGlobalUserGroup.phpmediawiki/extensions/CentralAuthmaster+85 -0
Test LockUser.phpmediawiki/extensions/CentralAuthmaster+145 -0
UserGroupAssignmentService: Make strtotime relative to any fake timemediawiki/coremaster+18 -1
Test addToGlobalGroup.phpmediawiki/extensions/CentralAuthmaster+165 -0
Customize query in gerrit

Event Timeline

Dreamy_Jazz created this task.Mar 14 2026, 5:51 PM
Restricted Application added a project: MediaWiki-Platform-Team. · View Herald TranscriptMar 14 2026, 5:51 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Dreamy_Jazz added a project: Test-Coverage.Mar 14 2026, 5:53 PM
Dreamy_Jazz moved this task from Proposed Projects to Tinkering in Progress on the Hackathon-Northwestern-Europe-2026 board.Mar 14 2026, 6:17 PM
pmiazga subscribed.Mar 17 2026, 3:41 PM

@Dreamy_Jazz do you have any progress on this matter? Like, even a jump to 10-15% would be useful.

pmiazga moved this task from Inbox, needs triage to Needs refinement on the MediaWiki-Platform-Team board.Mar 17 2026, 3:41 PM
Dreamy_Jazz added a comment.Mar 17 2026, 4:10 PM

I do have some local changes from the Hackathon, I'll upload these soon

gerritbot added a comment.Mar 23 2026, 10:55 AM

Change #1259015 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/core@master] UserGroupAssignmentService: Make strtotime relative to any fake time

https://gerrit.wikimedia.org/r/1259015

gerritbot added a project: Patch-For-Review.Mar 23 2026, 10:55 AM
gerritbot added a comment.Mar 23 2026, 11:29 AM

Change #1259034 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CentralAuth@master] Test addToGlobalGroup.php

https://gerrit.wikimedia.org/r/1259034

gerritbot added a comment.Mar 23 2026, 8:33 PM

Change #1259015 merged by jenkins-bot:

[mediawiki/core@master] UserGroupAssignmentService: Make strtotime relative to any fake time

https://gerrit.wikimedia.org/r/1259015

gerritbot added a comment.Mar 23 2026, 8:33 PM

Change #1259034 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] Test addToGlobalGroup.php

https://gerrit.wikimedia.org/r/1259034

ReleaseTaggerBot added a project: MW-1.46-notes (1.46.0-wmf.21; 2026-03-24).Mar 23 2026, 9:00 PM
Maintenance_bot removed a project: Patch-For-Review.Mar 23 2026, 9:31 PM
gerritbot added a comment.Apr 13 2026, 9:50 AM

Change #1270373 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CentralAuth@master] Create tests for the LockUser.php maintenance script

https://gerrit.wikimedia.org/r/1270373

gerritbot added a project: Patch-For-Review.Apr 13 2026, 9:50 AM
gerritbot added a comment.Apr 13 2026, 10:29 AM

Change #1270381 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CentralAuth@master] Test emptyGlobalUserGroup.php

https://gerrit.wikimedia.org/r/1270381

gerritbot added a comment.Apr 13 2026, 3:10 PM

Change #1270373 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] Test LockUser.php

https://gerrit.wikimedia.org/r/1270373

gerritbot added a comment.Apr 13 2026, 3:10 PM

Change #1270381 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] Test emptyGlobalUserGroup.php

https://gerrit.wikimedia.org/r/1270381

Maintenance_bot removed a project: Patch-For-Review.Apr 13 2026, 3:32 PM
ReleaseTaggerBot edited projects, added: MW-1.46-notes (1.46.0-wmf.24; 2026-04-14); removed: MW-1.46-notes (1.46.0-wmf.21; 2026-03-24).Apr 13 2026, 4:00 PM
Dreamy_Jazz added a project: Wikimedia-Hackathon-2026.May 1 2026, 8:18 AM
Aklapper moved this task from Backlog to Proposed Projects on the Wikimedia-Hackathon-2026 board.May 1 2026, 10:06 AM
gerritbot added a comment.May 1 2026, 7:07 PM

Change #1281604 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CentralAuth@master] Test populateHomeDB.php

https://gerrit.wikimedia.org/r/1281604

gerritbot added a project: Patch-For-Review.May 1 2026, 7:07 PM
gerritbot added a comment.May 1 2026, 11:12 PM

Change #1281604 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] Test populateHomeDB.php

https://gerrit.wikimedia.org/r/1281604

Maintenance_bot removed a project: Patch-For-Review.May 1 2026, 11:30 PM
ReleaseTaggerBot added a project: MW-1.47-notes (1.47.0-wmf.1; 2026-05-05).May 2 2026, 12:00 AM
gerritbot added a comment.May 2 2026, 10:57 AM

Change #1281745 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CentralAuth@master] Create tests for RecalculateGlobalEditCount.php

https://gerrit.wikimedia.org/r/1281745

gerritbot added a project: Patch-For-Review.May 2 2026, 10:57 AM
gerritbot added a comment.May 2 2026, 9:26 PM

Change #1281745 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] Create tests for RecalculateGlobalEditCount.php

https://gerrit.wikimedia.org/r/1281745

Maintenance_bot removed a project: Patch-For-Review.May 2 2026, 9:31 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits