Page MenuHomePhabricator

MW Feedback link points locally at Dewiki and to the wrong namespace elsewhere
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT

Description

Steps to replicate the issue:

What happens?:

  • At Dewiki it points locally

image.png (568×1 px, 123 KB)

  • At (all?) other wikis it points to the right wiki, but without the Talk: prefix. (confirmed at En/Fr/Sw/Es)

image.png (1×1 px, 254 KB)

What should have happened instead?:
At all wikis it should link to https://www.mediawiki.org/wiki/Talk:VisualEditor/Suggestion_Mode/Feedback

Original bug-report:
https://www.mediawiki.org/wiki/Talk:VisualEditor/Suggestion_Mode/Feedback#MediaWiki:Visualeditor-suggestionfeedback-link_broken_on_dewiki%3F:

When opening the feedback flow implemented in phab:T415936 on German Wikipedia and selecting "report a problem", the link "VisualEditor/Suggestion Mode/Feedback" leads to de:Diskussion:VisualEditor/Suggestion Mode/Feedback. There's no issue with the link on other projects (I checked enwiki and eswiki) and there doesn't seem to be a local override causing the issue, [i.e.] de:MediaWiki:Visualeditor-suggestionfeedback-link is identical to other projects.

Event Timeline

That appears to be because dewiki is one of the few that's not set up to consolidate VE feedback onto mw.org:

// Whether VisualEditor's feedback page should be consolidated down to just the
// single page on MediaWiki.org
'wmgVisualEditorConsolidateFeedback' => [
	'default' => true,
	'mediawikiwiki' => false, // This is the consolidation point
	'dewiki' => false, // Retaining for local conversations
	'zh_yuewiki' => false, // Retaining for local conversations
	'private' => false, // Risk of private data release
	'lockeddown' => false, // No editing on these wikis
],

and then much later:

// Feedback configuration
if ( $wmgVisualEditorConsolidateFeedback ) {
	$wgVisualEditorFeedbackAPIURL = 'https://www.mediawiki.org/w/api.php';
	$wgVisualEditorFeedbackTitle = 'VisualEditor/Feedback';
	$wgVisualEditorSourceFeedbackTitle = '2017 wikitext editor/Feedback';
	$wgVisualEditorSuggestionFeedbackAPIURL = 'https://www.mediawiki.org/w/api.php';
	$wgVisualEditorSuggestionFeedbackTitle = 'VisualEditor/Suggestion_Mode/Feedback';
}

So dewiki, zh_yuewiki, and mediawikiwiki itself are all getting the default value of visualeditor-suggestionfeedback-link ("Talk:VisualEditor/Suggestion_Mode/Feedback") rather than that config value above.

Thanks for investigating. I believe that's from a time when we managed dewiki feedback on VE locally, I don't think the configuration is still needed (is there even another VE feedback link currently used?), it could probably be removed?

I tried to apply a quick fix for de:MediaWiki:Visualeditor-suggestionfeedback-link and initially replaced Talk:VisualEditor/Suggestion_Mode/Feedback with mw:Talk:VisualEditor/Suggestion_Mode/Feedback.

That led to a link which was displayed slightly incorrectly ("Mw:" instead of "mw:"), but clicking on it led to https://www.mediawiki.org/wiki/Talk:VisualEditor/Suggestion_Mode/Feedback as desired. But actually submitting feedback didn't work (no post on the project page and no success message).

Screenshot 2026-03-15 at 07.53.46.png (696×1 px, 126 KB)

Instead I've now replaced the message with Wikipedia:Technik/Text/Edit/VisualEditor/Rückmeldungen pointing at our local VE feedback page to prevent users from accidentally creating de:Diskussion:VisualEditor/Suggestion Mode/Feedback. This time submitting a test report worked (diff) but the link is displayed incorrectly again (without "Wikipedia:") and using the mediawiki page would of course be the better option.

Screenshot 2026-03-15 at 08.01.43.png (698×1 px, 117 KB)

Johannnes89 removed BucheonIncheon as the assignee of this task.
Johannnes89 added a subscriber: BucheonIncheon.
Johannnes89 removed a subscriber: BucheonIncheon.
ppelberg set the point value for this task to 2.Mon, Mar 30, 5:56 PM
ppelberg subscribed.

Next steps

  • Stop suggestion feedback from respecting existing central feedback configuration
ppelberg lowered the priority of this task from High to Medium.Tue, Mar 31, 9:32 PM

Change #1268242 had a related patch set uploaded (by DLynch; author: DLynch):

[operations/mediawiki-config@master] VisualEditor editcheck suggestion feedback is always consolidated

https://gerrit.wikimedia.org/r/1268242

Change #1268242 merged by jenkins-bot:

[operations/mediawiki-config@master] VisualEditor editcheck suggestion feedback is always consolidated

https://gerrit.wikimedia.org/r/1268242

Mentioned in SAL (#wikimedia-operations) [2026-04-06T20:07:05Z] <kemayo@deploy1003> Started scap sync-world: Backport for [[gerrit:rMW12682429ffc5|VisualEditor editcheck suggestion feedback is always consolidated (T420123)]], [[gerrit:1267946|Set $wgReadingListsEnableBetaQuickSurvey to true for beta cluster (T422275)]]

Mentioned in SAL (#wikimedia-operations) [2026-04-06T20:08:51Z] <kemayo@deploy1003> kemayo, aude: Backport for [[gerrit:rMW12682429ffc5|VisualEditor editcheck suggestion feedback is always consolidated (T420123)]], [[gerrit:1267946|Set $wgReadingListsEnableBetaQuickSurvey to true for beta cluster (T422275)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Mentioned in SAL (#wikimedia-operations) [2026-04-06T20:18:02Z] <kemayo@deploy1003> Finished scap sync-world: Backport for [[gerrit:rMW12682429ffc5|VisualEditor editcheck suggestion feedback is always consolidated (T420123)]], [[gerrit:1267946|Set $wgReadingListsEnableBetaQuickSurvey to true for beta cluster (T422275)]] (duration: 10m 56s)

Change #1268271 had a related patch set uploaded (by DLynch; author: DLynch):

[operations/mediawiki-config@master] VisualEditorSuggestionFeedback: undo the addition of Talk to the URL

https://gerrit.wikimedia.org/r/1268271

Change #1268271 merged by jenkins-bot:

[operations/mediawiki-config@master] VisualEditorSuggestionFeedback: undo the addition of Talk to the URL

https://gerrit.wikimedia.org/r/1268271

Mentioned in SAL (#wikimedia-operations) [2026-04-06T20:21:24Z] <kemayo@deploy1003> Started scap sync-world: Backport for [[gerrit:1268271|VisualEditorSuggestionFeedback: undo the addition of Talk to the URL (T420123)]]

Mentioned in SAL (#wikimedia-operations) [2026-04-06T20:22:59Z] <kemayo@deploy1003> kemayo: Backport for [[gerrit:1268271|VisualEditorSuggestionFeedback: undo the addition of Talk to the URL (T420123)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Mentioned in SAL (#wikimedia-operations) [2026-04-06T20:28:31Z] <kemayo@deploy1003> Finished scap sync-world: Backport for [[gerrit:1268271|VisualEditorSuggestionFeedback: undo the addition of Talk to the URL (T420123)]] (duration: 07m 07s)

Okay, the suggestion feedback is no longer part of the centralization config. I posted this feedback from dewiki to make sure it worked: https://www.mediawiki.org/w/index.php?title=Talk:VisualEditor/Suggestion_Mode/Feedback&diff=prev&oldid=8328358

Tried to switch the feedback page from VisualEditor/Suggestion_Mode/Feedback to Talk:VisualEditor/Suggestion_Mode/Feedback, since that was an accidental mixup in the initial deployment that we papered over with a redirect, but I discovered it was a fortunate accident since it turns out that mw.Feedback can't cope with posting to a foreign wiki in a namespace, because it passes the page through mw.Title and that winds up localizing the namespace-name -- and Diskussion:VisualEditor/Suggestion_Mode/Feedback doesn't exist on mediawiki.org. So, reverted that attempt.