Page MenuHomePhabricator

TypeError: this.updateForListener(...).then is not a function
Closed, ResolvedPublicPRODUCTION ERROR

Description

339 errors in last 7 days
https://logstash.wikimedia.org/goto/7566a5076e3980ce88aea1568b40d53f

t Controller.onBranchNodeChange  https://de.wikipedia.org/w/load.php?lang=de&modules=ext.visualEditor.articleTarget%2Cbase%2Ccore%2CdesktopArticleTarget%2CdesktopTarget%2Cdiffing%2CeditCheck%2Cicons%2Cmediawiki%2Cmwalienextension%2Cmwcore%2Cmwextensions%2Cmwformatting%2Cmwgallery%2Cmwimage%2Cmwlanguage%2Cmwlink%2Cmwmeta%2Cmwsave%2Cmwsignature%2Cmwtransclusion%2Csanitize%2Cswitching%2Cwelcome%7Cext.visualEditor.core.desktop%2Cutils%7Cext.visualEditor.mwextensions.desktop%7Cext.visualEditor.mwimage.core&skin=vector-2022&version=1py0x:1402:589
at OO.EventEmitter.emit  https://de.wikipedia.org/w/load.php?lang=de&modules=oojs&skin=vector-2022&version=rwdvu:8:193
at Controller.focusActionForSelection  https://de.wikipedia.org/w/load.php?lang=de&modules=ext.visualEditor.articleTarget%2Cbase%2Ccore%2CdesktopArticleTarget%2CdesktopTarget%2Cdiffing%2CeditCheck%2Cicons%2Cmediawiki%2Cmwalienextension%2Cmwcore%2Cmwextensions%2Cmwformatting%2Cmwgallery%2Cmwimage%2Cmwlanguage%2Cmwlink%2Cmwmeta%2Cmwsave%2Cmwsignature%2Cmwtransclusion%2Csanitize%2Cswitching%2Cwelcome%7Cext.visualEditor.core.desktop%2Cutils%7Cext.visualEditor.mwextensions.desktop%7Cext.visualEditor.mwimage.core&skin=vector-2022&version=1py0x:1401:268
at Controller.onSelect  https://de.wikipedia.org/w/load.php?lang=de&modules=ext.visualEditor.articleTarget%2Cbase%2Ccore%2CdesktopArticleTarget%2CdesktopTarget%2Cdiffing%2CeditCheck%2Cicons%2Cmediawiki%2Cmwalienextension%2Cmwcore%2Cmwextensions%2Cmwformatting%2Cmwgallery%2Cmwimage%2Cmwlanguage%2Cmwlink%2Cmwmeta%2Cmwsave%2Cmwsignature%2Cmwtransclusion%2Csanitize%2Cswitching%2Cwelcome%7Cext.visualEditor.core.desktop%2Cutils%7Cext.visualEditor.mwextensions.desktop%7Cext.visualEditor.mwimage.core&skin=vector-2022&version=1py0x:1400:1000
at Controller.<anonymous>  https://de.wikipedia.org/w/load.php?lang=de&modules=ext.visualEditor.articleTarget%2Cbase%2Ccore%2CdesktopArticleTarget%2CdesktopTarget%2Cdiffing%2CeditCheck%2Cicons%2Cmediawiki%2Cmwalienextension%2Cmwcore%2Cmwextensions%2Cmwformatting%2Cmwgallery%2Cmwimage%2Cmwlanguage%2Cmwlink%2Cmwmeta%2Cmwsave%2Cmwsignature%2Cmwtransclusion%2Csanitize%2Cswitching%2Cwelcome%7Cext.visualEditor.core.desktop%2Cutils%7Cext.visualEditor.mwextensions.desktop%7Cext.visualEditor.mwimage.core&skin=vector-2022&version=1py0x:2131:602
at later  https://de.wikipedia.org/w/load.php?lang=de&modules=ext.CodeMirror.visualEditor.init%7Cext.TemplateSandbox.TemplateSandboxTitleWidget%2Cvisualeditor%7Cext.abuseFilter.visualEditor%7Cext.campaignEvents.postEdit%7Cext.chart.visualEditor%7Cext.cite.parsoid.styles%7Cext.cite.visualEditor%7Cext.citoid.visualEditor%7Cext.citoid.visualEditor.data%2Cicons%7Cext.confirmEdit.CaptchaInputWidget%2CvisualEditor%7Cext.disambiguator.visualEditor%7Cext.geshi.visualEditor%7Cext.kartographer%7Cext.kartographer.editing%2Cutil%2CvisualEditor%7Cext.math.styles%2CvisualEditor%7Cext.score.visualEditor%7Cext.score.visualEditor.icons%7Cext.spamBlacklist.visualEditor%7Cext.templateData.templateDiscovery%7Cext.templateDataGenerator.editPage%7Cext.titleblacklist.visualEditor%7Cext.visualEditor.data%2Cicons-licenses%2CmoduleIcons%2CmoduleIndicators%7Cext.wikihiero.visualEditor%7Cext.wikimediaEvents.visualEditor%7Cjquery.lengthLimit%2Ctablesorter%7Cjquery.tablesorter.styles%7Cmediawiki.ForeignStructuredUpload.BookletLayout%7Cmediawiki.ForeignUpload%2CUpload%2Cpulsatingdot%2Cwidgets%7Cmediawiki.Upload.BookletLayout%7Cmediawiki.action.view.redirectPage%7Cmediawiki.language.months%2Cnames%7Cmediawiki.libs.jpegmeta%7Cmediawiki.page.gallery.styles%7Cmediawiki.skinning.content.parsoid%7Cmediawiki.widgets.AbandonEditDialog%2CCategoryMultiselectWidget%2CDateInputWidget%2CMediaSearch%2CUserInputWidget%2Cstyles%7Cmediawiki.widgets.DateInputWidget.styles%7Cmoment%2Coojs-ui%2Coojs-ui-core%2Coojs-ui-toolbars%2Cspark-md5%2CtreeDiffer%2Cvue%7Coojs-ui-core.icons%2Cstyles%7Coojs-ui-toolbars.icons%7Coojs-ui.styles.icons-accessibility%2Cicons-alerts%2Cicons-content%2Cicons-editing-advanced%2Cicons-editing-citation%2Cicons-editing-list%2Cicons-editing-styling%2Cicons-layout%2Cicons-location%2Cicons-media%2Cicons-moderation%2Cicons-movement%2Cicons-user%2Cindicators&skin=vector-2022&version=996qj:730:115

Steps to replicate the issue (include links if applicable):

What happens?:

What should have happened instead?:

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Event Timeline

Restricted Application changed the subtype of this task from "Bug Report" to "Production Error". · View Herald TranscriptMar 16 2026, 3:01 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change #1253658 had a related patch set uploaded (by DLynch; author: DLynch):

[mediawiki/extensions/VisualEditor@master] EditCheckController: updateForListener should always return a promise

https://gerrit.wikimedia.org/r/1253658

Change #1253658 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] EditCheckController: updateForListener should always return a promise

https://gerrit.wikimedia.org/r/1253658

DLynch moved this task from Code Review to QA on the Editing-team (Editing-2Mar-17Mar-2026) board.
DLynch added a project: Editing QA.
DLynch edited projects, added: Skipped QA; removed: Editing QA.

Actually, I'm going to skip QA on this one, because reproducing it is a pain.