The first time someone toggles Suggestion Mode OFF, present a confirmation that makes them aware that Suggestion Mode will remain OFF across all future edit sessions until they change the state of this toggle

Do we need this? It involves adding a second user-preference for "has seen the suggestion mode post-toggle notice", and someone who has just used the toggle definitely knows about it and where it is when they want to turn suggestions back on.

El T420268#11716413, @DLynch escribió:

The first time someone toggles Suggestion Mode OFF, present a confirmation that makes them aware that Suggestion Mode will remain OFF across all future edit sessions until they change the state of this toggle

Do we need this? It involves adding a second user-preference for "has seen the suggestion mode post-toggle notice", and someone who has just used the toggle definitely knows about it and where it is when they want to turn suggestions back on.

This layer will be especially needed on mobile if we finally decide to hide the Suggestions ToggleButton within the edit handle menu. Anyway, I think it's good to inform the user about this the first time.

In order to block the user with a confirmation message (Dialog), we could use a Toast informing the user that:

• Suggestions have been turned off (related T417827)
• This setting will be saved in future edit sessions (this just the first time when turning off)

	1st time when turning off: "Suggestions turned off. This will apply to future edit sessions."
	Next times: "Suggestions turned off." or "Suggestions turned on."

Icons have to fit on a 20x20px canvas which the lightbulb icon currently fills. The only way to add rays would be to make the bulb smaller, or implement some custom local hack for this particular tool.

This layer will be especially needed on mobile if we finally decide to hide the Suggestions ToggleButton within the edit handle menu. Anyway, I think it's good to inform the user about this the first time.

I think it makes even less of a difference on mobile if the toggle is hidden away. The popup won’t help them find it later, after all, and by navigating to it somewhere in a menu they’ll have proven they know where it is. (On desktop there’s the argument that they might have accidentally flipped it while aiming for a button next to it.)

El T420268#11718761, @Esanders escribió:

Icons have to fit on a 20x20px canvas which the lightbulb icon currently fills. The only way to add rays would be to make the bulb smaller, or implement some custom local hack for this particular tool.

@Esanders the lightbulb icon should be the same size in both OFF and ON states. The only difference is that the ON state includes some sparkles around this lightbulb.

Since icons are created on a 20x20px, the only way to do this possible is including the sparkle as elements separated from the lightbulb icon. The way I implemented the spark elements in the prototype was including the sparkles as lines around the lightbulb icon. I could share the sparkle elements as SVG if needed, or some lines could be added on top of the cdxIconLightbulb icon.

El T420268#11718786, @DLynch escribió:

This layer will be especially needed on mobile if we finally decide to hide the Suggestions ToggleButton within the edit handle menu. Anyway, I think it's good to inform the user about this the first time.

I think it makes even less of a difference on mobile if the toggle is hidden away. The popup won’t help them find it later, after all, and by navigating to it somewhere in a menu they’ll have proven they know where it is. (On desktop there’s the argument that they might have accidentally flipped it while aiming for a button next to it.)

The proposed Toast is to inform the user about the suggestions settings being saved for future edit sessions. If we decide to hide the ToggleButton under a button, then we will need to observe if users find the ToggleButton (either to turn off and on) and if not, solve it.

The proposed Toast is to inform the user about the suggestions settings being saved for future edit sessions. If we decide to hide the ToggleButton under a button, then we will need to observe if users find the ToggleButton (either to turn off and on) and if not, solve it.

Yeah, but the toast will only be seen after the user has demonstrably found the button and experienced toggling suggestions. They're the people who will least need education about it.

The toggle's instrumented, so we have everything we need to tell whether users are finding it in-place. (Though "users who want to find it cannot" is, of course, a thing we cannot read their minds to determine.)

5 does not include the toast. cc @ppelberg

I'm not sure the lightbulb rays are going to be worth the effort. In the real toolbar they make the icon look unbalanced in the space (shifted upwards).

They are also visually inconsistent with our other icons which are confined the 20x20 canvas. As our libraries have no mechanism for displaying oversized icons this also incurs technical debt and maintenance debt, for example the icon is already broken monobook/apex, which doesn't res-colour icons and uses less padding:

The separate image also has to be hard coded (as would any animations - we also don't have a framework for that and it's not easy to do with pure CSS), and any future changes to the toolbar could break the alignment.

I would prefer if we stuck to the existing design patterns unless (cf the existing special character toggle) there is a compelling reason.

Change #1259118 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/VisualEditor@master] Persist suggestion mode toggle state

https://gerrit.wikimedia.org/r/1259118

@Esanders the intention behind adding the rays was to better communicate the Suggestions ON state through a subtle animation. The goal was not decorative, but to reinforce the idea that something is active or “producing ideas,” beyond just a color state that changes.

Regarding consistency, while our icons are 20x20, there are some cases where additional elements can extend beyond the base icon (e.g. a badge on an icon). Regarding the Monobook issue, although we support all skins we typically design and prioritize for the main ones (Vector 2022 and Minerva), ensuring they work well there first.

I think there is value in making the ON state more expressive and visible, especially for discoverability and clarity of the feature. That said, this should not come at the cost of significant technical complexity. If implementing the rays introduces really high complexity, then I would lean towards simplifying and staying within existing icon patterns.

Change #1259118 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Persist suggestion mode toggle state

https://gerrit.wikimedia.org/r/1259118

Drive-by comment to +1 the points @bmartinezcalvo thoughtfully laid out in T420268#11738854.

@Esanders: did you end up implementing the "rays of light" (that's fun to type out!) in this iteration? If not, can you please file a follow-on ticket for doing so?

Suggestion mode state gets stuck if user tries toggling off after clicking the "Add citation" button:

Steps to reproduce:

1. Confirm suggestion mode is enabled
2. Select a suggestion to add a citation
3. Click "Add citation"
4. Try toggling state from enabled to disabled

Experience:
Bulb goes grey to communicate that it's been disabled while suggestion side nav and citation popup remains

Expected experience:
All suggestion mode affordances are closed out

El T420268#11774529, @EAkinloose escribió:

Experience:
Bulb goes grey to communicate that it's been disabled while suggestion side nav and citation popup remains

The ToggleButton will need to communicate its state of toggled ON/OFF by representing the rays in the ON state and also the badge (being implemented in T420386) will need to communicate that disabled state.

Colors used:

• lightbulb icon on/off: color-disabled
• badge off: background-color-disabled and number color-disabled-emphasized
• badge on: border-color-disabled and number color-disabled-emphasized

In T420268#11759862, @ppelberg wrote:

Drive-by comment to +1 the points @bmartinezcalvo thoughtfully laid out in T420268#11738854.

@Esanders: did you end up implementing the "rays of light" (that's fun to type out!) in this iteration? If not, can you please file a follow-on ticket for doing so?

Not in this iteration as there were issues with horizontal alignment as the rays have to be a separate element. Filed T421997

In T420268#11774529, @EAkinloose wrote:

Suggestion mode state gets stuck if user tries toggling off after clicking the "Add citation" button...

@EAkinloose: great spot. Two follow-up questions for you:

1. What (if any) other issues/unexpected behavior (beyond the quoted bit above) did you encounter when QA'ing this task?
2. Could you please review T424101 and ensure it accurately describes the issue you encountered ?

In T420268#11847506, @ppelberg wrote:

In T420268#11774529, @EAkinloose wrote:

Suggestion mode state gets stuck if user tries toggling off after clicking the "Add citation" button...

@EAkinloose: great spot. Two follow-up questions for you:

1. What (if any) other issues/unexpected behavior (beyond the quoted bit above) did you encounter when QA'ing this task?
2. Could you please review T424101 and ensure it accurately describes the issue you encountered ?

No other issues that are yet to be addressed and https://phabricator.wikimedia.org/T424101 accurately describes what's needed.

In T420268#11910025, @EAkinloose wrote:

In T420268#11847506, @ppelberg wrote:

In T420268#11774529, @EAkinloose wrote:

Suggestion mode state gets stuck if user tries toggling off after clicking the "Add citation" button...

@EAkinloose: great spot. Two follow-up questions for you:

1. What (if any) other issues/unexpected behavior (beyond the quoted bit above) did you encounter when QA'ing this task?
2. Could you please review T424101 and ensure it accurately describes the issue you encountered ?

No other issues that are yet to be addressed and https://phabricator.wikimedia.org/T424101 accurately describes what's needed.

Excellent. Thank you for confirming. Resolving!