Maniphest T420315

Error: Cannot modify readonly property MediaWiki\Category\CategoryViewer::$query
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Assigned To

Authored By

	Aklapper
	Mar 17 2026, 7:57 AM

Description

Error

service.version: 1.46.0-wmf.20
timestamp: 2026-03-17T07:44:00.960Z
labels.phpversion: 8.3.30
trace.id: 7d887fc5-6229-4cbf-8779-3dbf50cf9fdf
Find trace.id in Logstash

labels.normalized_message

[{reqId}] {exception_url}   Error: Cannot modify readonly property MediaWiki\Category\CategoryViewer::$query

Frame	Location	Call
from	/srv/mediawiki/php-1.46.0-wmf.20/includes/Category/CategoryViewer.php(104)
#0	/srv/mediawiki/php-1.46.0-wmf.20/includes/Page/CategoryPage.php(93)	MediaWiki\Category\CategoryViewer->__construct(MediaWiki\Page\WikiCategoryPage, MediaWiki\Context\RequestContext, array, array, array)
#1	/srv/mediawiki/php-1.46.0-wmf.20/includes/Page/CategoryPage.php(53)	MediaWiki\Page\CategoryPage->closeShowCategory()
#2	/srv/mediawiki/php-1.46.0-wmf.20/includes/Actions/ViewAction.php(71)	MediaWiki\Page\CategoryPage->view()
#3	/srv/mediawiki/php-1.46.0-wmf.20/includes/Actions/ActionEntryPoint.php(739)	MediaWiki\Actions\ViewAction->show()
#4	/srv/mediawiki/php-1.46.0-wmf.20/includes/Actions/ActionEntryPoint.php(510)	MediaWiki\Actions\ActionEntryPoint->performAction(MediaWiki\Page\CategoryPage, MediaWiki\Title\Title)
#5	/srv/mediawiki/php-1.46.0-wmf.20/includes/Actions/ActionEntryPoint.php(144)	MediaWiki\Actions\ActionEntryPoint->performRequest()
#6	/srv/mediawiki/php-1.46.0-wmf.20/includes/MediaWikiEntryPoint.php(180)	MediaWiki\Actions\ActionEntryPoint->execute()
#7	/srv/mediawiki/php-1.46.0-wmf.20/index.php(44)	MediaWiki\MediaWikiEntryPoint->run()
#8	/srv/mediawiki/w/index.php(3)	require(string)
#9	{main}

Impact

All and any pages in the Category: namespace seem to throw an exception on testwiki - I went to https://test.wikipedia.org/w/index.php?title=Special:Categories and clicked a few links, all of them are broken.

Notes

Details

MediaWiki Version: 1.46.0-wmf.20
Request URL: https://test.wikipedia.org/w/index.php?from=*&title=Category:*

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Remove misplaced readonly from CategoryViewer::$query	mediawiki/core	wmf/1.46.0-wmf.20	+1 -1
	Remove misplaced readonly from CategoryViewer::$query	mediawiki/core	master	+1 -1

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved	Release	Aklapper	T413811 1.46.0-wmf.20 deployment blockers
		Resolved	PRODUCTION ERROR	thiemowmde	T420315 Error: Cannot modify readonly property MediaWiki\Category\CategoryViewer::$query

Event Timeline

Aklapper created this task.Mar 17 2026, 7:57 AM

Aklapper triaged this task as Unbreak Now! priority.

https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1252119 / https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/core/+/c11ab29829509ca9869ab03efa777d5a2e7f0c08 ("Use PHP8 constructor property promotion and readonly properties") changed the method signature of CategoryViewer::__construct() by making some passed parameters read-only.

I assume that a simple revert would unblock the train?

Aklapper added a project: MediaWiki-Categories.Mar 17 2026, 8:01 AM

Also CC'ing the patch reviewers to get an opinion (and ideally a fixing patch) whether to fully revert or to just make a smaller followup change for this train blocker.

Change #1254142 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/core@master] Remove misplaced readonly from CategoryViewer::$query

https://gerrit.wikimedia.org/r/1254142

gerritbot added a project: Patch-For-Review.Mar 17 2026, 10:29 AM

thiemowmde claimed this task.Mar 17 2026, 10:30 AM

thiemowmde added projects: Unplanned-Sprint-Work, WMDE-TechWish-Sprint-2026-03-03-Spinach.

thiemowmde moved this task from Sprint Backlog to Tech Review on the WMDE-TechWish-Sprint-2026-03-03-Spinach board.

Change #1254142 merged by jenkins-bot:

[mediawiki/core@master] Remove misplaced readonly from CategoryViewer::$query

https://gerrit.wikimedia.org/r/1254142

Change #1254166 had a related patch set uploaded (by Zabe; author: Thiemo Kreuz (WMDE)):

[mediawiki/core@wmf/1.46.0-wmf.20] Remove misplaced readonly from CategoryViewer::$query

https://gerrit.wikimedia.org/r/1254166

ReleaseTaggerBot added a project: MW-1.46-notes (1.46.0-wmf.21; 2026-03-24).Mar 17 2026, 12:00 PM

Zabe moved this task from Untriaged to Jan–Mar 2026 on the Wikimedia-production-error board.Mar 17 2026, 12:11 PM

thiemowmde moved this task from Tech Review to Done on the WMDE-TechWish-Sprint-2026-03-03-Spinach board.Mar 17 2026, 12:19 PM

Change #1254166 merged by jenkins-bot:

[mediawiki/core@wmf/1.46.0-wmf.20] Remove misplaced readonly from CategoryViewer::$query

https://gerrit.wikimedia.org/r/1254166

Mentioned in SAL (#wikimedia-operations) [2026-03-17T13:09:07Z] <aklapper@deploy2002> Started scap sync-world: Backport for [[gerrit:1254166|Remove misplaced readonly from CategoryViewer::$query (T420315)]]

Mentioned in SAL (#wikimedia-operations) [2026-03-17T13:11:10Z] <aklapper@deploy2002> zabe, aklapper: Backport for [[gerrit:1254166|Remove misplaced readonly from CategoryViewer::$query (T420315)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Mentioned in SAL (#wikimedia-operations) [2026-03-17T13:15:38Z] <aklapper@deploy2002> Finished scap sync-world: Backport for [[gerrit:1254166|Remove misplaced readonly from CategoryViewer::$query (T420315)]] (duration: 06m 31s)

Thank you everyone for the quick action and help!

Maintenance_bot removed a project: Patch-For-Review.Mar 17 2026, 1:30 PM

ReleaseTaggerBot edited projects, added MW-1.46-notes (1.46.0-wmf.20; 2026-03-17); removed MW-1.46-notes (1.46.0-wmf.21; 2026-03-24).Mar 17 2026, 2:00 PM

jijiki mentioned this in T422455: Massive increase in "EtcdConfig failed to fetch data: Timeout was reached" warnings and errors since March 17th.Apr 7 2026, 9:41 AM

Error: Cannot modify readonly property MediaWiki\Category\CategoryViewer::$queryClosed, ResolvedPublicPRODUCTION ERRORActions