Page MenuHomePhabricator

Image Browsing: Port thumbnail extraction logic to PHP
Closed, ResolvedPublic5 Estimated Story Points

Description

Previously, MMV handled thumbnail detection/exclusions on the client side (since no ui changes happened until the user actually clicked on an image).

Now that we want a carousel element to appear at the top of applicable pages before JS initializes, we need to port the this logic from JS to PHP

Requirements

  • The existing JS logic is re-implemented in PHP
  • Any additional exclusions we handled in the ImageBrowsing prototype are also handled
  • Excluded selectors could be exposed as a config var that the community could extend/override as need
  • Ideally this logic would be used by both the desktop viewer as well as the new one that we are building (both should refer to the same config variable at least)
  • We should refer to the cached parser output for performance reasons

Event Timeline

egardner set the point value for this task to 5.
egardner moved this task from Needs Refinement to Ready on the Reader Growth Team board.

Change #1266305 had a related patch set uploaded (by Marco Fossati; author: Marco Fossati):

[mediawiki/extensions/ReaderExperiments@master] ImageBrowsing: extract image data in the back end

https://gerrit.wikimedia.org/r/1266305

Change #1267037 had a related patch set uploaded (by Marco Fossati; author: Marco Fossati):

[mediawiki/extensions/MultimediaViewer@master] Carousel: extract image data in the back end

https://gerrit.wikimedia.org/r/1267037

Change #1266305 abandoned by Marco Fossati:

[mediawiki/extensions/ReaderExperiments@master] ImageBrowsing: extract image data in the back end

Reason:

In favor of 1267037

https://gerrit.wikimedia.org/r/1266305

Change #1267037 merged by jenkins-bot:

[mediawiki/extensions/MultimediaViewer@master] ImageBrowsing: extract image data in the back end

https://gerrit.wikimedia.org/r/1267037

Change #1268626 had a related patch set uploaded (by Kimberly Sarabia; author: Kimberly Sarabia):

[mediawiki/extensions/MultimediaViewer@master] [DONOTMERGE] Carousel QA Testing for Patch Demo

https://gerrit.wikimedia.org/r/1268626

Test wiki created on Patch demo by KSarabia-WMF using patch(es) linked to this task:
https://79656a5191.catalyst.wmcloud.org/w/

Change #1268671 had a related patch set uploaded (by Eric Gardner; author: Eric Gardner):

[mediawiki/extensions/MultimediaViewer@master] MMV Carousel: Support MFContentProvider, add click handler to items

https://gerrit.wikimedia.org/r/1268671

Test wiki on Patch demo by KSarabia-WMF using patch(es) linked to this task was deleted:

https://79656a5191.catalyst.wmcloud.org/w/

Change #1268626 abandoned by Kimberly Sarabia:

[mediawiki/extensions/MultimediaViewer@master] [DONOTMERGE] Carousel QA Testing for Patch Demo

Reason:

Making a new patch demo for qa

https://gerrit.wikimedia.org/r/1268626

Change #1268671 merged by jenkins-bot:

[mediawiki/extensions/MultimediaViewer@master] MMV Carousel: Support MFContentProvider, add click handler to items

https://gerrit.wikimedia.org/r/1268671

Change #1269003 had a related patch set uploaded (by Kimberly Sarabia; author: Kimberly Sarabia):

[mediawiki/extensions/MultimediaViewer@master] [DONOTMERGE] Take 2 - Patch Demo Carousel Enabled

https://gerrit.wikimedia.org/r/1269003