Page MenuHomePhabricator

Multiselect <select> item shouldn't have icon and icon padding
Closed, ResolvedPublicBUG REPORT

Description

First mentioned by @Nikerabbit in T414947#11727178.

Steps to replicate the issue (include links if applicable):

  • Have translation admin rights on metawiki
  • Visit https://meta.wikimedia.org/wiki/Special:PageTranslation and click to mark a page for translation
  • Disable JavaScript in your browser (to get the CSS-only version of the language selector widget)
  • Scroll down to the "Priority languages" section

What happens?:

  • There is a down arrow in the right-hand side of the <select> box:

image.png (335×621 px, 64 KB)

What should have happened instead?:

  • When the <select> field has the attribute multiple, it should not get an icon at all, and not have extra padding-right.

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Event Timeline

Change #1259683 had a related patch set uploaded (by Akaza24; author: Akaza24):

[design/codex@main] Select: Remove icon and extra padding for multiselect

https://gerrit.wikimedia.org/r/1259683

Catrope moved this task from Backlog to Pending Release on the Codex board.

Change #1259683 merged by jenkins-bot:

[design/codex@main] Select: Remove icon and extra padding for multiselect

https://gerrit.wikimedia.org/r/1259683

Change #1270170 had a related patch set uploaded (by VolkerE; author: Akaza24):

[design/codex@build-eslint-config-wikimedia-upgrade-T414401] Select: Remove icon and extra padding for multiselect

https://gerrit.wikimedia.org/r/1270170

Change #1270170 abandoned by VolkerE:

[design/codex@build-eslint-config-wikimedia-upgrade-T414401] Select: Remove icon and extra padding for multiselect

https://gerrit.wikimedia.org/r/1270170

Change #1275555 had a related patch set uploaded (by Catrope; author: Catrope):

[mediawiki/core@master] Update Codex from v2.4.0 to v2.5.0

https://gerrit.wikimedia.org/r/1275555

Change #1275555 merged by jenkins-bot:

[mediawiki/core@master] Update Codex from v2.4.0 to v2.5.1

https://gerrit.wikimedia.org/r/1275555