Page MenuHomePhabricator
Create Task
Maniphest T420726

Denote whether a change has already been opened by this user in the PersonalDashboard Review Changes feed
Open, In Progress, HighPublic1 Estimated Story Points
Actions

Description

As users browse the Review Changes feed in the PersonalDashboard, it would be helpful to denote which edits the user has already viewed, so that they can more easily visually scan edits they haven't looked at yet.

Since we're pulling edits from a variety of sources, and not doing so chronologically, it is likely that on a page reload we will display an entirely new set of edits to the user. As such, I think at this stage it is OK for this record to only persist for the duration of a single visit to the feed.

Designs

These designs assume that T421901 has been completed.

Figma here.

Frame 427318684.png (1×2 px, 280 KB)

Acceptance criteria

  • When a user clicks an entry in the Review Changes or Active Discussions modules, the card changes visual style to indicate it has been selected already.
  • This state does not need to persist beyond the active user session/page load.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Improve UI of Review Changes and Active Discussions cardsmediawiki/extensions/PersonalDashboardmaster+560 -923
Customize query in gerrit

Related Objects
Search...

Event Timeline

Samwalton9-WMF created this task.Mar 20 2026, 1:01 PM
Restricted Application added a project: Moderator-Tools-Team. · View Herald TranscriptMar 20 2026, 1:01 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Samwalton9-WMF moved this task from Backlog to Review Changes on the PersonalDashboard board.Mar 20 2026, 1:03 PM
Samwalton9-WMF moved this task from Inbox to Design backlog on the Moderator-Tools-Team board.Mar 20 2026, 2:47 PM
Samwalton9-WMF added a parent task: T422599: WE1.11: Improve Review Changes.Apr 8 2026, 10:46 AM
Lwilson-ctr updated the task description. (Show Details)Apr 10 2026, 1:31 PM
Samwalton9-WMF added a subtask: T421901: Improve UI of Review Changes and Active Discussions cards.Apr 10 2026, 1:41 PM
Samwalton9-WMF triaged this task as High priority.Tue, Apr 14, 12:01 PM
Samwalton9-WMF updated the task description. (Show Details)
Samwalton9-WMF moved this task from Design backlog to To be estimated on the Moderator-Tools-Team board.
Samwalton9-WMF added a project: OKR-Work (WE1 FY2025-26).Tue, Apr 14, 2:13 PM
Samwalton9-WMF updated the task description. (Show Details)Tue, Apr 14, 2:21 PM
Samwalton9-WMF added a subtask: T422607: Define and add Pinia storage for PersonalDashboard Review Changes module.
Scardenasmolinar set the point value for this task to 1.Tue, Apr 14, 2:25 PM
Scardenasmolinar moved this task from To be estimated to Estimated on the Moderator-Tools-Team board.
Samwalton9-WMF changed the task status from Open to Stalled.Tue, Apr 14, 3:15 PM
Samwalton9-WMF moved this task from Estimated to Kanban on the Moderator-Tools-Team board.
Samwalton9-WMF edited projects, added Moderator-Tools-Team (Kanban); removed Moderator-Tools-Team.
Dillon changed the status of subtask T421901: Improve UI of Review Changes and Active Discussions cards from Open to In Progress.Tue, Apr 14, 6:34 PM
Samwalton9-WMF edited parent tasks, added: T409059: WE1.11.1: Improve Review Changes module / Surface noteworthy edits; removed: T422599: WE1.11: Improve Review Changes.Tue, Apr 21, 1:24 PM
gerritbot added a comment.Fri, Apr 24, 2:22 PM

Change #1276815 had a related patch set uploaded (by Dillon; author: Dillon):

[mediawiki/extensions/PersonalDashboard@master] Improve UI of Review Changes and Active Discussions cards

https://gerrit.wikimedia.org/r/1276815

gerritbot added a project: Patch-For-Review.Fri, Apr 24, 2:22 PM
Dillon changed the task status from Stalled to In Progress.Fri, Apr 24, 2:40 PM
Dillon subscribed.

The acceptance criteria for this task explicitly states no persistence is needed, therefore we can unblock it from T422607: Define and add Pinia storage for PersonalDashboard Review Changes module.

Resolved in the Gerrit patch for T421901: Improve UI of Review Changes and Active Discussions cards, as it was trivial to implement using the :visited CSS selector on the <a> tag in ListCard.vue.

Dillon moved this task from Ready to Eng review on the Moderator-Tools-Team (Kanban) board.Fri, Apr 24, 2:40 PM
Kgraessle moved this task from Eng review to Reviewed (waiting for changes) on the Moderator-Tools-Team (Kanban) board.Mon, Apr 27, 10:10 AM
PatchDemoBot added a comment.Wed, Apr 29, 6:16 PM

Test wiki created on Patch demo by DHardy-WMF using patch(es) linked to this task:
https://374f2a3f9e.catalyst.wmcloud.org/w/

Kgraessle moved this task from Reviewed (waiting for changes) to QA on the Moderator-Tools-Team (Kanban) board.Mon, May 4, 12:11 PM
gerritbot added a comment.Mon, May 4, 12:16 PM

Change #1276815 merged by jenkins-bot:

[mediawiki/extensions/PersonalDashboard@master] Improve UI of Review Changes and Active Discussions cards

https://gerrit.wikimedia.org/r/1276815

Maintenance_bot removed a project: Patch-For-Review.Mon, May 4, 12:31 PM
PatchDemoBot added a comment.Tue, May 5, 11:01 PM

Test wiki on Patch demo by DHardy-WMF using patch(es) linked to this task was deleted:

https://374f2a3f9e.catalyst.wmcloud.org/w/

Scardenasmolinar changed the status of subtask T422607: Define and add Pinia storage for PersonalDashboard Review Changes module from Open to In Progress.Fri, May 8, 6:38 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits