Page MenuHomePhabricator

Parsoid incorrectly displays ⟨magiclink-tracking-isbn⟩ at the bottom of pages
Closed, ResolvedPublicBUG REPORT

Description

On https://sv.wikipedia.org/wiki/Polyetylenglykol we can incorrectly see "Sidor som använder magiska ISBN-länkar" (Swedish for "Pages using ISBN magic links") at the bottom. However, the page does not contain any magic links, and the category page https://sv.wikipedia.org/wiki/Kategori:Sidor_som_anv%C3%A4nder_magiska_ISBN-l%C3%A4nkar correctly does not include "Polyetylenglykol".

If we go to https://sv.wikipedia.org/w/index.php?title=Polyetylenglykol&useparsoid=0 instead, everything works as expected.

Event Timeline

ABreault-WMF subscribed.
$ (master *) echo "[[Special:Bokkällor/978-0-444-53214-5|ISBN 978-0-444-53214-5]]" | php bin/parse.php --trace peg
0-[peg]        | ---->    [{"type":"SelfclosingTagTk","name":"wikilink","attribs":[{"k":"href","v":"Special:Bokkällor/978-0-444-53214-5","srcOffsets":[2,2,2,38],"vsrc":"Special:Bokkällor/978-0-444-53214-5"},{"k":"mw:maybeContent","v":[{"type":"SelfclosingTagTk","name":"extlink","attribs":[{"k":"href","v":"Special:BookSources/9780444532145"},{"k":"mw:content","v":"ISBN 978-0-444-53214-5","srcOffsets":[39,39,39,61]},{"k":"typeof","v":"mw:WikiLink/ISBN"}],"dataParsoid":{"stx":"magiclink","tsr":[39,61]}}],"srcOffsets":[39,39,39,61],"vsrc":"ISBN 978-0-444-53214-5"}],"dataParsoid":{"tsr":[0,63],"src":"[[Special:Bokkällor/978-0-444-53214-5|ISBN 978-0-444-53214-5]]"}}]

We're tokenizing an isbn in the wikilink's content and then backing that out as a string at some later stage. However, the category is added in the tokenizer

Change #1256593 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/services/parsoid@master] Stop adding tracking category for magic link in wikilink

https://gerrit.wikimedia.org/r/1256593

Change #1256593 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Stop adding tracking category for magic link in wikilink

https://gerrit.wikimedia.org/r/1256593

Change #1259169 had a related patch set uploaded (by Jgiannelos; author: Jgiannelos):

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.23.0-a23

https://gerrit.wikimedia.org/r/1259169

Change #1259169 merged by jenkins-bot:

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.23.0-a23

https://gerrit.wikimedia.org/r/1259169

Post-deploy and purge, the hidden category is no longer on https://sv.wikipedia.org/wiki/Polyetylenglykol

The hidden category is still on articles where it should not be. https://sv.wikipedia.org/wiki/Lingbo_station

I did ?action=purge on https://sv.wikipedia.org/wiki/Lingbo_station and it is now gone

The cache will turn over in a few weeks time and they should all be gone. Or they can be manually purged. Sorry for the trouble

OK. Thanks! (I purged the article by using our gadget MediaWiki:Gadget-ResavePage.js before I wrote the comment and it didn't help.) URL+&action=purge works.